From: Stefan Richter <stefanr@s5r6.in-berlin.de>
To: August Lilleaas <august@augustl.com>
Cc: linux1394-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Firewire: net: replacing deprecated __attribute__((packed)) with __packed
Date: Mon, 30 May 2011 01:16:44 +0200 [thread overview]
Message-ID: <20110530011644.2d83cb44@stein> (raw)
In-Reply-To: <BANLkTinoaAt4YamyDoOGbsDhCMBGZhz_rw@mail.gmail.com>
On May 30 August Lilleaas wrote:
> On Sun, May 29, 2011 at 11:44 PM, Stefan Richter
> <stefanr@s5r6.in-berlin.de>wrote:
>
> > Who deprecated it and why?
> >
>
> To be frank, the motivation for this patch was a message from script/
> checkpatch.pl when scouring random files for warnings. (This is my first
> contribution to the kernel.)
>
> Just did some much needed investigation though. It was deprecated for
> portability, specifically to avoid GCC specific code. See commit
> 82ddcb040570411fc2d421d96b3e69711c670328.
OK, thanks for the info.
> > Shouldn't you add "#include <linux/compiler.h>" now?
> >
>
> You're right. I'll read up on updating patches and get at it.
I will just add it when I commit the patch.
(One way to update a patch is to make it the top commit, then edit files
and "git add ..." them as necessary, then "git commit --amend". There are
other ways of course.)
--
Stefan Richter
-=====-==-== -=-= ====-
http://arcgraph.de/sr/
next prev parent reply other threads:[~2011-05-29 23:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-29 17:07 [PATCH] Firewire: net: replacing deprecated __attribute__((packed)) with __packed August Lilleaas
2011-05-29 21:44 ` Stefan Richter
[not found] ` <BANLkTinoaAt4YamyDoOGbsDhCMBGZhz_rw@mail.gmail.com>
2011-05-29 22:19 ` August Lilleaas
2011-05-29 23:16 ` Stefan Richter [this message]
2011-06-02 12:07 ` Stefan Richter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110530011644.2d83cb44@stein \
--to=stefanr@s5r6.in-berlin.de \
--cc=august@augustl.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux1394-devel@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.