[PATCH] Firewire: net: replacing deprecated __attribute__((packed)) with __packed

[PATCH] Firewire: net: replacing deprecated __attribute__((packed)) with __packed

[August Lilleaas]

Fixing a deprecation, replacing __attribute__((packed)) with __packed.

Signed-off-by: August Lilleaas <august@augustl.com>
---
 drivers/firewire/net.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/firewire/net.c b/drivers/firewire/net.c
index b9762d0..2e988ca 100644
--- a/drivers/firewire/net.c
+++ b/drivers/firewire/net.c
@@ -73,7 +73,7 @@ struct rfc2734_arp {
 	__be32 fifo_lo;		/* lo 32bits of sender's FIFO addr	*/
 	__be32 sip;		/* Sender's IP Address			*/
 	__be32 tip;		/* IP Address of requested hw addr	*/
-} __attribute__((packed));
+} __packed;
 
 /* This header format is specific to this driver implementation. */
 #define FWNET_ALEN	8
@@ -81,7 +81,7 @@ struct rfc2734_arp {
 struct fwnet_header {
 	u8 h_dest[FWNET_ALEN];	/* destination address */
 	__be16 h_proto;		/* packet type ID field */
-} __attribute__((packed));
+} __packed;
 
 /* IPv4 and IPv6 encapsulation header */
 struct rfc2734_header {
-- 
1.7.5.2

Re: [PATCH] Firewire: net: replacing deprecated __attribute__((packed)) with __packed

[Stefan Richter]

On May 29 August Lilleaas wrote:
> Fixing a deprecation, replacing __attribute__((packed)) with __packed.

Who deprecated it and why?

Shouldn't you add "#include <linux/compiler.h>" now?
-- 
Stefan Richter
-=====-==-== -=-= ===-=
http://arcgraph.de/sr/

[PATCH] Firewire: net: replacing deprecated __attribute__((packed)) with __packed

[August Lilleaas]

Forwarding as plain text, mistakenly sent as HTML mail first.

---------- Forwarded message ----------
From: August Lilleaas <august@augustl.com>
Date: Mon, May 30, 2011 at 12:11 AM
Subject: Re: [PATCH] Firewire: net: replacing deprecated
__attribute__((packed)) with __packed
To: Stefan Richter <stefanr@s5r6.in-berlin.de>
Cc: linux1394-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org


On Sun, May 29, 2011 at 11:44 PM, Stefan Richter
<stefanr@s5r6.in-berlin.de> wrote:
>
> Who deprecated it and why?

To be frank, the motivation for this patch was a message from
script/checkpatch.pl when scouring random files for warnings. (This is
my first contribution to the kernel.)
Just did some much needed investigation though. It was deprecated for
portability, specifically to avoid GCC specific code. See commit
82ddcb040570411fc2d421d96b3e69711c670328.

>
> Shouldn't you add "#include <linux/compiler.h>" now?

You're right. I'll read up on updating patches and get at it.

>
> --
> Stefan Richter
> -=====-==-== -=-= ===-=
> http://arcgraph.de/sr/

Re: [PATCH] Firewire: net: replacing deprecated __attribute__((packed)) with __packed

[Stefan Richter]

On May 30 August Lilleaas wrote:
> On Sun, May 29, 2011 at 11:44 PM, Stefan Richter
> <stefanr@s5r6.in-berlin.de>wrote:
> 
> > Who deprecated it and why?
> >
> 
> To be frank, the motivation for this patch was a message from script/
> checkpatch.pl when scouring random files for warnings. (This is my first
> contribution to the kernel.)
> 
> Just did some much needed investigation though. It was deprecated for
> portability, specifically to avoid GCC specific code. See commit
> 82ddcb040570411fc2d421d96b3e69711c670328.

OK, thanks for the info.

> > Shouldn't you add "#include <linux/compiler.h>" now?
> >
> 
> You're right. I'll read up on updating patches and get at it.

I will just add it when I commit the patch.

(One way to update a patch is to make it the top commit, then edit files
and "git add ..." them as necessary, then "git commit --amend".  There are
other ways of course.)
-- 
Stefan Richter
-=====-==-== -=-= ====-
http://arcgraph.de/sr/

Re: [PATCH] Firewire: net: replacing deprecated __attribute__((packed)) with __packed

[Stefan Richter]

Committed to linux1394-2.6.git master.  Thanks.
-- 
Stefan Richter
-=====-==-== -==- ---=-
http://arcgraph.de/sr/