[Bug 36602] New: Hierarchical Z support for R600

[Bug 36602] New: Hierarchical Z support for R600

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=36602

           Summary: Hierarchical Z support for R600
           Product: DRI
           Version: DRI CVS
          Platform: Other
        OS/Version: All
            Status: NEW
          Severity: enhancement
          Priority: medium
         Component: DRM/Radeon
        AssignedTo: dri-devel@lists.freedesktop.org
        ReportedBy: pelloux@gmail.com


Add Hierarchical Z (HiZ) support for r600g driver.

I'm attaching my work-in-progress patchs to this bug report to keep track of
comments.

This patch adds 3 new env vars :
- R600_EARLYZ : controls whether EarlyZ functionnality is used
(DB_SHADER_CONTROL register)
- R600_HIZ : HiZ enabled/disabled
- R600_HIZ_READ_HACK : this one is a quick hack for debugging HiZ data buffer.
If set, data will be read from HiZ bo instead of depth buffer bo when calling
glReadPixels( ... GL_DEPTH_COMPONENT ...)

General notes on HiZ on r600 :
(all testing done using : ATI Technologies Inc RV770 [Radeon HD 4850])

* HiZ buffer is made of DWORD entries. Each DWORD represents one tile (4x4 or
8x8 pixels depending DB_HTILE_SURFACE register fields)
* HiZ buffer does not need to be manually cleared by the driver
* DB_RENDER_CONTROL:RESUMMARIZE_ENABLE bit is not necessary to get it working -
but if enabled it slows things down
* application performance are roughly the same using R600_EARLYZ or R600_HIZ

Know problems :
* Hierarchical Stencil has not been tested
* HiZ buffer data layout is still unclear. As an example : using 640x640 window
and 8x8 tiles. HiZ buffer should contain (640/8)*(640/8) = 6400 entries. When
reading it back using the above hack, it contains 6400 entries but spread on
the 7680 first dwords of the buffer. Therefore HiZ bo if largely oversized for
now (ie = depth buffer size)

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 36602] Hierarchical Z support for R600

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=36602

--- Comment #1 from Pierre-Eric <pelloux@gmail.com> 2011-04-26 00:59:16 PDT ---
Created an attachment (id=46081)
 View: https://bugs.freedesktop.org/attachment.cgi?id=46081
 Review: https://bugs.freedesktop.org/review?bug=36602&attachment=46081

Hiz bo deletion patch

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 36602] Hierarchical Z support for R600

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=36602

--- Comment #2 from Pierre-Eric <pelloux@gmail.com> 2011-04-26 00:59:59 PDT ---
Created an attachment (id=46082)
 View: https://bugs.freedesktop.org/attachment.cgi?id=46082
 Review: https://bugs.freedesktop.org/review?bug=36602&attachment=46082

HiZ initial patch

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 36602] Hierarchical Z support for R600

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=36602

--- Comment #3 from Pierre-Eric <pelloux@gmail.com> 2011-04-26 01:01:54 PDT ---
Created an attachment (id=46083)
 View: https://bugs.freedesktop.org/attachment.cgi?id=46083
 Review: https://bugs.freedesktop.org/review?bug=36602&attachment=46083

kernel side patch to handle TILE_SURFACE commands

(patch built against linux 2.6.38.3)
This one is minimum, and is lacking hiz bo size checks.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 36602] Hierarchical Z support for R600

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=36602

--- Comment #4 from Alex Deucher <agd5f@yahoo.com> 2011-04-26 11:53:25 PDT ---
Thanks for starting on this.  I've provided an overview of of how HiZ and HiS
work on 6xx+ hw and some relevant drm patches here:
http://people.freedesktop.org/~agd5f/htile/
ping me on irc (agd5f) if you have any questions.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 36602] Hierarchical Z support for R600

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=36602

Pierre-Eric Pelloux-Prayer <pelloux@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #46081|0                           |1
        is obsolete|                            |
  Attachment #46082|0                           |1
        is obsolete|                            |

--- Comment #5 from Pierre-Eric Pelloux-Prayer <pelloux@gmail.com> 2011-05-03 02:36:02 PDT ---
Created an attachment (id=46281)
 View: https://bugs.freedesktop.org/attachment.cgi?id=46281
 Review: https://bugs.freedesktop.org/review?bug=36602&attachment=46281

Updated patch

Here's an updated patch.
Main differences are :
- num tile pipes getter
- algo for determining HTILE_SETTINGS value
- htile buffer size is more precisely calculated

Questions :
- actually htile buffer is allocated to : DB_size_in_pixels * 4 / 4*4. This
could be reduced in some case (when using 8x8 tiles for instance). I was
thinking of moving the htile_settings calculation to r600_texture.c (when HiZ
bo is created), and storing the htile_settings value alongside the HiZ bo
pointer, for future usage (mainly when setting HTILE_SETTINGS register) ?
- I sometimes get this kernel error when enabling HiZ :
[  459.432139] WARNING: at drivers/gpu/drm/radeon/radeon_fence.c:248
radeon_fence_wait+0x2a0/0x33f [radeon]()
[  459.432146] Hardware name: MS-7551
[  459.432152] GPU lockup (waiting for 0x0001216B last fence id 0x00012167)
[....]
[  459.432694]  [<ffffffffa02796c1>] ? drm_ioctl+0x273/0x347 [drm]
I'm not sure where does this come from, and how much this could be related to
HiZ ?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 36602] Hierarchical Z support for R600

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=36602

--- Comment #6 from Alex Deucher <agd5f@yahoo.com> 2011-05-26 11:03:48 PDT ---
The htile buffer needs to be bound for the life of the Z/S buffer(s) to be
effective.  I just put together a set of patches to allocate the htile buffer
in the ddx along with the Z and stencil buffers.  It seems to work ok, but I'm
not seeing much change in performance.
http://people.freedesktop.org/~agd5f/htile/

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 36602] Hierarchical Z support for R600

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=36602

--- Comment #7 from Pierre-Eric Pelloux-Prayer <pelloux@gmail.com> 2011-06-01 06:01:47 PDT ---
Created an attachment (id=47419)
 --> (https://bugs.freedesktop.org/attachment.cgi?id=47419)
kernel + x + app logs

I've applied the linked patches and started testing.
Depending on which app I run, kern.log is filling with errors telling that
"htile buffer too small".
I've added some logs to radeon_dri2.c and r600g's r600_state.c to help
understanding the problem.

I'm using Radeon HD 4850 with dual-screen setup (total res: 3360x1050).

It seems that each component (dri2, kernel, mesa) uses a different value for
width/height/pitch, maybe that's the source of the problem ?

The attached file, contains the log for 2 applications : glxgears (working
fine), and gnome-shell (shows some errors).

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 36602] Hierarchical Z support for R600

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=36602

--- Comment #8 from Pierre-Eric Pelloux-Prayer <pelloux@gmail.com> 2011-06-01 06:03:53 PDT ---
Created an attachment (id=47420)
 --> (https://bugs.freedesktop.org/attachment.cgi?id=47420)
openarena rendering errors

I think that the little squares along the diagonal display htile buffer data.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 36602] Hierarchical Z support for R600

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=36602

Pierre-Eric Pelloux-Prayer <pelloux@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #46083|0                           |1
        is obsolete|                            |

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 36602] Hierarchical Z support for R600

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=36602

Pierre-Eric Pelloux-Prayer <pelloux@gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #46281|0                           |1
        is obsolete|                            |

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 36602] Hierarchical Z support for R600

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=36602

--- Comment #9 from Pierre-Eric Pelloux-Prayer <pelloux@gmail.com> 2011-07-19 12:42:53 PDT ---
I've marked previously attached patches as obsolete because the ones hosted
here : http://people.freedesktop.org/~agd5f/htile/ are the most up to date.

All the patches are needed (kernel + mesa ones) to enable HiZ.
They are now mainly in need of testing to see how far from completion we are,
so feedbacks are more than welcome :-)

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 36602] Hierarchical Z support for R600

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=36602

Sven Arvidsson <sa@whiz.se> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sa@whiz.se

--- Comment #10 from Sven Arvidsson <sa@whiz.se> 2011-07-19 15:02:37 PDT ---
It might be a good idea to refresh those patches first, to ease testing.

These two no longer apply cleanly to current git master:
 0003-r600g-check-bo-size-before-enabling-HiZ.patch
 0004-r600g-evergreen-htile-fixes-update-comments.patch

The second part of this one (the changes to radeon_drm.h) seems to be already
in 2.6.39?
 0001-drm-radeon-kms-add-info-query-for-tile-pipes.patch

This one also seems to already be in 2.6.39?
 0003-drm-radeon-kms-add-missing-safe-regs-for-6xx-7xx.patch

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 36602] Hierarchical Z support for R600

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=36602

--- Comment #11 from Alex Deucher <agd5f@yahoo.com> 2011-08-03 08:38:35 PDT ---
New rebased patches:
http://people.freedesktop.org/~agd5f/htile/
Also, fixed a bug in the evergreen htile_offset noticed by Vadim Girlin.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 36602] Hierarchical Z support for R600

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=36602

--- Comment #12 from Sven Arvidsson <sa@whiz.se> 2011-08-04 14:33:09 PDT ---
Created an attachment (id=49931)
 --> (https://bugs.freedesktop.org/attachment.cgi?id=49931)
backtrace

On my HD5670 I get a floating point exception (backtrace attached). Is this a
bug or have I failed to apply one of the patches?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 36602] Hierarchical Z support for R600

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=36602

--- Comment #13 from Vadim <ptpzz@yandex.ru> 2011-08-04 14:47:16 PDT ---
(In reply to comment #12)
> Created an attachment (id=49931)
 --> (https://bugs.freedesktop.org/attachment.cgi?id=49931)
> backtrace
> 
> On my HD5670 I get a floating point exception (backtrace attached). Is this a
> bug or have I failed to apply one of the patches?

It seems kernel patch
(0001-drm-radeon-kms-add-htile-support-to-the-cs-checker.patch) is missing.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 36602] Hierarchical Z support for R600

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=36602

--- Comment #14 from Sven Arvidsson <sa@whiz.se> 2011-08-05 08:17:12 PDT ---
(In reply to comment #13)
> It seems kernel patch
> (0001-drm-radeon-kms-add-htile-support-to-the-cs-checker.patch) is missing.

Hmm, I rebuilt the kernel a second time and have made sure the patch is applied
and I'm still getting the same error.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 36602] Hierarchical Z support for R600

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=36602

--- Comment #15 from Sven Arvidsson <sa@whiz.se> 2011-08-05 08:30:30 PDT ---
I'm applying the patches to linux 3.0 but maybe that's too old already?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 36602] Hierarchical Z support for R600

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=36602

--- Comment #16 from Pierre-Eric Pelloux-Prayer <pelloux@gmail.com> 2011-08-05 08:49:46 PDT ---
(In reply to comment #15)
> I'm applying the patches to linux 3.0 but maybe that's too old already?

Your backtrace show this: "num_tile_pipes = 0" which is wrong.
This value is asked by r600g to kernel using 'RADEON_INFO_NUM_TILE_PIPES'
request.

Linux 3.0 kernel have all in place to handle this request (in radeon_kms.c), so
num_tile_pipes definitely shouldn't be null.

Did you check if your kernel log (or Xorg ?) contain something interesting ?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 36602] Hierarchical Z support for R600

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=36602

--- Comment #17 from Vadim <ptpzz@yandex.ru> 2011-08-05 08:50:33 PDT ---
Created an attachment (id=49966)
 View: https://bugs.freedesktop.org/attachment.cgi?id=49966
 Review: https://bugs.freedesktop.org/review?bug=36602&attachment=49966

mesa patch to print some diagnostic info

(In reply to comment #14)
> Hmm, I rebuilt the kernel a second time and have made sure the patch is applied
> and I'm still getting the same error.

Please post the output of "glxinfo | grep radeon_get" with this mesa patch.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 36602] Hierarchical Z support for R600

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=36602

--- Comment #18 from Alex Deucher <agd5f@yahoo.com> 2011-08-05 08:51:38 PDT ---
For reference, you need to patch the ddx:
http://people.freedesktop.org/~agd5f/htile/0001-dri2-add-support-for-htile-buffers.patch
the drm:
http://people.freedesktop.org/~agd5f/htile/0001-drm-radeon-kms-add-htile-support-to-the-cs-checker.patch
and mesa:
http://people.freedesktop.org/~agd5f/htile/0001-r600g-add-r600_bo_size-helper-function.patch
http://people.freedesktop.org/~agd5f/htile/0002-r600g-add-htile-support.patch
http://people.freedesktop.org/~agd5f/htile/0003-r600g-check-bo-size-before-enabling-HiZ.patch
http://people.freedesktop.org/~agd5f/htile/0004-r600g-evergreen-htile-fixes-update-comments.patch
http://people.freedesktop.org/~agd5f/htile/0005-r600g-make-sure-we-allocate-htile-for-fbo-case.patch

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 36602] Hierarchical Z support for R600

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=36602

--- Comment #19 from Andy Furniss <lists@andyfurniss.entadsl.com> 2011-08-05 12:24:33 PDT ---
(In reply to comment #18)
> For reference, you need to patch the ddx:
> http://people.freedesktop.org/~agd5f/htile/0001-dri2-add-support-for-htile-buffers.patch
> the drm:
> http://people.freedesktop.org/~agd5f/htile/0001-drm-radeon-kms-add-htile-support-to-the-cs-checker.patch
> and mesa:
> http://people.freedesktop.org/~agd5f/htile/0001-r600g-add-r600_bo_size-helper-function.patch
> http://people.freedesktop.org/~agd5f/htile/0002-r600g-add-htile-support.patch
> http://people.freedesktop.org/~agd5f/htile/0003-r600g-check-bo-size-before-enabling-HiZ.patch
> http://people.freedesktop.org/~agd5f/htile/0004-r600g-evergreen-htile-fixes-update-comments.patch
> http://people.freedesktop.org/~agd5f/htile/0005-r600g-make-sure-we-allocate-htile-for-fbo-case.patch

I just tried these on my rv790 with d-r-t kernel ( plus "fix version comment
due to merge timing" so the drm patch would apply cleanly).

I don't get any exceptions or errors, but I do get some minor corruption on
some mesa demos and openarena. Nexuiz and etqw looked OK.

The corruption varies between runs and isn't always present or as bad as the
attached image. It's often just a few patches almost always running along the
diagonal top left to bottom right.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 36602] Hierarchical Z support for R600

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=36602

--- Comment #20 from Andy Furniss <lists@andyfurniss.entadsl.com> 2011-08-05 12:29:10 PDT ---
Created an attachment (id=49972)
 --> (https://bugs.freedesktop.org/attachment.cgi?id=49972)
cubemap demo showing Hiz corruption.

Other demos seem to have only the diagonal affected not the bottom like this
one.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 36602] Hierarchical Z support for R600

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=36602

--- Comment #21 from Sven Arvidsson <sa@whiz.se> 2011-08-05 12:33:37 PDT ---
(In reply to comment #17)
> 
> Please post the output of "glxinfo | grep radeon_get" with this mesa patch.

Only this line is printed:
radeon_get_num_backends: 0 2


I *think* the problem is that linux 3.0 only uses version 2.10 of the kms
wrapper, where as the call to radeon_get_backend_map(radeon) in r600_drm.c only
happens when the minor version is >= 11. 

Just changing this value to 10 both makes the second line appear
(radeon_get_num_tile_pipes: 0 4) and gets working 3D again, but I guess I
really need a later kernel :)

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 36602] Hierarchical Z support for R600

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=36602

--- Comment #22 from Sven Arvidsson <sa@whiz.se> 2011-08-06 12:18:04 PDT ---
I followed Andy's advice and grabbed a d-r-t kernel, now everything seems to be
running okay.

On my HD5670 I haven't noticed any difference in performance, OTOH neither do I
get the corruption mentioned, cubemap renders correctly.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 36602] Hierarchical Z support for R600

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=36602

Sven Arvidsson <sa@whiz.se> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #49931|0                           |1
        is obsolete|                            |

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 36602] Hierarchical Z support for R600

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=36602

--- Comment #23 from Andy Furniss <lists@andyfurniss.entadsl.com> 2011-08-07 03:05:19 PDT ---
(In reply to comment #22)
> I followed Andy's advice and grabbed a d-r-t kernel, now everything seems to be
> running okay.
> 
> On my HD5670 I haven't noticed any difference in performance, OTOH neither do I
> get the corruption mentioned, cubemap renders correctly.

I've tested a bit more and I don't always see it when just running and
individual app. 

I have a script that runs the mesa demos in alphabetical order - and so far
running like this I have always seen it on some random selection of the 3D
demos.

fbo_firecube is often OK, but if it does show it, then the corruption will be
along the diagonal of the faces of the rotating cube and not across the window
like the others.

Openarena is the only game I've seen it with. The corrupted squares/rectangles
have varying content and also get the bloom effect applied to them.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 36602] Hierarchical Z support for R600

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=36602

--- Comment #24 from Andy Furniss <lists@andyfurniss.entadsl.com> 2011-08-07 11:18:39 PDT ---
(In reply to comment #19)

> I don't get any exceptions or errors, but I do get some minor corruption on
> some mesa demos and openarena. Nexuiz and etqw looked OK.

Tried the patches on my AGP rv670 and rather than corruption I get GPU
timeouts/resets.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 36602] Hierarchical Z support for R600

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=36602

--- Comment #25 from Andy Furniss <lists@andyfurniss.entadsl.com> 2011-08-12 07:20:07 PDT ---
(In reply to comment #24)

More running with my rv790 and I've found that if I re-size gears then at
certain sizes I get these.

radeon 0000:01:00.0: htile buffer too small (384x264 (4x4) -> 430848 have
430080)
radeon 0000:01:00.0: r600_packet3_check:1550 invalid cmd stream 523

some different sizes that fail -

 radeon 0000:01:00.0: htile buffer too small (640x264 (4x4) -> 718080 have
716800)

 radeon 0000:01:00.0: htile buffer too small (512x392 (4x4) -> 852992 have
851968)

radeon 0000:01:00.0: htile buffer too small (896x520 (4x4) -> 1980160 have
1978368)

radeon 0000:01:00.0: htile buffer too small (640x392 (4x4) -> 1066240 have
1064960)

radeon 0000:01:00.0: htile buffer too small (1152x520 (4x4) -> 2545920 have
2543616)

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 36602] Hierarchical Z support for R600

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=36602

--- Comment #26 from Vladimir Ysikov <grantipak@gmail.com> 2011-08-13 03:57:02 PDT ---
Created an attachment (id=50174)
 --> (https://bugs.freedesktop.org/attachment.cgi?id=50174)
dmesg log

Radeon HD4850
kernel 3.0.1
mesa-git

[behem0th@ArchLinux ~]$ unigine-heaven 
Engine::init(): can't create log file
Loading "/opt/unigine-heaven/bin/../data/heaven_2.5.cfg"...
Engine::init(): clear video settings for "Gallium 0.4 on AMD RV770 2.1 Mesa
7.12-devel (git-e09b706)"
Loading "libGL.so.1"...
Loading "libopenal.so.1"...
AL lib: pulseaudio.c:612: Context did not connect: Connection refused
Set 640x480 windowed video mode
Received signal SIGFPE, floating point exception

[behem0th@ArchLinux ~]$ glxgears
Running synchronized to the vertical refresh.  The framerate should be
approximately the same as the monitor refresh rate.
floating point exception

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 36602] Hierarchical Z support for R600

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=36602

--- Comment #27 from Vladimir Ysikov <grantipak@gmail.com> 2011-08-13 03:58:08 PDT ---
Created an attachment (id=50175)
 --> (https://bugs.freedesktop.org/attachment.cgi?id=50175)
Xorg.log

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 36602] Hierarchical Z support for R600

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=36602

--- Comment #28 from Sven Arvidsson <sa@whiz.se> 2011-08-13 07:50:36 PDT ---
(In reply to comment #26)
[...]
> kernel 3.0.1
[...]
> Received signal SIGFPE, floating point exception
> 

You need a more recent kernel.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 36602] Hierarchical Z support for R600

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=36602

--- Comment #29 from Vladimir Ysikov <grantipak@gmail.com> 2011-08-14 00:37:12 PDT ---
Created an attachment (id=50192)
 --> (https://bugs.freedesktop.org/attachment.cgi?id=50192)
Unigine Heaven

Radeon HD4850
kernel 3.1-rc1
mesa-git

Unigine Heven, World of Tanks (in wine) have rendering errors.

unigine-heaven 1280x1024 Scores: 171
unigine-heaven 1280x1024 hiz Scores: 174

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 36602] Hierarchical Z support for R600

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=36602

--- Comment #30 from ryszardzonk@yahoo.com 2011-08-20 14:57:22 PDT ---
I was starting trying out patches and and compiled kernel drm and ddx driver,
but got number of patching failures while trying out mesa patches at present
git master

below snapset from "0002-r600g-add-htile-support.patch" shows that some stuff
has moved around as mentioned file does not even exists in the repository
anymore... 

can't find file to patch at input line 368
Perhaps you used the wrong -p or --strip option?
The text leading up to this was:
--------------------------
|diff --git a/src/gallium/winsys/r600/drm/r600d.h
b/src/gallium/winsys/r600/drm/r600d.h
|index 8042481..f5d47ae 100644
|--- a/src/gallium/winsys/r600/drm/r600d.h
|+++ b/src/gallium/winsys/r600/drm/r600d.h

please if possible update mesa patchset

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 36602] Hierarchical Z support for R600

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=36602

--- Comment #31 from darkbasic <darkbasic@linuxsystems.it> 2012-02-04 06:10:16 PST ---
Is there any news?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 36602] Hierarchical Z support for R600

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=36602

--- Comment #32 from Jerome Glisse <glisse@freedesktop.org> 2012-02-08 16:27:23 PST ---
Created attachment 56784
  --> https://bugs.freedesktop.org/attachment.cgi?id=56784
r600g patch

r600g patch on top of master

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 36602] Hierarchical Z support for R600

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=36602

--- Comment #33 from Jerome Glisse <glisse@freedesktop.org> 2012-02-08 16:29:04 PST ---
Created attachment 56785
  --> https://bugs.freedesktop.org/attachment.cgi?id=56785
Kernel patch top of lastest linux + tiling

Kernel patch on top of last linus + tiling. All seems to work ok but likely
stuff regressed.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 36602] Hierarchical Z support for R600

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=36602

--- Comment #34 from darkbasic <darkbasic@linuxsystems.it> 2012-02-08 16:46:33 PST ---
Thanks. Any chance hitting git master (masked behind a flag of course)?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 36602] Hierarchical Z support for R600

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=36602

--- Comment #35 from Sven Arvidsson <sa@whiz.se> 2012-02-09 08:50:05 UTC ---
(In reply to comment #33)
> Created attachment 56785 [details] [review]
> Kernel patch top of lastest linux + tiling
> 
> Kernel patch on top of last linus + tiling. All seems to work ok but likely
> stuff regressed.

Didn't work very well for me, glxgears output garbled and logs full of:

[   76.197338] [drm:radeon_cs_ib_chunk] *ERROR* Invalid command stream !
[   76.197524] radeon 0000:01:00.0: evergreen_cs_track_validate_depth:664 htile
surface too small 8192 for 9216 (48 48)
[   76.197527] radeon 0000:01:00.0: evergreen_packet3_check:1972 invalid cmd
stream 487


System environment:
-- system architecture: 32-bit
-- Linux distribution: Debian unstable
-- GPU: REDWOOD
-- Model: XFX Radeon HD 5670 1GB
-- Display connector: DVI
-- xf86-video-ati: e20284409937d784847339b5d466a95012d85940
-- xserver: 1.11.99.901
-- mesa: 26de5273acf1ebe6730b5e72b55b3bcceba167c6 + hiz patch
-- drm: 230ec7d7bbf1e8a7e263d471b21afb08c28eba0c
-- kernel: 3.3.0-rc2 + streamout, tiling and hiz patches

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 36602] Hierarchical Z support for R600

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=36602

--- Comment #36 from Sven Arvidsson <sa@whiz.se> 2012-02-09 08:57:17 PST ---
(In reply to comment #35)
> Didn't work very well for me, glxgears output garbled and logs full of:

Actually scratch that, glxgears in a window doesnt work, but running it
fullscreen and it has no problems.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 36602] Hierarchical Z support for R600

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=36602

--- Comment #37 from Mathieu Belanger <b747xx@gmail.com> 2012-02-09 17:56:37 PST ---
Created attachment 56845
  --> https://bugs.freedesktop.org/attachment.cgi?id=56845
EVE-Online screenshot

Work with EVE-Online.

I have a small problem (you can see on the screen shot).
It's some square of 'not rendered' stuff like if a miscalculation occur somewhere. They are of variable number (stay stable once the game is loaded) and are
placed in diagonal on the screen. On the screen shot I see only 7 but some time it's like 35, all in the same diagonal plane.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 36602] Hierarchical Z support for R600

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=36602

--- Comment #38 from ryszardzonk@yahoo.com 2012-06-02 23:45:20 PDT ---
I just checked back with the bug to see how the development is going and seems
either I am doing something wrong or that patches updated by Jerome Glisse
would need to be updated again for kernel 3.4 or 3.5-rc1 and mesa git master as
they do not apply for me :(

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 36602] Hierarchical Z support for R600

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=36602

--- Comment #39 from darkbasic <darkbasic@linuxsystems.it> 2012-06-03 04:57:25 PDT ---
I fear nobody is working on hi-z anymore...

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 36602] Hierarchical Z support for R600

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=36602

--- Comment #40 from Alex Deucher <agd5f@yahoo.com> 2012-06-03 08:09:46 PDT ---
The kernel patches are already upstream.  All you need are the mesa patches.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 36602] Hierarchical Z support for R600

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=36602

--- Comment #41 from darkbasic <darkbasic@linuxsystems.it> 2012-06-03 08:25:36 PDT ---
Really? Thanks for that, that's an awesome news.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 36602] Hierarchical Z support for R600

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=36602

--- Comment #42 from Jerome Glisse <glisse@freedesktop.org> 2012-06-05 11:44:25 PDT ---
http://people.freedesktop.org/~glisse/0001-r600g-add-htile-support-v4.patch

Is updated patch, this one actually improve performance

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 36602] Hierarchical Z support for R600

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=36602

--- Comment #43 from darkbasic <darkbasic@linuxsystems.it> 2012-06-05 13:27:06 PDT ---
Nice :)

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 36602] Hierarchical Z support for R600

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=36602

--- Comment #44 from Jerome Glisse <glisse@freedesktop.org> 2012-06-06 15:24:55 PDT ---
Updated with more fixes (down to ~100 regression with piglit)

http://people.freedesktop.org/~glisse/0001-r600g-add-htile-support-v6.patch

To enable hyperz
R600_HYPERZ=1 glxgears

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 36602] Hierarchical Z support for R600

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=36602

--- Comment #45 from darkbasic <darkbasic@linuxsystems.it> 2012-06-06 15:33:35 PDT ---
Thanks Jerome

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 36602] Hierarchical Z support for R600

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=36602

--- Comment #46 from Andy Furniss <lists@andyfurniss.entadsl.com> 2012-06-07 04:19:52 PDT ---
(In reply to comment #45)
> Thanks Jerome

+1.

Getting +20% fps with etqw on my 4890.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 36602] Hierarchical Z support for R600

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=36602

--- Comment #47 from Alexandre Demers <alexandre.f.demers@gmail.com> 2012-06-08 10:37:24 PDT ---
The latest patch is a no go on Cayman (running kernel 3.5-rc1, with latest
mesa, drm and DDX). When booting, 3D is unavailable and I have to use the 2D
gnome-shell version. Reverting the v6 patch, 3D is back again.

I'll attach some files at the end of the day (dmesg, .xsession-errors, Xorg
log) about the errors.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 36602] Hierarchical Z support for R600

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=36602

Harald Judt <h.judt@gmx.at> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |h.judt@gmx.at

--- Comment #48 from Harald Judt <h.judt@gmx.at> 2012-06-14 14:58:13 PDT ---
Confirmed on Radeon HD6950, the screen is completely garbled. Could this have
to do with #45018?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 36602] Hierarchical Z support for R600

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=36602

--- Comment #49 from Alexandre Demers <alexandre.f.demers@gmail.com> 2012-07-20 19:15:56 PDT ---
(In reply to comment #48)
> Confirmed on Radeon HD6950, the screen is completely garbled. Could this have
> to do with #45018?

We could disable virtual address space (as proposed in bug 45018) and test the
latest patch (v8 I think, it should be merged soon at some point according to
last week discussion if it hasn't been yet).

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 36602] Hierarchical Z support for R600

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=36602

--- Comment #50 from Alexandre Demers <alexandre.f.demers@gmail.com> 2012-09-06 17:24:39 UTC ---
I've seen some messages about Hi-Z being released, but not enabled and so on a
couple of weeks ago. What is the status?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.

[Bug 36602] Hierarchical Z support for R600

[bugzilla-daemon]

https://bugs.freedesktop.org/show_bug.cgi?id=36602

--- Comment #51 from Zoltán Böszörményi <zboszor@pr.hu> 2012-09-07 10:08:21 UTC ---
I saw this:

commit 5ceb87286f2e1b5b8527ba18a844abf450903175
Author: Jerome Glisse <jglisse@redhat.com>
Date:   Wed Sep 5 15:18:24 2012 -0400

    r600g: order atom emission v3

    To avoid GPU lockup registers must be emited in a specific order
    (no kidding ...). This patch rework atom emission so order in which
    atom are emited in respect to each other is always the same. We
    don't have any informations on what is the correct order so order
    will need to be infered from fglrx command stream.

    v2: add comment warning that atom order should not be taken lightly
    v3: rebase on top of alphatest atom fix

    Signed-off-by: Jerome Glisse <jglisse@redhat.com>

Does this mean the htile patch may also be committed without causing lockups?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel

[Bug 36602] Hierarchical Z support for R600

[bugzilla-daemon]

[-- Attachment #1.1: Type: text/plain, Size: 520 bytes --]

https://bugs.freedesktop.org/show_bug.cgi?id=36602

Alex Deucher <agd5f@yahoo.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |FIXED

--- Comment #52 from Alex Deucher <agd5f@yahoo.com> ---
HyperZ support was merged a while ago.  Closing.

-- 
You are receiving this mail because:
You are the assignee for the bug.

[-- Attachment #1.2: Type: text/html, Size: 1920 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/dri-devel