All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] gpio: Samsung: make Kconfig options def_bool
@ 2011-06-02 17:14 H Hartley Sweeten
  2011-06-03 18:25 ` Grant Likely
  0 siblings, 1 reply; 4+ messages in thread
From: H Hartley Sweeten @ 2011-06-02 17:14 UTC (permalink / raw)
  To: Linux Kernel; +Cc: kyungmin.park, grant.likely

The Samsung GPIO drivers are always built-in when the relevant
platform is selected.  Change the Kconfig symbol to def_bool y
dependant on the platform.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Acked-by: Kyungmin Park <kyungmin.park@samsung.com>
Cc: Grant Likely <grant.likely@secretlab.ca>

---

diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index 18c0b31..2e3cd11 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -87,32 +87,20 @@ config GPIO_IT8761E
 	  Say yes here to support GPIO functionality of IT8761E super I/O chip.
 
 config GPIO_EXYNOS4
-	bool "Samsung Exynos4 GPIO library support"
-	default y
-	depends on ARM && CPU_EXYNOS4210
-	help
-	  Say yes here to support Samsung Exynos4 series SoCs GPIO library
+	def_bool y
+	depends on CPU_EXYNOS4210
 
 config GPIO_PLAT_SAMSUNG
-	bool "Samsung SoCs GPIO library support"
-	default y
-	depends on ARM && SAMSUNG_GPIOLIB_4BIT
-	help
-	  Say yes here to support Samsung SoCs GPIO library
+	def_bool y
+	depends on SAMSUNG_GPIOLIB_4BIT
 
 config GPIO_S5PC100
-	bool "Samsung S5PC100 GPIO library support"
-	default y
-	depends on ARM && CPU_S5PC100
-	help
-	  Say yes here to support Samsung S5PC100 SoCs GPIO library
+	def_bool y
+	depends on CPU_S5PC100
 
 config GPIO_S5PV210
-	bool "Samsung S5PV210/S5PC110 GPIO library support"
-	default y
-	depends on ARM && CPU_S5PV210
-	help
-	  Say yes here to support Samsung S5PV210/S5PC110 SoCs GPIO library
+	def_bool y
+	depends on CPU_S5PV210
 
 config GPIO_PL061
 	bool "PrimeCell PL061 GPIO support"

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] gpio: Samsung: make Kconfig options def_bool
  2011-06-02 17:14 [PATCH] gpio: Samsung: make Kconfig options def_bool H Hartley Sweeten
@ 2011-06-03 18:25 ` Grant Likely
  2011-06-03 18:32   ` H Hartley Sweeten
  0 siblings, 1 reply; 4+ messages in thread
From: Grant Likely @ 2011-06-03 18:25 UTC (permalink / raw)
  To: H Hartley Sweeten; +Cc: Linux Kernel, kyungmin.park

On Thu, Jun 02, 2011 at 10:14:58AM -0700, H Hartley Sweeten wrote:
> The Samsung GPIO drivers are always built-in when the relevant
> platform is selected.  Change the Kconfig symbol to def_bool y
> dependant on the platform.
> 
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Acked-by: Kyungmin Park <kyungmin.park@samsung.com>
> Cc: Grant Likely <grant.likely@secretlab.ca>

Patch doesn't apply on mainline.  Linus already fixed up some stuff.

g.

> 
> ---
> 
> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> index 18c0b31..2e3cd11 100644
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -87,32 +87,20 @@ config GPIO_IT8761E
>  	  Say yes here to support GPIO functionality of IT8761E super I/O chip.
>  
>  config GPIO_EXYNOS4
> -	bool "Samsung Exynos4 GPIO library support"
> -	default y
> -	depends on ARM && CPU_EXYNOS4210
> -	help
> -	  Say yes here to support Samsung Exynos4 series SoCs GPIO library
> +	def_bool y
> +	depends on CPU_EXYNOS4210
>  
>  config GPIO_PLAT_SAMSUNG
> -	bool "Samsung SoCs GPIO library support"
> -	default y
> -	depends on ARM && SAMSUNG_GPIOLIB_4BIT
> -	help
> -	  Say yes here to support Samsung SoCs GPIO library
> +	def_bool y
> +	depends on SAMSUNG_GPIOLIB_4BIT
>  
>  config GPIO_S5PC100
> -	bool "Samsung S5PC100 GPIO library support"
> -	default y
> -	depends on ARM && CPU_S5PC100
> -	help
> -	  Say yes here to support Samsung S5PC100 SoCs GPIO library
> +	def_bool y
> +	depends on CPU_S5PC100
>  
>  config GPIO_S5PV210
> -	bool "Samsung S5PV210/S5PC110 GPIO library support"
> -	default y
> -	depends on ARM && CPU_S5PV210
> -	help
> -	  Say yes here to support Samsung S5PV210/S5PC110 SoCs GPIO library
> +	def_bool y
> +	depends on CPU_S5PV210
>  
>  config GPIO_PL061
>  	bool "PrimeCell PL061 GPIO support"

^ permalink raw reply	[flat|nested] 4+ messages in thread

* RE: [PATCH] gpio: Samsung: make Kconfig options def_bool
  2011-06-03 18:25 ` Grant Likely
@ 2011-06-03 18:32   ` H Hartley Sweeten
  2011-06-03 18:35     ` Grant Likely
  0 siblings, 1 reply; 4+ messages in thread
From: H Hartley Sweeten @ 2011-06-03 18:32 UTC (permalink / raw)
  To: Grant Likely; +Cc: Linux Kernel, kyungmin.park

The Samsung GPIO drivers are always built-in when the relevant
platform is selected.  Change the Kconfig symbol to def_bool y
dependant on the platform.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Acked-by: Kyungmin Park <kyungmin.park@samsung.com>
Cc: Grant Likely <grant.likely@secretlab.ca>

---

v2: updated based on mainline

diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index 4a7f631..2967002 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -87,32 +87,20 @@ config GPIO_IT8761E
 	  Say yes here to support GPIO functionality of IT8761E super I/O chip.
 
 config GPIO_EXYNOS4
-	bool "Samsung Exynos4 GPIO library support"
-	default y if CPU_EXYNOS4210
-	depends on ARM
-	help
-	  Say yes here to support Samsung Exynos4 series SoCs GPIO library
+	def_bool y
+	depends on CPU_EXYNOS4210
 
 config GPIO_PLAT_SAMSUNG
-	bool "Samsung SoCs GPIO library support"
-	default y if SAMSUNG_GPIOLIB_4BIT
-	depends on ARM
-	help
-	  Say yes here to support Samsung SoCs GPIO library
+	def_bool y
+	depends on SAMSUNG_GPIOLIB_4BIT
 
 config GPIO_S5PC100
-	bool "Samsung S5PC100 GPIO library support"
-	default y if CPU_S5PC100
-	depends on ARM
-	help
-	  Say yes here to support Samsung S5PC100 SoCs GPIO library
+	def_bool y
+	depends on CPU_S5PC100
 
 config GPIO_S5PV210
-	bool "Samsung S5PV210/S5PC110 GPIO library support"
-	default y if CPU_S5PV210
-	depends on ARM
-	help
-	  Say yes here to support Samsung S5PV210/S5PC110 SoCs GPIO library
+	def_bool y
+	depends on CPU_S5PV210
 
 config GPIO_PL061
 	bool "PrimeCell PL061 GPIO support"

^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] gpio: Samsung: make Kconfig options def_bool
  2011-06-03 18:32   ` H Hartley Sweeten
@ 2011-06-03 18:35     ` Grant Likely
  0 siblings, 0 replies; 4+ messages in thread
From: Grant Likely @ 2011-06-03 18:35 UTC (permalink / raw)
  To: H Hartley Sweeten; +Cc: Linux Kernel, kyungmin.park

On Fri, Jun 03, 2011 at 01:32:41PM -0500, H Hartley Sweeten wrote:
> The Samsung GPIO drivers are always built-in when the relevant
> platform is selected.  Change the Kconfig symbol to def_bool y
> dependant on the platform.
> 
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Acked-by: Kyungmin Park <kyungmin.park@samsung.com>
> Cc: Grant Likely <grant.likely@secretlab.ca>

Applied, thanks.

g.

> 
> ---
> 
> v2: updated based on mainline
> 
> diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
> index 4a7f631..2967002 100644
> --- a/drivers/gpio/Kconfig
> +++ b/drivers/gpio/Kconfig
> @@ -87,32 +87,20 @@ config GPIO_IT8761E
>  	  Say yes here to support GPIO functionality of IT8761E super I/O chip.
>  
>  config GPIO_EXYNOS4
> -	bool "Samsung Exynos4 GPIO library support"
> -	default y if CPU_EXYNOS4210
> -	depends on ARM
> -	help
> -	  Say yes here to support Samsung Exynos4 series SoCs GPIO library
> +	def_bool y
> +	depends on CPU_EXYNOS4210
>  
>  config GPIO_PLAT_SAMSUNG
> -	bool "Samsung SoCs GPIO library support"
> -	default y if SAMSUNG_GPIOLIB_4BIT
> -	depends on ARM
> -	help
> -	  Say yes here to support Samsung SoCs GPIO library
> +	def_bool y
> +	depends on SAMSUNG_GPIOLIB_4BIT
>  
>  config GPIO_S5PC100
> -	bool "Samsung S5PC100 GPIO library support"
> -	default y if CPU_S5PC100
> -	depends on ARM
> -	help
> -	  Say yes here to support Samsung S5PC100 SoCs GPIO library
> +	def_bool y
> +	depends on CPU_S5PC100
>  
>  config GPIO_S5PV210
> -	bool "Samsung S5PV210/S5PC110 GPIO library support"
> -	default y if CPU_S5PV210
> -	depends on ARM
> -	help
> -	  Say yes here to support Samsung S5PV210/S5PC110 SoCs GPIO library
> +	def_bool y
> +	depends on CPU_S5PV210
>  
>  config GPIO_PL061
>  	bool "PrimeCell PL061 GPIO support"

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2011-06-03 18:35 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-06-02 17:14 [PATCH] gpio: Samsung: make Kconfig options def_bool H Hartley Sweeten
2011-06-03 18:25 ` Grant Likely
2011-06-03 18:32   ` H Hartley Sweeten
2011-06-03 18:35     ` Grant Likely

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.