* [PATCH] mtd: denali: remove calling mtd_device_unregister() after nand_release()
@ 2011-06-03 1:12 ` Axel Lin
0 siblings, 0 replies; 6+ messages in thread
From: Axel Lin @ 2011-06-03 1:12 UTC (permalink / raw)
To: linux-kernel
Cc: Sudhakar Rajashekhara, Jamie Iles, David Woodhouse,
Artem Bityutskiy, linux-mtd
The implementation of nand_release() already call mtd_device_unregister(),
no need to call it again.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
drivers/mtd/nand/denali.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/mtd/nand/denali.c b/drivers/mtd/nand/denali.c
index d527621..e119748 100644
--- a/drivers/mtd/nand/denali.c
+++ b/drivers/mtd/nand/denali.c
@@ -1676,7 +1676,6 @@ static void denali_pci_remove(struct pci_dev *dev)
struct denali_nand_info *denali = pci_get_drvdata(dev);
nand_release(&denali->mtd);
- mtd_device_unregister(&denali->mtd);
denali_irq_cleanup(dev->irq, denali);
--
1.7.4.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] mtd: denali: remove calling mtd_device_unregister() after nand_release()
@ 2011-06-03 1:12 ` Axel Lin
0 siblings, 0 replies; 6+ messages in thread
From: Axel Lin @ 2011-06-03 1:12 UTC (permalink / raw)
To: linux-kernel
Cc: Jamie Iles, Sudhakar Rajashekhara, linux-mtd, David Woodhouse,
Artem Bityutskiy
The implementation of nand_release() already call mtd_device_unregister(),
no need to call it again.
Signed-off-by: Axel Lin <axel.lin@gmail.com>
---
drivers/mtd/nand/denali.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/mtd/nand/denali.c b/drivers/mtd/nand/denali.c
index d527621..e119748 100644
--- a/drivers/mtd/nand/denali.c
+++ b/drivers/mtd/nand/denali.c
@@ -1676,7 +1676,6 @@ static void denali_pci_remove(struct pci_dev *dev)
struct denali_nand_info *denali = pci_get_drvdata(dev);
nand_release(&denali->mtd);
- mtd_device_unregister(&denali->mtd);
denali_irq_cleanup(dev->irq, denali);
--
1.7.4.1
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] mtd: denali: remove calling mtd_device_unregister() after nand_release()
2011-06-03 1:12 ` Axel Lin
@ 2011-06-03 9:20 ` Jamie Iles
-1 siblings, 0 replies; 6+ messages in thread
From: Jamie Iles @ 2011-06-03 9:20 UTC (permalink / raw)
To: Axel Lin
Cc: linux-kernel, Sudhakar Rajashekhara, Jamie Iles, David Woodhouse,
Artem Bityutskiy, linux-mtd
On Fri, Jun 03, 2011 at 09:12:15AM +0800, Axel Lin wrote:
> The implementation of nand_release() already call mtd_device_unregister(),
> no need to call it again.
Good catch!
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Jamie Iles <jamie@jamieiles.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mtd: denali: remove calling mtd_device_unregister() after nand_release()
@ 2011-06-03 9:20 ` Jamie Iles
0 siblings, 0 replies; 6+ messages in thread
From: Jamie Iles @ 2011-06-03 9:20 UTC (permalink / raw)
To: Axel Lin
Cc: Artem Bityutskiy, Sudhakar Rajashekhara, David Woodhouse,
linux-kernel, linux-mtd, Jamie Iles
On Fri, Jun 03, 2011 at 09:12:15AM +0800, Axel Lin wrote:
> The implementation of nand_release() already call mtd_device_unregister(),
> no need to call it again.
Good catch!
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
Acked-by: Jamie Iles <jamie@jamieiles.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mtd: denali: remove calling mtd_device_unregister() after nand_release()
2011-06-03 1:12 ` Axel Lin
@ 2011-06-06 10:07 ` Artem Bityutskiy
-1 siblings, 0 replies; 6+ messages in thread
From: Artem Bityutskiy @ 2011-06-06 10:07 UTC (permalink / raw)
To: Axel Lin
Cc: linux-kernel, Jamie Iles, Sudhakar Rajashekhara, linux-mtd,
David Woodhouse
On Fri, 2011-06-03 at 09:12 +0800, Axel Lin wrote:
> The implementation of nand_release() already call mtd_device_unregister(),
> no need to call it again.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
Pushed to l2-mtd-2.6.git, thanks.
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] mtd: denali: remove calling mtd_device_unregister() after nand_release()
@ 2011-06-06 10:07 ` Artem Bityutskiy
0 siblings, 0 replies; 6+ messages in thread
From: Artem Bityutskiy @ 2011-06-06 10:07 UTC (permalink / raw)
To: Axel Lin
Cc: Jamie Iles, Sudhakar Rajashekhara, linux-mtd, linux-kernel,
David Woodhouse
On Fri, 2011-06-03 at 09:12 +0800, Axel Lin wrote:
> The implementation of nand_release() already call mtd_device_unregister(),
> no need to call it again.
>
> Signed-off-by: Axel Lin <axel.lin@gmail.com>
Pushed to l2-mtd-2.6.git, thanks.
--
Best Regards,
Artem Bityutskiy (Артём Битюцкий)
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-06-06 10:11 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-06-03 1:12 [PATCH] mtd: denali: remove calling mtd_device_unregister() after nand_release() Axel Lin
2011-06-03 1:12 ` Axel Lin
2011-06-03 9:20 ` Jamie Iles
2011-06-03 9:20 ` Jamie Iles
2011-06-06 10:07 ` Artem Bityutskiy
2011-06-06 10:07 ` Artem Bityutskiy
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.