All of lore.kernel.org
 help / color / mirror / Atom feed
From: Daniel Drake <dsd@laptop.org>
To: linux-mmc@vger.kernel.org
Cc: ohad@wizery.com
Subject: [PATCH] mmc: sdio: reset card during power_restore
Date: Sun,  5 Jun 2011 13:38:52 +0100 (BST)	[thread overview]
Message-ID: <20110605123852.BC6F39D401C@zog.reactivated.net> (raw)

mmc_sdio_power_restore() skips some steps that are performed in other
power-related codepaths which are necessary to fully reset the card.
Without this, the card can't be powered up and probe fails.

All these steps are needed, to satisfy the cases of both normal
runtime PM and also suspend/resume situations.

Tested on sd8686 libertas wifi on XO-1.5.

Signed-off-by: Daniel Drake <dsd@laptop.org>
---
 drivers/mmc/core/sdio.c |   15 +++++++++++++++
 1 files changed, 15 insertions(+), 0 deletions(-)

diff --git a/drivers/mmc/core/sdio.c b/drivers/mmc/core/sdio.c
index 8af3330..9170ea2 100644
--- a/drivers/mmc/core/sdio.c
+++ b/drivers/mmc/core/sdio.c
@@ -706,10 +706,25 @@ static int mmc_sdio_power_restore(struct mmc_host *host)
 	BUG_ON(!host->card);
 
 	mmc_claim_host(host);
+
+	/*
+	 * Reset the card by performing the same steps that are taken by
+	 * mmc_rescan_try_freq() and mmc_attach_sdio() during a "normal" probe
+	 */
+	sdio_reset(host);
+	mmc_go_idle(host);
+	mmc_send_if_cond(host, host->ocr_avail);
+
+	ret = mmc_send_io_op_cond(host, 0, NULL);
+	if (ret)
+		goto out;
+
 	ret = mmc_sdio_init_card(host, host->ocr, host->card,
 				mmc_card_keep_power(host));
 	if (!ret && host->sdio_irqs)
 		mmc_signal_sdio_irq(host);
+
+out:
 	mmc_release_host(host);
 
 	return ret;
-- 
1.7.5.2


             reply	other threads:[~2011-06-05 12:38 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-05 12:38 Daniel Drake [this message]
2011-06-05 13:48 ` [PATCH] mmc: sdio: reset card during power_restore Ohad Ben-Cohen
2011-06-07 16:41   ` Daniel Drake
2011-06-07 20:52     ` Ohad Ben-Cohen
2011-06-08  9:20       ` Daniel Drake
2011-06-08  9:33         ` Ohad Ben-Cohen
2011-06-08 13:36           ` Daniel Drake
2011-06-08 14:02             ` Ohad Ben-Cohen
2011-06-08 14:21               ` Daniel Drake
2011-06-08 20:05                 ` Ohad Ben-Cohen
2011-06-08 20:58                   ` Daniel Drake
2011-06-09  3:23                     ` Ohad Ben-Cohen
2011-06-09 15:51                   ` Daniel Drake
2011-06-09 15:59                     ` Ohad Ben-Cohen
2011-06-09 16:21                       ` Daniel Drake
2011-06-09 16:30                         ` Ohad Ben-Cohen
2011-06-09 16:44                           ` Daniel Drake
2011-06-09 17:27                             ` Ohad Ben-Cohen
2011-06-09 17:56                               ` Daniel Drake
2011-06-09 18:25                                 ` Ohad Ben-Cohen
2011-06-09 19:55                                   ` Daniel Drake
2011-06-09 23:27                                     ` Ohad Ben-Cohen
2011-06-10 16:15                                       ` Daniel Drake
2011-06-13 19:52                                         ` Ohad Ben-Cohen
2011-06-16 17:27                                           ` Daniel Drake
2011-06-16 19:03                                             ` Philip Rakity
2011-06-16 21:22                                             ` Ohad Ben-Cohen
2011-06-17 13:58                                               ` Daniel Drake
2011-06-17 14:31                                                 ` Ohad Ben-Cohen
2011-06-17 15:19                                                   ` Daniel Drake
2011-06-19 10:33                                                   ` Daniel Drake
2011-06-19 11:00                                                     ` Ohad Ben-Cohen
2011-06-25 18:23                                                       ` Daniel Drake
2011-06-27 20:26                                                         ` Ohad Ben-Cohen
2011-06-28  9:13                                                           ` zhangfei gao
2011-06-28 11:10                                                             ` Ohad Ben-Cohen
2011-06-29  8:43                                                               ` zhangfei gao
2011-06-29  8:57                                                                 ` Ohad Ben-Cohen
2011-06-29  9:19                                                                   ` zhangfei gao
2011-06-29 15:25                                                                     ` Ohad Ben-Cohen
2011-06-29  8:56                                                             ` Daniel Drake
2011-06-07 21:01     ` Ohad Ben-Cohen
2011-06-25 18:20 Daniel Drake
2011-06-26 12:33 ` Ohad Ben-Cohen
2011-06-26 15:23 ` Chris Ball

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110605123852.BC6F39D401C@zog.reactivated.net \
    --to=dsd@laptop.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=ohad@wizery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.