Re: [PATCH] mmc: sdio: reset card during power_restore

From: Daniel Drake <dsd@laptop.org>
To: Ohad Ben-Cohen <ohad@wizery.com>
Cc: linux-mmc@vger.kernel.org
Subject: Re: [PATCH] mmc: sdio: reset card during power_restore
Date: Sat, 25 Jun 2011 19:23:16 +0100	[thread overview]
Message-ID: <BANLkTikkoD0vaxaFBbPd6UZa=iPJgaK2xQ@mail.gmail.com> (raw)
In-Reply-To: <BANLkTinD-3joE8QgeW07gWMW4gBwQRNzXg@mail.gmail.com>

Hi Ohad,

On 19 June 2011 12:00, Ohad Ben-Cohen <ohad@wizery.com> wrote:
> But I still think it's generally better, given the alternatives.
>
> And since this should not have any bad effect for anyone else, I'm
> also OK with not wrapping the sdio_reset and the CMD5 arg=0 you're
> adding with a quirk.
>
> After that's in place, I plan to completely get rid of
> MMC_CAP_POWER_OFF_CARD, since the only evidence we had when we added
> it was the sd8686, and today we know it's not necessary at all.

Thanks - I've just submitted this patch.

Now we just need you to submit the remaining parts of
http://dev.laptop.org/~dsd/20110609/sd-pwr-debug6.patch - can you take
care of that? I'm not sure if/how it should be split up or how to
write the commit message.

Then we can get rid of MMC_CAP_POWER_OFF_CARD, which would be good to
do ASAP to maximize testing before Linux 3.1.

Thanks,
Daniel