From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] powerpc/85xx: Add basic support for P1023RDS board
Date: Wed, 08 Jun 2011 07:30:39 +0200 [thread overview]
Message-ID: <20110608053040.0347D1AEA1D8@gemini.denx.de> (raw)
In-Reply-To: <1307508687-12522-1-git-send-email-tie-fei.zang@freescale.com>
Dear Roy Zang,
In message <1307508687-12522-1-git-send-email-tie-fei.zang@freescale.com> you wrote:
> The P1023RDS board is the reference board for the P1023 SoC.
>
> Add support for booting it from NOR or NAND, with fixed 2G of DDR, PCIe,
> UART, I2C, etc.
Please fix the checkpatch warnings (7 lines over 80 characters)
...
> +/* ECC will be enabled based on perf_mode environment variable */
> +#undef CONFIG_DDR_ECC
...
> +#undef CONFIG_CLOCKS_IN_MHZ
...
> +#undef CONFIG_SYS_RAMBOOT
...
> +#undef CONFIG_SERIAL_SOFTWARE_FIFO
...
> +#undef CONFIG_SOFT_I2C /* I2C bit-banged */
...
> +#undef CONFIG_WATCHDOG /* watchdog disabled */
...
> +#undef CONFIG_BOOTARGS /* the boot command will set bootargs */
etc. Please do not undef what is not defined in the first place.
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Real Programmers always confuse Christmas and Halloween because
OCT 31 == DEC 25 ! - Andrew Rutherford (andrewr at ucs.adelaide.edu.au)
next prev parent reply other threads:[~2011-06-08 5:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-08 4:51 [U-Boot] [PATCH] powerpc/85xx: Add basic support for P1023RDS board Roy Zang
2011-06-08 5:30 ` Wolfgang Denk [this message]
2011-06-08 5:45 ` Zang Roy-R61911
2011-06-08 9:34 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110608053040.0347D1AEA1D8@gemini.denx.de \
--to=wd@denx.de \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.