From: Zang Roy-R61911 <r61911@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] powerpc/85xx: Add basic support for P1023RDS board
Date: Wed, 8 Jun 2011 05:45:38 +0000 [thread overview]
Message-ID: <2239AC579C7D3646A720227A37E0268115768A@039-SN1MPN1-004.039d.mgd.msft.net> (raw)
In-Reply-To: <20110608053040.0347D1AEA1D8@gemini.denx.de>
> -----Original Message-----
> From: Wolfgang Denk [mailto:wd at denx.de]
> Sent: Wednesday, June 08, 2011 13:31 PM
> To: Zang Roy-R61911
> Cc: u-boot at lists.denx.de; Xu Lei-B33228; Kumar Gala; Wang Haiying-R54964; sun
> york-R58495; Lan Chunhe-B25806
> Subject: Re: [U-Boot] [PATCH] powerpc/85xx: Add basic support for P1023RDS
> board
>
> Dear Roy Zang,
>
> In message <1307508687-12522-1-git-send-email-tie-fei.zang@freescale.com> you
> wrote:
> > The P1023RDS board is the reference board for the P1023 SoC.
> >
> > Add support for booting it from NOR or NAND, with fixed 2G of DDR, PCIe,
> > UART, I2C, etc.
>
> Please fix the checkpatch warnings (7 lines over 80 characters)
I can fix it. In fact, I use checkpatch every time before I send out patch.
If you check the board header file, most of them has this problem.
Do you think
+ /* physical addr of CCSRBAR */
+#define CONFIG_SYS_CCSRBAR_PHYS CONFIG_SYS_CCSRBAR
is better than
+#define CONFIG_SYS_CCSRBAR_PHYS CONFIG_SYS_CCSRBAR /* physical addr of CCSRBAR */
???
Please clarify.
>
> ...
> > +/* ECC will be enabled based on perf_mode environment variable */
> > +#undef CONFIG_DDR_ECC
> ...
> > +#undef CONFIG_CLOCKS_IN_MHZ
> ...
> > +#undef CONFIG_SYS_RAMBOOT
> ...
> > +#undef CONFIG_SERIAL_SOFTWARE_FIFO
> ...
> > +#undef CONFIG_SOFT_I2C /* I2C bit-banged */
> ...
> > +#undef CONFIG_WATCHDOG /* watchdog disabled */
> ...
> > +#undef CONFIG_BOOTARGS /* the boot command will set bootargs
> */
>
> etc. Please do not undef what is not defined in the first place.
Will fix.
Thanks.
Roy
>
>
>
> Best regards,
>
> Wolfgang Denk
>
> --
> DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
> Real Programmers always confuse Christmas and Halloween because
> OCT 31 == DEC 25 ! - Andrew Rutherford (andrewr at ucs.adelaide.edu.au)
next prev parent reply other threads:[~2011-06-08 5:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-08 4:51 [U-Boot] [PATCH] powerpc/85xx: Add basic support for P1023RDS board Roy Zang
2011-06-08 5:30 ` Wolfgang Denk
2011-06-08 5:45 ` Zang Roy-R61911 [this message]
2011-06-08 9:34 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2239AC579C7D3646A720227A37E0268115768A@039-SN1MPN1-004.039d.mgd.msft.net \
--to=r61911@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.