* [PATCH] dma/ep93xx_dma.c: local symbols should be static
@ 2011-06-10 22:15 H Hartley Sweeten
2011-06-11 5:47 ` Mika Westerberg
2011-06-16 4:20 ` Koul, Vinod
0 siblings, 2 replies; 3+ messages in thread
From: H Hartley Sweeten @ 2011-06-10 22:15 UTC (permalink / raw)
To: Linux Kernel; +Cc: mika.westerberg, dan.j.williams, vinod.koul
The symbol 'ep93xx_dma_prep_dma_memcpy' is only used in this driver
and should be marked static.
Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Mika Westerberg <mika.westerberg@iki.fi>
Cc: Dan Williams <dan.j.williams@intel.com>
Cc: Vinod Koul <vinod.koul@intel.com>
---
diff --git a/drivers/dma/ep93xx_dma.c b/drivers/dma/ep93xx_dma.c
index 0766c1e..5d7a49b 100644
--- a/drivers/dma/ep93xx_dma.c
+++ b/drivers/dma/ep93xx_dma.c
@@ -902,7 +902,7 @@ static void ep93xx_dma_free_chan_resources(struct dma_chan *chan)
*
* Returns a valid DMA descriptor or %NULL in case of failure.
*/
-struct dma_async_tx_descriptor *
+static struct dma_async_tx_descriptor *
ep93xx_dma_prep_dma_memcpy(struct dma_chan *chan, dma_addr_t dest,
dma_addr_t src, size_t len, unsigned long flags)
{
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] dma/ep93xx_dma.c: local symbols should be static
2011-06-10 22:15 [PATCH] dma/ep93xx_dma.c: local symbols should be static H Hartley Sweeten
@ 2011-06-11 5:47 ` Mika Westerberg
2011-06-16 4:20 ` Koul, Vinod
1 sibling, 0 replies; 3+ messages in thread
From: Mika Westerberg @ 2011-06-11 5:47 UTC (permalink / raw)
To: H Hartley Sweeten; +Cc: Linux Kernel, dan.j.williams, vinod.koul
On Fri, Jun 10, 2011 at 03:15:05PM -0700, H Hartley Sweeten wrote:
> The symbol 'ep93xx_dma_prep_dma_memcpy' is only used in this driver
> and should be marked static.
>
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Acked-by: Mika Westerberg <mika.westerberg@iki.fi>
> Cc: Dan Williams <dan.j.williams@intel.com>
> Cc: Vinod Koul <vinod.koul@intel.com>
>
> ---
>
> diff --git a/drivers/dma/ep93xx_dma.c b/drivers/dma/ep93xx_dma.c
> index 0766c1e..5d7a49b 100644
> --- a/drivers/dma/ep93xx_dma.c
> +++ b/drivers/dma/ep93xx_dma.c
> @@ -902,7 +902,7 @@ static void ep93xx_dma_free_chan_resources(struct dma_chan *chan)
> *
> * Returns a valid DMA descriptor or %NULL in case of failure.
> */
> -struct dma_async_tx_descriptor *
> +static struct dma_async_tx_descriptor *
> ep93xx_dma_prep_dma_memcpy(struct dma_chan *chan, dma_addr_t dest,
> dma_addr_t src, size_t len, unsigned long flags)
> {
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] dma/ep93xx_dma.c: local symbols should be static
2011-06-10 22:15 [PATCH] dma/ep93xx_dma.c: local symbols should be static H Hartley Sweeten
2011-06-11 5:47 ` Mika Westerberg
@ 2011-06-16 4:20 ` Koul, Vinod
1 sibling, 0 replies; 3+ messages in thread
From: Koul, Vinod @ 2011-06-16 4:20 UTC (permalink / raw)
To: H Hartley Sweeten; +Cc: Linux Kernel, mika.westerberg, dan.j.williams
On Fri, 2011-06-10 at 15:15 -0700, H Hartley Sweeten wrote:
> The symbol 'ep93xx_dma_prep_dma_memcpy' is only used in this driver
> and should be marked static.
>
> Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
> Cc: Mika Westerberg <mika.westerberg@iki.fi>
> Cc: Dan Williams <dan.j.williams@intel.com>
> Cc: Vinod Koul <vinod.koul@intel.com>
Applied Thanks
>
> ---
>
> diff --git a/drivers/dma/ep93xx_dma.c b/drivers/dma/ep93xx_dma.c
> index 0766c1e..5d7a49b 100644
> --- a/drivers/dma/ep93xx_dma.c
> +++ b/drivers/dma/ep93xx_dma.c
> @@ -902,7 +902,7 @@ static void ep93xx_dma_free_chan_resources(struct dma_chan *chan)
> *
> * Returns a valid DMA descriptor or %NULL in case of failure.
> */
> -struct dma_async_tx_descriptor *
> +static struct dma_async_tx_descriptor *
> ep93xx_dma_prep_dma_memcpy(struct dma_chan *chan, dma_addr_t dest,
> dma_addr_t src, size_t len, unsigned long flags)
> {
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
--
~Vinod
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2011-06-16 4:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-06-10 22:15 [PATCH] dma/ep93xx_dma.c: local symbols should be static H Hartley Sweeten
2011-06-11 5:47 ` Mika Westerberg
2011-06-16 4:20 ` Koul, Vinod
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.