All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: git@vger.kernel.org
Cc: "René Scharfe" <rene.scharfe@lsrfire.ath.cx>, git-dev@github.com
Subject: [PATCH 1/2] archive: factor out write phase of tar format
Date: Tue, 14 Jun 2011 14:17:33 -0400	[thread overview]
Message-ID: <20110614181732.GA31635@sigill.intra.peff.net> (raw)

The code to output the tar format for git-archive always
assumes we are writing directly to stdout. Let's factor out
that bit of code so that we can put an in-process gzip
filter in place.

Signed-off-by: Jeff King <peff@peff.net>
---
 archive-tar.c |   22 +++++++++++++++++-----
 1 files changed, 17 insertions(+), 5 deletions(-)

diff --git a/archive-tar.c b/archive-tar.c
index cee06ce..b1aea87 100644
--- a/archive-tar.c
+++ b/archive-tar.c
@@ -10,6 +10,7 @@
 
 static char block[BLOCKSIZE];
 static unsigned long offset;
+static void (*output)(const char *buf, unsigned long size);
 
 static int tar_umask = 002;
 
@@ -17,7 +18,7 @@ static int tar_umask = 002;
 static void write_if_needed(void)
 {
 	if (offset == BLOCKSIZE) {
-		write_or_die(1, block, BLOCKSIZE);
+		output(block, BLOCKSIZE);
 		offset = 0;
 	}
 }
@@ -42,7 +43,7 @@ static void write_blocked(const void *data, unsigned long size)
 		write_if_needed();
 	}
 	while (size >= BLOCKSIZE) {
-		write_or_die(1, buf, BLOCKSIZE);
+		output(buf, BLOCKSIZE);
 		size -= BLOCKSIZE;
 		buf += BLOCKSIZE;
 	}
@@ -66,10 +67,10 @@ static void write_trailer(void)
 {
 	int tail = BLOCKSIZE - offset;
 	memset(block + offset, 0, tail);
-	write_or_die(1, block, BLOCKSIZE);
+	output(block, BLOCKSIZE);
 	if (tail < 2 * RECORDSIZE) {
 		memset(block, 0, offset);
-		write_or_die(1, block, BLOCKSIZE);
+		output(block, BLOCKSIZE);
 	}
 }
 
@@ -234,7 +235,7 @@ static int git_tar_config(const char *var, const char *value, void *cb)
 	return git_default_config(var, value, cb);
 }
 
-int write_tar_archive(struct archiver_args *args)
+static int write_tar_archive_internal(struct archiver_args *args)
 {
 	int err = 0;
 
@@ -248,3 +249,14 @@ int write_tar_archive(struct archiver_args *args)
 		write_trailer();
 	return err;
 }
+
+static void output_write(const char *buf, unsigned long len)
+{
+	write_or_die(1, buf, len);
+}
+
+int write_tar_archive(struct archiver_args *args)
+{
+	output = output_write;
+	return write_tar_archive_internal(args);
+}
-- 
1.7.6.rc1.37.g6d4ed.dirty

             reply	other threads:[~2011-06-14 18:17 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-14 18:17 Jeff King [this message]
2011-06-14 18:18 ` [PATCH 2/2] archive: support gzipped tar files Jeff King
2011-06-14 19:25   ` J.H.
2011-06-14 19:30     ` Jeff King
2011-06-14 19:39   ` René Scharfe
2011-06-14 20:14     ` Jeff King
2011-06-14 20:45       ` Jeff King
2011-06-15 22:30         ` [RFC/PATCH 0/7] user-configurable git-archive output formats Jeff King
2011-06-15 22:31           ` [PATCH 1/7] archive: reorder option parsing and config reading Jeff King
2011-06-15 22:33           ` [PATCH 2/7] archive: add user-configurable tar-filter infrastructure Jeff King
2011-06-15 23:33             ` Junio C Hamano
2011-06-16  0:29               ` Jeff King
2011-06-15 22:33           ` [PATCH 3/7] archive: support user tar-filters via --format Jeff King
2011-06-15 22:33           ` [PATCH 4/7] archive: advertise user tar-filters in --list Jeff King
2011-06-15 22:34           ` [PATCH 5/7] archive: refactor format-guessing from filename Jeff King
2011-06-15 23:48             ` Junio C Hamano
2011-06-16  0:34               ` Jeff King
2011-06-15 22:34           ` [PATCH 6/7] archive: match extensions from user-configured formats Jeff King
2011-06-15 22:35           ` [PATCH 7/7] archive: provide builtin .tar.gz filter Jeff King
2011-06-15 23:55             ` Junio C Hamano
2011-06-15 23:57               ` Junio C Hamano
2011-06-16  0:38               ` Jeff King
2011-06-16  6:27                 ` Junio C Hamano
2011-06-16  6:51                   ` Jeff King
2011-06-16  7:56                     ` Chris Webb
2011-06-16 17:46                       ` Jeff King
2011-06-16 18:02                         ` Junio C Hamano
2011-06-16 18:21                           ` Jeff King
2011-06-16 18:27                             ` John Szakmeister
2011-06-16 18:42                             ` Junio C Hamano
2011-06-16 18:57                               ` Jeff King
2011-06-18 14:52           ` [RFC/PATCH 0/7] user-configurable git-archive output formats René Scharfe
2011-06-18 15:28             ` Jakub Narebski
2011-06-20 15:58             ` Junio C Hamano
2011-06-22  1:19               ` [PATCHv2 0/9] configurable tar compressors Jeff King
2011-06-22  1:20                 ` [PATCHv2 1/9] archive: reorder option parsing and config reading Jeff King
2011-06-22  1:22                 ` [PATCHv2 2/9] archive-tar: don't reload default config options Jeff King
2011-06-22  1:23                 ` [PATCHv2 3/9] archive: refactor list of archive formats Jeff King
2011-06-23 17:05                   ` Thiago Farina
2011-06-23 17:30                     ` Jeff King
2011-06-22  1:24                 ` [PATCHv2 4/9] archive: pass archiver struct to write_archive callback Jeff King
2011-06-22  1:24                 ` [PATCHv2 5/9] archive: move file extension format-guessing lower Jeff King
2011-06-22  1:25                 ` [PATCHv2 6/9] archive: refactor file extension format-guessing Jeff King
2011-06-22  1:26                 ` [PATCHv2 7/9] archive: implement configurable tar filters Jeff King
2011-06-22  1:45                   ` Jeff King
2011-06-22  6:09                   ` René Scharfe
2011-06-22 14:59                     ` Jeff King
2011-06-22  1:27                 ` [PATCHv2 8/9] archive: provide builtin .tar.gz filter Jeff King
2011-06-22  1:35                 ` [PATCHv2 9/9] upload-archive: allow user to turn off filters Jeff King
2011-06-22  3:17                   ` Jeff King
2011-06-21 16:01             ` [RFC/PATCH 0/7] user-configurable git-archive output formats Jeff King
2011-06-18 15:40           ` René Scharfe
2011-06-14 20:30   ` [PATCH 2/2] archive: support gzipped tar files Junio C Hamano
2011-06-14 20:49     ` Jeff King
2011-06-14 23:40       ` Miles Bader
2011-06-15 22:46         ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110614181732.GA31635@sigill.intra.peff.net \
    --to=peff@peff.net \
    --cc=git-dev@github.com \
    --cc=git@vger.kernel.org \
    --cc=rene.scharfe@lsrfire.ath.cx \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.