All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff King <peff@github.com>
To: "René Scharfe" <rene.scharfe@lsrfire.ath.cx>
Cc: Junio C Hamano <gitster@pobox.com>,
	"J.H." <warthog19@eaglescrag.net>,
	git@vger.kernel.org, git-dev@github.com
Subject: [RFC/PATCH 0/7] user-configurable git-archive output formats
Date: Wed, 15 Jun 2011 18:30:30 -0400	[thread overview]
Message-ID: <20110615223030.GA16110@sigill.intra.peff.net> (raw)
In-Reply-To: <20110614204521.GA12776@sigill.intra.peff.net>

On Tue, Jun 14, 2011 at 04:45:21PM -0400, Jeff King wrote:

> The gzip path is not configurable at all. Probably it should read the
> path and arguments from the config file. In fact, we could even allow
> arbitrary config like:
> 
>   [tarfilter "tgz"]
>     command = gzip -c
>     extension = tgz
>     extension = tar.gz

Here's a series implementing that. You can configure whatever you want,
and it includes builtin gzip configuration by default. You can override
to turn it off, or even switch it to run something like pigz instead.

My biggest reservation with the patches as-is is that they are very
tar-centric and not orthogonal. Specifically, they won't handle:

  1. Other streamable archive formats you would want to pipe through
     compressors. Do any of these actually exist? I guess we could offer
     "pax" as a format eventually, and it might be like tar with
     different defaults? I dunno.

     Fixing this would not be too hard. Instead of these being
     "tarfilters", they would be "archive filters", and they would chain
     to some format, defaulting to "tar".  Since there is no other
     format right now, we could even punt on writing most of the code
     until somebody adds one. But we would want to get the naming of the
     config options right, since those are user-facing. Maybe
     "archivefilter" (unfortunately the more readable archive.filter is
     a little awkward with the way we parse config files)?

  2. In theory you might want to plug in external helpers that are not
     just stream filters, but actually their own container formats (like
     zip). I think people who want 7zip would want this.

     But how does git-archive interact with the helper? By definition
     the data it wants is the set of files, not a single stream. So
     either:

       a. We give the helper a temporary exported checkout, and it
          generates the stream from that.

       b. We use tar as the lingua franca of streaming file containers,
          and let the helper deal with converting to its preferred
          output format.

      Option (a) seems horribly inefficient on disk I/O. And if we did
      want to do that, I think it's largely unrelated to this patch
      series.

      You can actually do option (b) with this series. In its worst
      case, you can do the same as (a): just untar into a temporary
      directory and compress from there. But a well-written helper could
      convert tar into the output format on the fly.

The patches are:

  [1/7]: archive: reorder option parsing and config reading
  [2/7]: archive: add user-configurable tar-filter infrastructure
  [3/7]: archive: support user tar-filters via --format
  [4/7]: archive: advertise user tar-filters in --list
  [5/7]: archive: refactor format-guessing from filename
  [6/7]: archive: match extensions from user-configured formats
  [7/7]: archive: provide builtin .tar.gz filter

-Peff

  reply	other threads:[~2011-06-15 22:30 UTC|newest]

Thread overview: 56+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-14 18:17 [PATCH 1/2] archive: factor out write phase of tar format Jeff King
2011-06-14 18:18 ` [PATCH 2/2] archive: support gzipped tar files Jeff King
2011-06-14 19:25   ` J.H.
2011-06-14 19:30     ` Jeff King
2011-06-14 19:39   ` René Scharfe
2011-06-14 20:14     ` Jeff King
2011-06-14 20:45       ` Jeff King
2011-06-15 22:30         ` Jeff King [this message]
2011-06-15 22:31           ` [PATCH 1/7] archive: reorder option parsing and config reading Jeff King
2011-06-15 22:33           ` [PATCH 2/7] archive: add user-configurable tar-filter infrastructure Jeff King
2011-06-15 23:33             ` Junio C Hamano
2011-06-16  0:29               ` Jeff King
2011-06-15 22:33           ` [PATCH 3/7] archive: support user tar-filters via --format Jeff King
2011-06-15 22:33           ` [PATCH 4/7] archive: advertise user tar-filters in --list Jeff King
2011-06-15 22:34           ` [PATCH 5/7] archive: refactor format-guessing from filename Jeff King
2011-06-15 23:48             ` Junio C Hamano
2011-06-16  0:34               ` Jeff King
2011-06-15 22:34           ` [PATCH 6/7] archive: match extensions from user-configured formats Jeff King
2011-06-15 22:35           ` [PATCH 7/7] archive: provide builtin .tar.gz filter Jeff King
2011-06-15 23:55             ` Junio C Hamano
2011-06-15 23:57               ` Junio C Hamano
2011-06-16  0:38               ` Jeff King
2011-06-16  6:27                 ` Junio C Hamano
2011-06-16  6:51                   ` Jeff King
2011-06-16  7:56                     ` Chris Webb
2011-06-16 17:46                       ` Jeff King
2011-06-16 18:02                         ` Junio C Hamano
2011-06-16 18:21                           ` Jeff King
2011-06-16 18:27                             ` John Szakmeister
2011-06-16 18:42                             ` Junio C Hamano
2011-06-16 18:57                               ` Jeff King
2011-06-18 14:52           ` [RFC/PATCH 0/7] user-configurable git-archive output formats René Scharfe
2011-06-18 15:28             ` Jakub Narebski
2011-06-20 15:58             ` Junio C Hamano
2011-06-22  1:19               ` [PATCHv2 0/9] configurable tar compressors Jeff King
2011-06-22  1:20                 ` [PATCHv2 1/9] archive: reorder option parsing and config reading Jeff King
2011-06-22  1:22                 ` [PATCHv2 2/9] archive-tar: don't reload default config options Jeff King
2011-06-22  1:23                 ` [PATCHv2 3/9] archive: refactor list of archive formats Jeff King
2011-06-23 17:05                   ` Thiago Farina
2011-06-23 17:30                     ` Jeff King
2011-06-22  1:24                 ` [PATCHv2 4/9] archive: pass archiver struct to write_archive callback Jeff King
2011-06-22  1:24                 ` [PATCHv2 5/9] archive: move file extension format-guessing lower Jeff King
2011-06-22  1:25                 ` [PATCHv2 6/9] archive: refactor file extension format-guessing Jeff King
2011-06-22  1:26                 ` [PATCHv2 7/9] archive: implement configurable tar filters Jeff King
2011-06-22  1:45                   ` Jeff King
2011-06-22  6:09                   ` René Scharfe
2011-06-22 14:59                     ` Jeff King
2011-06-22  1:27                 ` [PATCHv2 8/9] archive: provide builtin .tar.gz filter Jeff King
2011-06-22  1:35                 ` [PATCHv2 9/9] upload-archive: allow user to turn off filters Jeff King
2011-06-22  3:17                   ` Jeff King
2011-06-21 16:01             ` [RFC/PATCH 0/7] user-configurable git-archive output formats Jeff King
2011-06-18 15:40           ` René Scharfe
2011-06-14 20:30   ` [PATCH 2/2] archive: support gzipped tar files Junio C Hamano
2011-06-14 20:49     ` Jeff King
2011-06-14 23:40       ` Miles Bader
2011-06-15 22:46         ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110615223030.GA16110@sigill.intra.peff.net \
    --to=peff@github.com \
    --cc=git-dev@github.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=rene.scharfe@lsrfire.ath.cx \
    --cc=warthog19@eaglescrag.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.