From: Arnd Bergmann <arnd@arndb.de> To: Jonas Bonn <jonas@southpole.se> Cc: linux-kernel@vger.kernel.org, devicetree-discuss@lists.ozlabs.org Subject: Re: [PATCH 02/19] OpenRISC: Device tree Date: Sun, 19 Jun 2011 19:19:27 +0200 [thread overview] Message-ID: <201106191919.27737.arnd@arndb.de> (raw) In-Reply-To: <1308483825-6023-3-git-send-email-jonas@southpole.se> On Sunday 19 June 2011 13:43:28 Jonas Bonn wrote: > > The OpenRISC architecture uses the device tree infrastructure for the > platform description. This is currently limited to having a device tree > built into the kernel, but work is underway within the OpenRISC project > to define how this device tree blob should be passed into the kernel from > an external resource. > > Signed-off-by: Jonas Bonn <jonas@southpole.se> Best take devicetree-discuss@lists.ozlabs.org when posting this again. > --- > arch/openrisc/boot/dts/aac.dts | 290 +++++++++++++++++++++++++++++++++++++ > arch/openrisc/boot/dts/atlys.dts | 94 ++++++++++++ > arch/openrisc/boot/dts/system.dts | 88 +++++++++++ > arch/openrisc/include/asm/prom.h | 92 ++++++++++++ > arch/openrisc/kernel/prom.c | 109 ++++++++++++++ > 5 files changed, 673 insertions(+), 0 deletions(-) > create mode 100644 arch/openrisc/boot/dts/aac.dts > create mode 100644 arch/openrisc/boot/dts/atlys.dts > create mode 100644 arch/openrisc/boot/dts/system.dts > create mode 100644 arch/openrisc/include/asm/prom.h > create mode 100644 arch/openrisc/kernel/prom.c > > diff --git a/arch/openrisc/boot/dts/aac.dts b/arch/openrisc/boot/dts/aac.dts > new file mode 100644 > index 0000000..d9e724f > --- /dev/null > +++ b/arch/openrisc/boot/dts/aac.dts > @@ -0,0 +1,290 @@ > +/dts-v1/; > +/ { > + compatible = "orsoc,development-board"; > + #size-cells = <1>; > + #address-cells = <1>; > + > + chosen { > + bootargs = "console=uart,mmio,0x90000000,115200 lpj=200000 debug"; > +/* bootargs = "console=uart,mmio,0x90000000,115200 lpj=200000 root=/dev/nfs rw nfsroot=172.30.0.1:/home/jonas/local/opencores/linux-2.6/arch/or32/support/rootfs,rw,nolock ip=172.30.0.2::::::"; */ > + }; I think having a hardcoded command line here is not really helpful, this should normally be filled by the bootloader. The console settings should probably be probed from the device tree, we have good existing bindings for serial ports. For the lpj value, I would also recommend passing the clock frequency in the device tree in a generic form, so you can compute the delay loop settings from it. Arnd
WARNING: multiple messages have this Message-ID (diff)
From: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org> To: Jonas Bonn <jonas-A9uVI2HLR7kOP4wsBPIw7w@public.gmane.org> Cc: devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Subject: Re: [PATCH 02/19] OpenRISC: Device tree Date: Sun, 19 Jun 2011 19:19:27 +0200 [thread overview] Message-ID: <201106191919.27737.arnd@arndb.de> (raw) In-Reply-To: <1308483825-6023-3-git-send-email-jonas-A9uVI2HLR7kOP4wsBPIw7w@public.gmane.org> On Sunday 19 June 2011 13:43:28 Jonas Bonn wrote: > > The OpenRISC architecture uses the device tree infrastructure for the > platform description. This is currently limited to having a device tree > built into the kernel, but work is underway within the OpenRISC project > to define how this device tree blob should be passed into the kernel from > an external resource. > > Signed-off-by: Jonas Bonn <jonas-A9uVI2HLR7kOP4wsBPIw7w@public.gmane.org> Best take devicetree-discuss-uLR06cmDAlY/bJ5BZ2RsiQ@public.gmane.org when posting this again. > --- > arch/openrisc/boot/dts/aac.dts | 290 +++++++++++++++++++++++++++++++++++++ > arch/openrisc/boot/dts/atlys.dts | 94 ++++++++++++ > arch/openrisc/boot/dts/system.dts | 88 +++++++++++ > arch/openrisc/include/asm/prom.h | 92 ++++++++++++ > arch/openrisc/kernel/prom.c | 109 ++++++++++++++ > 5 files changed, 673 insertions(+), 0 deletions(-) > create mode 100644 arch/openrisc/boot/dts/aac.dts > create mode 100644 arch/openrisc/boot/dts/atlys.dts > create mode 100644 arch/openrisc/boot/dts/system.dts > create mode 100644 arch/openrisc/include/asm/prom.h > create mode 100644 arch/openrisc/kernel/prom.c > > diff --git a/arch/openrisc/boot/dts/aac.dts b/arch/openrisc/boot/dts/aac.dts > new file mode 100644 > index 0000000..d9e724f > --- /dev/null > +++ b/arch/openrisc/boot/dts/aac.dts > @@ -0,0 +1,290 @@ > +/dts-v1/; > +/ { > + compatible = "orsoc,development-board"; > + #size-cells = <1>; > + #address-cells = <1>; > + > + chosen { > + bootargs = "console=uart,mmio,0x90000000,115200 lpj=200000 debug"; > +/* bootargs = "console=uart,mmio,0x90000000,115200 lpj=200000 root=/dev/nfs rw nfsroot=172.30.0.1:/home/jonas/local/opencores/linux-2.6/arch/or32/support/rootfs,rw,nolock ip=172.30.0.2::::::"; */ > + }; I think having a hardcoded command line here is not really helpful, this should normally be filled by the bootloader. The console settings should probably be probed from the device tree, we have good existing bindings for serial ports. For the lpj value, I would also recommend passing the clock frequency in the device tree in a generic form, so you can compute the delay loop settings from it. Arnd
next prev parent reply other threads:[~2011-06-19 17:20 UTC|newest] Thread overview: 51+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-06-19 11:43 OpenRISC Architecture: Request for review Jonas Bonn 2011-06-19 11:43 ` [PATCH 01/19] OpenRISC: Boot code Jonas Bonn 2011-06-19 17:14 ` Arnd Bergmann 2011-06-19 11:43 ` [PATCH 02/19] OpenRISC: Device tree Jonas Bonn 2011-06-19 17:19 ` Arnd Bergmann [this message] 2011-06-19 17:19 ` Arnd Bergmann 2011-06-19 11:43 ` [PATCH 03/19] OpenRISC: Memory management Jonas Bonn 2011-06-19 18:35 ` Arnd Bergmann 2011-06-19 11:43 ` [PATCH 04/19] OpenRISC: Signal handling Jonas Bonn 2011-06-19 11:43 ` [PATCH 05/19] OpenRISC: Build infrastructure Jonas Bonn 2011-06-19 18:57 ` Arnd Bergmann 2011-06-19 11:43 ` [PATCH 06/19] OpenRISC: PTrace Jonas Bonn 2011-06-19 11:43 ` [PATCH 07/19] OpenRISC: DMA Jonas Bonn 2011-06-19 19:02 ` Arnd Bergmann 2011-06-19 11:43 ` [PATCH 08/19] OpenRISC: Timekeeping Jonas Bonn 2011-06-19 19:06 ` Arnd Bergmann 2011-06-19 11:43 ` [PATCH 09/19] OpenRISC: IRQ Jonas Bonn 2011-06-19 19:09 ` Arnd Bergmann 2011-06-19 11:43 ` [PATCH 10/19] OpenRISC: System calls Jonas Bonn 2011-06-19 15:09 ` richard -rw- weinberger 2011-06-19 15:51 ` Jonas Bonn 2011-06-19 21:11 ` Andi Kleen 2011-06-19 11:43 ` [PATCH 11/19] OpenRISC: Idle/Power management Jonas Bonn 2011-06-20 8:20 ` Arnd Bergmann 2011-06-19 11:43 ` [PATCH 12/19] OpenRISC: Scheduling/Process management Jonas Bonn 2011-06-19 19:12 ` Arnd Bergmann 2011-06-19 21:17 ` Andi Kleen 2011-06-19 11:43 ` [PATCH 13/19] OpenRISC: GPIO Jonas Bonn 2011-06-19 11:43 ` [PATCH 14/19] OpenRISC: Module support Jonas Bonn 2011-06-21 20:03 ` Valdis.Kletnieks 2011-06-22 14:26 ` Arnd Bergmann 2011-06-22 19:08 ` [PATCH 1/1] Add default implementations for moduleloader hooks Jonas Bonn 2011-06-22 19:14 ` [PATCH 14/19] OpenRISC: Module support Jonas Bonn 2011-06-22 19:58 ` Arnd Bergmann 2011-06-22 20:05 ` Jonas Bonn 2011-06-22 20:46 ` Arnd Bergmann 2011-06-24 8:52 ` Jonas Bonn 2011-06-24 10:05 ` Arnd Bergmann 2011-06-24 11:06 ` Rusty Russell 2011-06-19 11:43 ` [PATCH 15/19] OpenRISC: Traps Jonas Bonn 2011-06-19 11:43 ` [PATCH 16/19] OpenRISC: Headers Jonas Bonn 2011-06-19 19:39 ` Arnd Bergmann 2011-06-19 19:43 ` Arnd Bergmann 2011-06-19 20:19 ` Geert Uytterhoeven 2011-06-19 11:43 ` [PATCH 17/19] OpenRISC: Library routines Jonas Bonn 2011-06-19 11:43 ` [PATCH 18/19] OpenRISC: Miscellaneous Jonas Bonn 2011-06-19 11:43 ` [PATCH 19/19] OpenRISC: Add MAINTAINERS entry Jonas Bonn 2011-06-19 17:06 ` OpenRISC Architecture: Request for review Arnd Bergmann 2011-06-22 21:23 ` H. Peter Anvin 2011-06-23 9:10 ` Jonas Bonn 2011-06-23 9:54 ` Julius Baxter
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=201106191919.27737.arnd@arndb.de \ --to=arnd@arndb.de \ --cc=devicetree-discuss@lists.ozlabs.org \ --cc=jonas@southpole.se \ --cc=linux-kernel@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.