Re: [RFC][PATCH v2 3/7] NFC: add nfc generic netlink interface

From: "Gustavo F. Padovan" <padovan@profusion.mobi>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Aloisio Almeida Jr <aloisio.almeida@openbossa.org>,
	linville@tuxdriver.com, linux-wireless@vger.kernel.org,
	sameo@linux.intel.com, lauro.venancio@openbossa.org,
	marcio.macedo@openbossa.org, Waldemar.Rymarkiewicz@tieto.com
Subject: Re: [RFC][PATCH v2 3/7] NFC: add nfc generic netlink interface
Date: Wed, 22 Jun 2011 16:55:48 -0300	[thread overview]
Message-ID: <20110622195548.GB2583@joana> (raw)
In-Reply-To: <1308725771.3883.0.camel@jlt3.sipsolutions.net>

Hi Johannes,

* Johannes Berg <johannes@sipsolutions.net> [2011-06-22 08:56:11 +0200]:

> On Tue, 2011-06-21 at 19:05 -0300, Gustavo F. Padovan wrote:
> 
> > >  static int __init nfc_init(void)
> > >  {
> > > +	int rc;
> > > +
> > >  	printk(KERN_INFO "NFC Core ver %s\n", VERSION);
> > >  
> > > -	return class_register(&nfc_class);
> > > +	rc = class_register(&nfc_class);
> > > +	if (rc)
> > > +		goto err;
> > 
> > Just return rc here and get rid of the label.
> 
> 
> Seriously, please trim your quotes. If you're commenting on a specific
> piece of code, you can well remove all the code you're not commenting on
> like I did above.

Sorry, I didn't realize that it was so big. Also I usually forget to trim the
beginning of the patch. Have to get used to that.

	Gustavo