Re: [RFC][PATCH v2 3/7] NFC: add nfc generic netlink interface

From: Aloisio Almeida <aloisio.almeida@openbossa.org>
To: Aloisio Almeida Jr <aloisio.almeida@openbossa.org>,
	linville@tuxdriver.com, linux-wireless@vger.kernel.org,
	sameo@linux.intel.com, johannes@sipsolutions.net,
	lauro.venancio@openbossa.org, marcio.macedo@openbossa.org,
	Waldemar.Rymarkiewicz@tieto.com
Subject: Re: [RFC][PATCH v2 3/7] NFC: add nfc generic netlink interface
Date: Wed, 22 Jun 2011 11:07:20 -0300	[thread overview]
Message-ID: <BANLkTimo9r8jyMn76V9+9+AqrYekRkF8Xw@mail.gmail.com> (raw)
In-Reply-To: <20110621220510.GG2628@joana>

Hi Gustavo,

On Tue, Jun 21, 2011 at 7:05 PM, Gustavo F. Padovan
<padovan@profusion.mobi> wrote:
>>  static int __init nfc_init(void)
>>  {
>> +     int rc;
>> +
>>       printk(KERN_INFO "NFC Core ver %s\n", VERSION);
>>
>> -     return class_register(&nfc_class);
>> +     rc = class_register(&nfc_class);
>> +     if (rc)
>> +             goto err;
>
> Just return rc here and get rid of the label.
>
ok

>> +/**
>> + * nfc_genl_exit() - Deinitialize netlink interface
>> + *
>> + * This exit function unregisters the nfc netlink family.
>> + */
>> +void nfc_genl_exit(void)
>
> You may want __exit here.

The nfc_genl_exit() is called in  '__init nfc_init(void)' if any error
occurs. In that case we will have an __exit code inside an __init
code, resulting in a section mismatch.

Aloisio