From: Amit Shah <amit.shah@redhat.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: alevy@redhat.com, qemu-devel@nongnu.org, kraxel@redhat.com
Subject: Re: [Qemu-devel] [PATCH 0/4] A few cleanups of qdev users
Date: Tue, 28 Jun 2011 16:56:46 +0530 [thread overview]
Message-ID: <20110628112646.GB25491@amit-x200.redhat.com> (raw)
In-Reply-To: <m3mxh3jvt0.fsf@blackfin.pond.sub.org>
On (Mon) 27 Jun 2011 [14:36:11], Markus Armbruster wrote:
> Amit Shah <amit.shah@redhat.com> writes:
>
> > On (Fri) 24 Jun 2011 [13:57:28], Markus Armbruster wrote:
> >> Ping?
> >
> > There were a couple of things:
> >
> >> port 0, guest on, host off, throttle off
> >
> > guest on/off, host on/off doesn't convey much -- what's on/off?
> >
> > Also, 'throttle' could be 'thottled'?
>
> Discussion petered out with my message[*]:
>
> I chose on/off to stay consistent with how qdev shows bool
> properties (print_bit() in qdev-properties.c). May be misguided.
> Like you, I'm having difficulties coming up with a better version
> that is still consise.
>
> But: should "info qtree" show such device state? It's about
> configuration of the device tree, isn't it? Connection status is
> useful to know, but it's not device configuration. Other
> print_dev() methods may cross that line, too. For instance,
> usb_bus_dev_print() prints attached, which looks suspicious (commit
> 66a6593a).
>
> Should info qtree continue to show this information? If yes, care to
> suggest a better format?
Don't know. I'm fine with anything the qdev guys decide. I agree
this isn't device state.
Amit
next prev parent reply other threads:[~2011-06-28 11:26 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-19 11:37 [Qemu-devel] [PATCH 0/4] A few cleanups of qdev users Markus Armbruster
2011-05-19 11:37 ` [Qemu-devel] [PATCH 1/4] usb-ccid: Drop unused CCIDCardInfo callback print() Markus Armbruster
2011-05-19 11:49 ` Alon Levy
2011-05-19 11:37 ` [Qemu-devel] [PATCH 2/4] virtio-serial: Clean up virtser_bus_dev_print() output Markus Armbruster
2011-05-19 13:10 ` Amit Shah
2011-05-19 14:18 ` Markus Armbruster
2011-05-19 14:24 ` Amit Shah
2011-06-27 19:32 ` Andreas Färber
2011-06-29 8:33 ` Gerd Hoffmann
2011-06-29 9:26 ` Markus Armbruster
2011-06-29 18:33 ` Andreas Färber
2011-06-29 9:22 ` Markus Armbruster
2011-05-19 11:37 ` [Qemu-devel] [PATCH 3/4] virtio-serial: Turn props any virtio-serial-bus device must have into bus props Markus Armbruster
2011-05-19 13:11 ` Amit Shah
2011-05-19 14:05 ` Markus Armbruster
2011-05-19 14:08 ` Amit Shah
2011-05-19 11:37 ` [Qemu-devel] [PATCH 4/4] ide: Turn properties any IDE device must have into bus properties Markus Armbruster
2011-05-19 12:11 ` [Qemu-devel] [PATCH 0/4] A few cleanups of qdev users Gerd Hoffmann
2011-06-24 11:57 ` Markus Armbruster
2011-06-27 9:54 ` Amit Shah
2011-06-27 12:36 ` Markus Armbruster
2011-06-28 11:26 ` Amit Shah [this message]
2011-06-28 12:24 ` Markus Armbruster
2011-06-28 12:34 ` Amit Shah
2011-07-23 16:54 ` Anthony Liguori
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20110628112646.GB25491@amit-x200.redhat.com \
--to=amit.shah@redhat.com \
--cc=alevy@redhat.com \
--cc=armbru@redhat.com \
--cc=kraxel@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.