Re: [Qemu-devel] [PATCH 3/4] virtio-serial: Turn props any virtio-serial-bus device must have into bus props

[Markus Armbruster <armbru@redhat.com>]

Amit Shah <amit.shah@redhat.com> writes:

> On (Thu) 19 May 2011 [13:37:16], Markus Armbruster wrote:
>> diff --git a/hw/virtio-serial-bus.c b/hw/virtio-serial-bus.c
>> index bd3121e..a7d6b2b 100644
>> --- a/hw/virtio-serial-bus.c
>> +++ b/hw/virtio-serial-bus.c
>> @@ -642,6 +642,11 @@ static struct BusInfo virtser_bus_info = {
>>      .name      = "virtio-serial-bus",
>>      .size      = sizeof(VirtIOSerialBus),
>>      .print_dev = virtser_bus_dev_print,
>> +    .props      = (Property[]) {
>> +        DEFINE_PROP_UINT32("nr", VirtIOSerialPort, id, VIRTIO_CONSOLE_BAD_ID),
>> +        DEFINE_PROP_STRING("name", VirtIOSerialPort, name),
>> +        DEFINE_PROP_END_OF_LIST()
>> +    }
>
> 'name' isn't a must-have for all devices, but this is change OK.

The property is a must have, even though its value may remain null.
Correct?