* [PATCH] Don't try to chgrp write or wall if they are not built
@ 2011-06-30 0:26 Marc-Antoine Perennou
2011-06-30 8:53 ` Olaf Hering
2011-07-11 9:54 ` Karel Zak
0 siblings, 2 replies; 5+ messages in thread
From: Marc-Antoine Perennou @ 2011-06-30 0:26 UTC (permalink / raw)
To: util-linux
Fix regression from commit 4aa9d65bfa76afd0d886ca410ae83428a490d4ea
Signed-off-by: Marc-Antoine Perennou <Marc-Antoine@Perennou.com>
---
term-utils/Makefile.am | 10 ++++++++--
1 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/term-utils/Makefile.am b/term-utils/Makefile.am
index 5e03560..d5ba479 100644
--- a/term-utils/Makefile.am
+++ b/term-utils/Makefile.am
@@ -67,8 +67,14 @@ endif
if USE_TTY_GROUP
if MAKEINSTALL_DO_CHOWN
install-exec-hook::
- chgrp tty $(DESTDIR)$(usrbin_execdir)/wall
$(DESTDIR)$(usrbin_execdir)/write
- chmod g+s $(DESTDIR)$(usrbin_execdir)/wall
$(DESTDIR)$(usrbin_execdir)/write
+if BUILD_WALL
+ chgrp tty $(DESTDIR)$(usrbin_execdir)/wall
+ chmod g+s $(DESTDIR)$(usrbin_execdir)/wall
+endif
+if BUILD_WRITE
+ chgrp tty $(DESTDIR)$(usrbin_execdir)/write
+ chmod g+s $(DESTDIR)$(usrbin_execdir)/write
+endif
endif
endif
--
1.7.6
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] Don't try to chgrp write or wall if they are not built
2011-06-30 0:26 [PATCH] Don't try to chgrp write or wall if they are not built Marc-Antoine Perennou
@ 2011-06-30 8:53 ` Olaf Hering
2011-06-30 10:33 ` Karel Zak
2011-07-11 9:54 ` Karel Zak
1 sibling, 1 reply; 5+ messages in thread
From: Olaf Hering @ 2011-06-30 8:53 UTC (permalink / raw)
To: Marc-Antoine Perennou; +Cc: util-linux
On Thu, Jun 30, Marc-Antoine Perennou wrote:
> Fix regression from commit 4aa9d65bfa76afd0d886ca410ae83428a490d4ea
>
> Signed-off-by: Marc-Antoine Perennou <Marc-Antoine@Perennou.com>
> ---
> term-utils/Makefile.am | 10 ++++++++--
> - chgrp tty $(DESTDIR)$(usrbin_execdir)/wall
> $(DESTDIR)$(usrbin_execdir)/write
> - chmod g+s $(DESTDIR)$(usrbin_execdir)/wall
> $(DESTDIR)$(usrbin_execdir)/write
> +if BUILD_WALL
> + chgrp tty $(DESTDIR)$(usrbin_execdir)/wall
This is wrong and should part of the packaging system, not part of make
install. The userid building util-linux is not neccessary part of the
tty group.
Olaf
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Don't try to chgrp write or wall if they are not built
2011-06-30 8:53 ` Olaf Hering
@ 2011-06-30 10:33 ` Karel Zak
2011-06-30 11:00 ` Olaf Hering
0 siblings, 1 reply; 5+ messages in thread
From: Karel Zak @ 2011-06-30 10:33 UTC (permalink / raw)
To: Olaf Hering; +Cc: Marc-Antoine Perennou, util-linux
On Thu, Jun 30, 2011 at 10:53:27AM +0200, Olaf Hering wrote:
> On Thu, Jun 30, Marc-Antoine Perennou wrote:
>
> > Fix regression from commit 4aa9d65bfa76afd0d886ca410ae83428a490d4ea
> >
> > Signed-off-by: Marc-Antoine Perennou <Marc-Antoine@Perennou.com>
> > ---
> > term-utils/Makefile.am | 10 ++++++++--
>
> > - chgrp tty $(DESTDIR)$(usrbin_execdir)/wall
> > $(DESTDIR)$(usrbin_execdir)/write
> > - chmod g+s $(DESTDIR)$(usrbin_execdir)/wall
> > $(DESTDIR)$(usrbin_execdir)/write
> > +if BUILD_WALL
> > + chgrp tty $(DESTDIR)$(usrbin_execdir)/wall
>
> This is wrong and should part of the packaging system, not part of make
> install. The userid building util-linux is not neccessary part of the
> tty group.
Why do you expect that everyone uses any packaging system? The "make
install" result should be usable. Note that this all is controlled by
--disable-makeinstall-chown and --disable-makeinstall-setuid options.
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH] Don't try to chgrp write or wall if they are not built
2011-06-30 10:33 ` Karel Zak
@ 2011-06-30 11:00 ` Olaf Hering
0 siblings, 0 replies; 5+ messages in thread
From: Olaf Hering @ 2011-06-30 11:00 UTC (permalink / raw)
To: Karel Zak; +Cc: Marc-Antoine Perennou, util-linux
On Thu, Jun 30, Karel Zak wrote:
> Why do you expect that everyone uses any packaging system? The "make
> install" result should be usable. Note that this all is controlled by
> --disable-makeinstall-chown and --disable-makeinstall-setuid options.
Karel,
after I sent the mail I noticed the if MAKEINSTALL_DO_CHOWN,
so all should be fine.
Olaf
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] Don't try to chgrp write or wall if they are not built
2011-06-30 0:26 [PATCH] Don't try to chgrp write or wall if they are not built Marc-Antoine Perennou
2011-06-30 8:53 ` Olaf Hering
@ 2011-07-11 9:54 ` Karel Zak
1 sibling, 0 replies; 5+ messages in thread
From: Karel Zak @ 2011-07-11 9:54 UTC (permalink / raw)
To: Marc-Antoine Perennou; +Cc: util-linux
On Thu, Jun 30, 2011 at 02:26:32AM +0200, Marc-Antoine Perennou wrote:
> term-utils/Makefile.am | 10 ++++++++--
> 1 files changed, 8 insertions(+), 2 deletions(-)
Applied, thanks.
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-07-11 9:54 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-06-30 0:26 [PATCH] Don't try to chgrp write or wall if they are not built Marc-Antoine Perennou
2011-06-30 8:53 ` Olaf Hering
2011-06-30 10:33 ` Karel Zak
2011-06-30 11:00 ` Olaf Hering
2011-07-11 9:54 ` Karel Zak
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.