From: Sascha Hauer <s.hauer@pengutronix.de> To: Arnd Bergmann <arnd@arndb.de> Cc: Shawn Guo <shawn.guo@linaro.org>, Ryan Mallon <ryan@bluewatersys.com>, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 3/3] pwm: Add a i.MX23/28 pwm driver Date: Thu, 30 Jun 2011 17:11:38 +0200 [thread overview] Message-ID: <20110630151138.GB9349@pengutronix.de> (raw) In-Reply-To: <201106301342.36088.arnd@arndb.de> On Thu, Jun 30, 2011 at 01:42:35PM +0200, Arnd Bergmann wrote: > On Thursday 30 June 2011, Sascha Hauer wrote: > > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> > > Hi Sascha, > > The probing looks good to me now. I would have added extra code to avoid > ioremapping the same page multiple times, but I see this as a matter of > different preferences, so I'm fine with that. > > You are still missing a description of the driver, both in the changelog > above and in the Kconfig patch. A small sentence to spell out PWM > in the changelog and to list the devices that will use this driver > would be helpful to the causal reader. Ok, will add. > > Provided that you add that: > > Reviewed-by: Arnd Bergmann <arnd@arndb.de> > > > diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig > > index 93c1052..5694574 100644 > > --- a/drivers/pwm/Kconfig > > +++ b/drivers/pwm/Kconfig > > @@ -2,11 +2,15 @@ menuconfig PWM > > bool "PWM Support" > > help > > This enables PWM support through the generic PWM framework. > > - You only need to enable this, if you also want to enable > > + You only need to enable this if you also want to enable > > one or more of the PWM drivers below. > > > > If unsure, say N. > > > > I think this hunk should have been in the other first patch. Indeed, will fix. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
WARNING: multiple messages have this Message-ID (diff)
From: s.hauer@pengutronix.de (Sascha Hauer) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH 3/3] pwm: Add a i.MX23/28 pwm driver Date: Thu, 30 Jun 2011 17:11:38 +0200 [thread overview] Message-ID: <20110630151138.GB9349@pengutronix.de> (raw) In-Reply-To: <201106301342.36088.arnd@arndb.de> On Thu, Jun 30, 2011 at 01:42:35PM +0200, Arnd Bergmann wrote: > On Thursday 30 June 2011, Sascha Hauer wrote: > > Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de> > > Hi Sascha, > > The probing looks good to me now. I would have added extra code to avoid > ioremapping the same page multiple times, but I see this as a matter of > different preferences, so I'm fine with that. > > You are still missing a description of the driver, both in the changelog > above and in the Kconfig patch. A small sentence to spell out PWM > in the changelog and to list the devices that will use this driver > would be helpful to the causal reader. Ok, will add. > > Provided that you add that: > > Reviewed-by: Arnd Bergmann <arnd@arndb.de> > > > diff --git a/drivers/pwm/Kconfig b/drivers/pwm/Kconfig > > index 93c1052..5694574 100644 > > --- a/drivers/pwm/Kconfig > > +++ b/drivers/pwm/Kconfig > > @@ -2,11 +2,15 @@ menuconfig PWM > > bool "PWM Support" > > help > > This enables PWM support through the generic PWM framework. > > - You only need to enable this, if you also want to enable > > + You only need to enable this if you also want to enable > > one or more of the PWM drivers below. > > > > If unsure, say N. > > > > I think this hunk should have been in the other first patch. Indeed, will fix. Sascha -- Pengutronix e.K. | | Industrial Linux Solutions | http://www.pengutronix.de/ | Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
next prev parent reply other threads:[~2011-06-30 15:11 UTC|newest] Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-06-30 10:41 [PATCH v3] implement a generic PWM framework Sascha Hauer 2011-06-30 10:41 ` Sascha Hauer 2011-06-30 10:41 ` [PATCH 1/3] PWM: add pwm framework support Sascha Hauer 2011-06-30 10:41 ` Sascha Hauer 2011-06-30 11:07 ` Bill Gatliff 2011-06-30 11:07 ` Bill Gatliff 2011-06-30 12:41 ` Arnd Bergmann 2011-06-30 12:41 ` Arnd Bergmann 2011-06-30 16:17 ` Bill Gatliff 2011-06-30 16:17 ` Bill Gatliff 2011-06-30 17:02 ` Sascha Hauer 2011-06-30 17:02 ` Sascha Hauer 2011-06-30 19:45 ` Bill Gatliff 2011-06-30 19:45 ` Bill Gatliff 2011-06-30 23:24 ` Ryan Mallon 2011-06-30 23:24 ` Ryan Mallon 2011-07-01 0:33 ` H Hartley Sweeten 2011-07-01 0:33 ` H Hartley Sweeten 2011-07-01 0:55 ` Mike Frysinger 2011-07-01 0:55 ` Mike Frysinger 2011-07-01 7:37 ` Sascha Hauer 2011-07-01 7:37 ` Sascha Hauer 2011-07-01 8:28 ` Ryan Mallon 2011-07-01 8:28 ` Ryan Mallon 2011-07-01 8:54 ` Sascha Hauer 2011-07-01 8:54 ` Sascha Hauer 2011-07-02 0:40 ` Ryan Mallon 2011-07-02 0:40 ` Ryan Mallon 2011-07-04 7:55 ` Sascha Hauer 2011-07-04 7:55 ` Sascha Hauer 2011-07-04 8:50 ` Dmitry Eremin-Solenikov 2011-07-04 10:43 ` Ryan Mallon 2011-07-04 10:43 ` Ryan Mallon 2011-07-04 11:05 ` Kurt Van Dijck 2011-07-04 13:53 ` Arnd Bergmann 2011-07-04 13:53 ` Arnd Bergmann 2011-07-04 14:19 ` Kurt Van Dijck 2011-07-04 12:43 ` Sascha Hauer 2011-07-04 12:43 ` Sascha Hauer 2011-07-04 14:07 ` Arnd Bergmann 2011-07-04 14:07 ` Arnd Bergmann 2011-12-07 8:53 ` Thierry Reding 2011-12-07 8:53 ` Thierry Reding 2011-12-07 9:07 ` Sascha Hauer 2011-12-07 9:07 ` Sascha Hauer 2011-12-14 10:03 ` Thierry Reding 2011-12-14 10:03 ` Thierry Reding 2011-12-14 11:37 ` Sascha Hauer 2011-12-14 11:37 ` Sascha Hauer 2011-07-01 9:49 ` Dmitry Eremin-Solenikov 2011-06-30 10:41 ` [PATCH 2/3] ARM mxs: adjust pwm resources to what the driver expects Sascha Hauer 2011-06-30 10:41 ` Sascha Hauer 2011-06-30 11:30 ` Arnd Bergmann 2011-06-30 11:30 ` Arnd Bergmann 2011-06-30 10:41 ` [PATCH 3/3] pwm: Add a i.MX23/28 pwm driver Sascha Hauer 2011-06-30 10:41 ` Sascha Hauer 2011-06-30 11:42 ` Arnd Bergmann 2011-06-30 11:42 ` Arnd Bergmann 2011-06-30 15:11 ` Sascha Hauer [this message] 2011-06-30 15:11 ` Sascha Hauer
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20110630151138.GB9349@pengutronix.de \ --to=s.hauer@pengutronix.de \ --cc=arnd@arndb.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-kernel@vger.kernel.org \ --cc=ryan@bluewatersys.com \ --cc=shawn.guo@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.