* [PATCH net-next] net: de4x5: Use helpers from linux/etherdevice.h
@ 2011-07-04 9:48 Tobias Klauser
2011-07-05 3:31 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Tobias Klauser @ 2011-07-04 9:48 UTC (permalink / raw)
To: David S. Miller, Grant Grundler; +Cc: netdev
Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
---
drivers/net/tulip/de4x5.c | 7 +++----
1 files changed, 3 insertions(+), 4 deletions(-)
diff --git a/drivers/net/tulip/de4x5.c b/drivers/net/tulip/de4x5.c
index d8db2b6..959b410 100644
--- a/drivers/net/tulip/de4x5.c
+++ b/drivers/net/tulip/de4x5.c
@@ -1868,14 +1868,13 @@ de4x5_local_stats(struct net_device *dev, char *buf, int pkt_len)
i = DE4X5_PKT_STAT_SZ;
}
}
- if (buf[0] & 0x01) { /* Multicast/Broadcast */
- if ((*(s32 *)&buf[0] == -1) && (*(s16 *)&buf[4] == -1)) {
+ if (is_multicast_ether_addr(buf)) {
+ if (is_broadcast_ether_addr(buf)) {
lp->pktStats.broadcast++;
} else {
lp->pktStats.multicast++;
}
- } else if ((*(s32 *)&buf[0] == *(s32 *)&dev->dev_addr[0]) &&
- (*(s16 *)&buf[4] == *(s16 *)&dev->dev_addr[4])) {
+ } else if (compare_ether_addr(buf, dev->dev_addr) == 0) {
lp->pktStats.unicast++;
}
--
1.7.5.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] net: de4x5: Use helpers from linux/etherdevice.h
2011-07-04 9:48 [PATCH net-next] net: de4x5: Use helpers from linux/etherdevice.h Tobias Klauser
@ 2011-07-05 3:31 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2011-07-05 3:31 UTC (permalink / raw)
To: tklauser; +Cc: grundler, netdev
From: Tobias Klauser <tklauser@distanz.ch>
Date: Mon, 4 Jul 2011 11:48:13 +0200
> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-07-05 3:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-07-04 9:48 [PATCH net-next] net: de4x5: Use helpers from linux/etherdevice.h Tobias Klauser
2011-07-05 3:31 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.