Fwd: usbnet suspend issue

Fwd: usbnet suspend issue

[Chris Fries]

[-- Attachment #1: Type: text/plain, Size: 801 bytes --]

(Plain text)

Hi David, Netdev, Stable,

Please evaluate the attached usbnet patch for inclusion to the kernel.

Thanks,
Chris



On Tue, Jul 5, 2011 at 4:49 AM, Oliver Neukum <oliver@neukum.org> wrote:
>
> Am Dienstag, 5. Juli 2011, 04:25:39 schrieb Chris Fries:
> > Hi Oliver,
> >
> > I noticed a bug in usbnet suspend, that's been around for a while and seems
> > to be still present in 3.0.  It causes some nasty behavior on ARM (Tegra)
> > when suspend/resume stops working due to a lost suspend count.
> > ...
>
> Thank you. That is a very good catch. Please resend to David Miller
> and netdev@vger.kernel.org and stable@kernel.org. Also please include
> your Signed-off-by: <mail> line. That way it'll be included fastest.
>
>        Regards
>                Oliver

[-- Attachment #2: usbnet-suspend.patch --]
[-- Type: application/octet-stream, Size: 1041 bytes --]

From 963360b955bae58963399124b4a542827f3272ea Mon Sep 17 00:00:00 2001
From: Chris Fries <C.Fries@motorola.com>
Date: Fri, 1 Jul 2011 15:28:58 -0500
Subject: [PATCH] usb: usbnet: suspend count gets lost when -EBUSY

When suspend is refused due to pending transmits, the
busy counter gets out of sync, and suspend will stop
working correctly.

Change-Id: I89d31d6584e8914192315671c8031a9c7658ca22
Signed-off-by: Chris Fries <C.Fries@motorola.com>
---
 drivers/net/usb/usbnet.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/net/usb/usbnet.c b/drivers/net/usb/usbnet.c
index cc95aad..9bcc3e3 100644
--- a/drivers/net/usb/usbnet.c
+++ b/drivers/net/usb/usbnet.c
@@ -1451,6 +1451,7 @@ int usbnet_suspend (struct usb_interface *intf, pm_message_t message)
 		/* don't autosuspend while transmitting */
 		if (dev->txq.qlen && (message.event & PM_EVENT_AUTO)) {
 			spin_unlock_irq(&dev->txq.lock);
+			dev->suspend_count--;
 			return -EBUSY;
 		} else {
 			set_bit(EVENT_DEV_ASLEEP, &dev->flags);
-- 
1.7.0.4

Re: usbnet suspend issue

[David Miller]

Patch submitted as binary attachment instead of plain text inline that
we can read and evaluate directly in our mail clients.

Also, if you submit this as a binary attachment, automated patch
management tools, such as patchwork, we use cannot track the patch.

Sorry, this is not the proper way to submit a patch.

Also get rid of the "Change-Id:" in your commit message, it has
no meaning.