All of lore.kernel.org
 help / color / mirror / Atom feed
From: Johan Hedberg <johan.hedberg@gmail.com>
To: Bartosz Szatkowski <bulislaw@linux.com>
Cc: Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
	linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH BlueZ] Add SetRemoteProperty method for OOB mechanism
Date: Tue, 5 Jul 2011 12:58:30 +0300	[thread overview]
Message-ID: <20110705095830.GA10079@dell.ger.corp.intel.com> (raw)
In-Reply-To: <CAPGrrxVT-xugggk_CcNn_Zd+ZSJjuVPrMn64XVnNoUqK2sm60Q@mail.gmail.com>

Hi,

> > I don't think this is the right approach for OOB data because this
> > information may become private to bluetoothd if the device is not
> > created since it is not associated with any device object/path, IMO
> > the OOB data needs to be passed in the CreateDevice which should take
> > a dictionary containing all the known information of the device, but
> > that breaks the API otherwise I would already send a patch proposing
> > this.
> 
> Right, i'v discussed this approach with Johan and Szymon on freenode
> -- i'v changed few things after that (mostly because implementing it
> in AddRemoteData would break api, so i moved it to separate method) --
> maybe it would be a good idea to have this functionality now in this
> form and change it when the api break would be possible (5.0?)?

To me, the closest analogy of receiving data like this over some OOB
channel is an inquiry result HCI event. Therefore, it'd be intuitive to
have this behave in a similar way: the data goes to storage and triggers
a DeviceFound event. Calling Create(Paired)Device remains separate from
all this.

This doesn't of course mean that we couldn't/shouldn't restructure the
device discovery process for 5.x to e.g. have D-Bus objects for every
found device and a Device.Pair() method, but the device information
received over an OOB channel should still map to a similar set of steps
as what happens when receiving a HCI inquiry result event.

Johan

  parent reply	other threads:[~2011-07-05  9:58 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-04 14:49 [PATCH BlueZ] Add SetRemoteProperty method for OOB mechanism Bartosz Szatkowski
2011-07-05  8:42 ` Luiz Augusto von Dentz
2011-07-05  8:55   ` Bartosz Szatkowski
2011-07-05  9:51     ` Luiz Augusto von Dentz
2011-07-05  9:59       ` Bartosz Szatkowski
2011-07-06  8:03         ` Bartosz Szatkowski
2011-07-26  8:11           ` Johan Hedberg
2011-07-26  8:17             ` Bartosz Szatkowski
2011-07-05  9:58     ` Johan Hedberg [this message]
2011-07-28 13:55 Bartosz Szatkowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110705095830.GA10079@dell.ger.corp.intel.com \
    --to=johan.hedberg@gmail.com \
    --cc=bulislaw@linux.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=luiz.dentz@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.