All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bartosz Szatkowski <bulislaw@linux.com>
To: Luiz Augusto von Dentz <luiz.dentz@gmail.com>
Cc: linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH BlueZ] Add SetRemoteProperty method for OOB mechanism
Date: Tue, 5 Jul 2011 11:59:49 +0200	[thread overview]
Message-ID: <CAPGrrxV_hpVhsp2pkkSgy+oSgeRNSxz3WP4hk8AzjjjZZH+j6g@mail.gmail.com> (raw)
In-Reply-To: <CABBYNZJHkqk5dQZrYzNiVTs4Fdx8WUk70CfAzLbVHhUHWuos+Q@mail.gmail.com>

On Tue, Jul 5, 2011 at 11:51 AM, Luiz Augusto von Dentz
<luiz.dentz@gmail.com> wrote:
> Hi Bartosz,
>
> On Tue, Jul 5, 2011 at 11:55 AM, Bartosz Szatkowski <bulislaw@linux.com> wrote:
>>
>> Right, i'v discussed this approach with Johan and Szymon on freenode
>> -- i'v changed few things after that (mostly because implementing it
>> in AddRemoteData would break api, so i moved it to separate method) --
>> maybe it would be a good idea to have this functionality now in this
>> form and change it when the api break would be possible (5.0?)?
>>
>
> Apparently the idea is to use this interface is to emulate a
> DeviceFound result, which I guess would make sense if the user pairs
> using the bt application/agent, but in the other hand this can be
> misused by application and they actually start overwriting device
> properties e.g. restore tool. So the question is how much do we trust
> application to provide this information without properly creating a
> device? To me it sounds that we either need the agent to actually
> accept this information as valid, which btw normally requires an
> object path to identify the device to query its properties, or we do
> it all together as I suggested in CreateDevice so we validate the
> information by pairing/connecting to the device.
>
> Btw, there is also the problem that D-Bus round trips are expensive
> and with such API one have to set one by one the properties to finally
> do a CreateDevice in the end, so at least the current design should
> make sure that an application can set all its known properties in one
> call e.g. SetRemoteProperties(string address, dict properties).
>
> --
> Luiz Augusto von Dentz
>

Yeah it sound good, but are we sure that there is need for setting
other parameters via OOB? The idea that was cleared on irc wast to add
CoD parameter to OOB.AddRemoteData(address, hash, randomizer, CoD)

-- 
Pozdrowienia,
Bartosz Szatkowski

  reply	other threads:[~2011-07-05  9:59 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-04 14:49 [PATCH BlueZ] Add SetRemoteProperty method for OOB mechanism Bartosz Szatkowski
2011-07-05  8:42 ` Luiz Augusto von Dentz
2011-07-05  8:55   ` Bartosz Szatkowski
2011-07-05  9:51     ` Luiz Augusto von Dentz
2011-07-05  9:59       ` Bartosz Szatkowski [this message]
2011-07-06  8:03         ` Bartosz Szatkowski
2011-07-26  8:11           ` Johan Hedberg
2011-07-26  8:17             ` Bartosz Szatkowski
2011-07-05  9:58     ` Johan Hedberg
2011-07-28 13:55 Bartosz Szatkowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAPGrrxV_hpVhsp2pkkSgy+oSgeRNSxz3WP4hk8AzjjjZZH+j6g@mail.gmail.com \
    --to=bulislaw@linux.com \
    --cc=linux-bluetooth@vger.kernel.org \
    --cc=luiz.dentz@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.