From: Arnd Bergmann <arnd@arndb.de>
To: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
Cc: "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>,
"w.sang@pengutronix.de" <w.sang@pengutronix.de>,
"thierry.nolf.barco@gmail.com" <thierry.nolf.barco@gmail.com>,
Huang Shijie <b32955@freescale.com>,
"linux-mtd@lists.infradead.org" <linux-mtd@lists.infradead.org>,
linux-arm-kernel@lists.infradead.org,
"LW@karo-electronics.de" <LW@karo-electronics.de>
Subject: Re: reply: [PATCH v5 1/3] ARM: mxs: add GPMI-NFC support for?imx23/imx28
Date: Thu, 7 Jul 2011 23:04:05 +0200 [thread overview]
Message-ID: <201107072304.05626.arnd@arndb.de> (raw)
In-Reply-To: <20110707204833.GL29624@pengutronix.de>
On Thursday 07 July 2011 22:48:33 Uwe Kleine-König wrote:
> My thoughts on this is that it should better go to where struct resource
> is defined (<linux/ioports.h>, as Arndt suggested) but then probably a
> bit more generic as:
>
> #define RES_MEM_NAMED(_start, _end, _name) \
> { \
> .start = _start, \
> .end = _end, \
> .name = _name, \
> .flags = IORESOURCE_MEM, \
> }
> #define RES_MEM(_start, _end) \
> RES_MEM_NAMED(_start, _end, NULL)
>
> (Maybe alternatively take a _size parameter instead of _end?)
> While this makes the repetition shorter, it's still there.
>
This sounds reasonable, and I'd also prefer the size instead of end
argument here. If you prepare a patch to do this, I can ack it for you.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: reply: [PATCH v5 1/3] ARM: mxs: add GPMI-NFC support for?imx23/imx28
Date: Thu, 7 Jul 2011 23:04:05 +0200 [thread overview]
Message-ID: <201107072304.05626.arnd@arndb.de> (raw)
In-Reply-To: <20110707204833.GL29624@pengutronix.de>
On Thursday 07 July 2011 22:48:33 Uwe Kleine-K?nig wrote:
> My thoughts on this is that it should better go to where struct resource
> is defined (<linux/ioports.h>, as Arndt suggested) but then probably a
> bit more generic as:
>
> #define RES_MEM_NAMED(_start, _end, _name) \
> { \
> .start = _start, \
> .end = _end, \
> .name = _name, \
> .flags = IORESOURCE_MEM, \
> }
> #define RES_MEM(_start, _end) \
> RES_MEM_NAMED(_start, _end, NULL)
>
> (Maybe alternatively take a _size parameter instead of _end?)
> While this makes the repetition shorter, it's still there.
>
This sounds reasonable, and I'd also prefer the size instead of end
argument here. If you prepare a patch to do this, I can ack it for you.
Arnd
next prev parent reply other threads:[~2011-07-07 21:04 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-30 16:12 reply: [PATCH v5 1/3] ARM: mxs: add GPMI-NFC support for imx23/imx28 Huang Shijie-B32955
2011-06-30 16:12 ` Huang Shijie-B32955
2011-06-30 22:29 ` Arnd Bergmann
2011-06-30 22:29 ` Arnd Bergmann
2011-07-01 6:44 ` Uwe Kleine-König
2011-07-01 6:44 ` Uwe Kleine-König
2011-07-01 8:57 ` Huang Shijie
2011-07-01 8:57 ` Huang Shijie
2011-07-01 9:09 ` Arnd Bergmann
2011-07-01 9:09 ` Arnd Bergmann
2011-07-07 8:56 ` Huang Shijie
2011-07-07 8:56 ` Huang Shijie
2011-07-07 15:57 ` Arnd Bergmann
2011-07-07 15:57 ` Arnd Bergmann
2011-07-07 20:48 ` reply: [PATCH v5 1/3] ARM: mxs: add GPMI-NFC support for?imx23/imx28 Uwe Kleine-König
2011-07-07 20:48 ` Uwe Kleine-König
2011-07-07 21:04 ` Arnd Bergmann [this message]
2011-07-07 21:04 ` Arnd Bergmann
2011-07-11 14:40 ` [PATCH] new helper to define common struct resource constructs Uwe Kleine-König
2011-07-11 14:40 ` Uwe Kleine-König
2011-07-11 15:03 ` [PATCH] ARM: mxc: use new helpers to define common struct resource entries Uwe Kleine-König
2011-07-11 15:03 ` Uwe Kleine-König
2011-07-12 13:29 ` [PATCH] new helper to define common struct resource constructs Arnd Bergmann
2011-07-12 13:29 ` Arnd Bergmann
2011-07-12 13:29 ` Arnd Bergmann
2011-07-12 17:13 ` H Hartley Sweeten
2011-07-12 17:13 ` H Hartley Sweeten
2011-07-12 18:31 ` [PATCH v2] " Uwe Kleine-König
2011-07-12 18:31 ` Uwe Kleine-König
2011-07-12 18:31 ` Uwe Kleine-König
2011-07-13 21:18 ` [PATCH] " Andrew Morton
2011-07-13 21:18 ` Andrew Morton
2011-07-13 21:18 ` Andrew Morton
2011-07-13 21:42 ` Arnd Bergmann
2011-07-13 21:42 ` Arnd Bergmann
2011-07-13 21:42 ` Arnd Bergmann
2011-07-13 22:15 ` H Hartley Sweeten
2011-07-13 22:15 ` H Hartley Sweeten
2011-07-13 22:15 ` H Hartley Sweeten
2011-07-14 8:11 ` [PATCH v3] " Uwe Kleine-König
2011-07-14 8:11 ` Uwe Kleine-König
2011-07-14 8:11 ` Uwe Kleine-König
2011-07-14 11:34 ` Lothar Waßmann
2011-07-14 11:34 ` Lothar Waßmann
2011-07-14 11:34 ` Lothar Waßmann
2011-07-01 14:52 ` reply: [PATCH v5 1/3] ARM: mxs: add GPMI-NFC support for imx23/imx28 Arnd Bergmann
2011-07-01 14:52 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201107072304.05626.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=LW@karo-electronics.de \
--cc=b32955@freescale.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-mtd@lists.infradead.org \
--cc=s.hauer@pengutronix.de \
--cc=thierry.nolf.barco@gmail.com \
--cc=u.kleine-koenig@pengutronix.de \
--cc=w.sang@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.