* [PATCH] input/keyboard: Remove obsolete cleanup for clientdata
@ 2011-06-20 21:01 Wolfram Sang
[not found] ` <1308603674-19264-1-git-send-email-w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
0 siblings, 1 reply; 11+ messages in thread
From: Wolfram Sang @ 2011-06-20 21:01 UTC (permalink / raw)
To: linux-i2c-u79uwXL29TY76Z2rM5mHXA
Cc: Wolfram Sang, Dmitry Torokhov, Bo Shen, Axel Lin,
linux-input-u79uwXL29TY76Z2rM5mHXA
A few new i2c-drivers came into the kernel which clear the clientdata-pointer
on exit or error. This is obsolete meanwhile, the core will do it.
Signed-off-by: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Cc: Dmitry Torokhov <dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Bo Shen <voice.shen-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
Cc: Axel Lin <axel.lin-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
---
This is more a cleanup than a bugfix. Still, would be happy to have this
obsolete programming style largely removed in 3.0 if possible.
drivers/input/keyboard/qt1070.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/input/keyboard/qt1070.c b/drivers/input/keyboard/qt1070.c
index ca7b891..b21bf5b 100644
--- a/drivers/input/keyboard/qt1070.c
+++ b/drivers/input/keyboard/qt1070.c
@@ -239,8 +239,6 @@ static int __devexit qt1070_remove(struct i2c_client *client)
input_unregister_device(data->input);
kfree(data);
- i2c_set_clientdata(client, NULL);
-
return 0;
}
--
1.7.2.5
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH] leds: Remove obsolete cleanup for clientdata
[not found] ` <1308603674-19264-1-git-send-email-w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
@ 2011-06-20 21:01 ` Wolfram Sang
[not found] ` <1308603674-19264-2-git-send-email-w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2011-06-20 21:01 ` [PATCH] power: " Wolfram Sang
2011-06-21 8:55 ` [PATCH] input/keyboard: " Jean Delvare
2 siblings, 1 reply; 11+ messages in thread
From: Wolfram Sang @ 2011-06-20 21:01 UTC (permalink / raw)
To: linux-i2c-u79uwXL29TY76Z2rM5mHXA; +Cc: Wolfram Sang, Richard Purdie
A few new i2c-drivers came into the kernel which clear the clientdata-pointer
on exit or error. This is obsolete meanwhile, the core will do it.
Signed-off-by: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Cc: Richard Purdie <rpurdie-Fm38FmjxZ/leoWH0uzbU5w@public.gmane.org>
---
This is more a cleanup than a bugfix. Still, would be happy to have this
obsolete programming style largely removed in 3.0 if possible.
drivers/leds/leds-lm3530.c | 1 -
1 files changed, 0 insertions(+), 1 deletions(-)
diff --git a/drivers/leds/leds-lm3530.c b/drivers/leds/leds-lm3530.c
index 4d7ce76..59f5604 100644
--- a/drivers/leds/leds-lm3530.c
+++ b/drivers/leds/leds-lm3530.c
@@ -382,7 +382,6 @@ err_class_register:
err_reg_init:
regulator_put(drvdata->regulator);
err_regulator_get:
- i2c_set_clientdata(client, NULL);
kfree(drvdata);
err_out:
return err;
--
1.7.2.5
^ permalink raw reply related [flat|nested] 11+ messages in thread
* [PATCH] power: Remove obsolete cleanup for clientdata
[not found] ` <1308603674-19264-1-git-send-email-w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2011-06-20 21:01 ` [PATCH] leds: " Wolfram Sang
@ 2011-06-20 21:01 ` Wolfram Sang
[not found] ` <1308603674-19264-3-git-send-email-w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2011-06-21 8:55 ` [PATCH] input/keyboard: " Jean Delvare
2 siblings, 1 reply; 11+ messages in thread
From: Wolfram Sang @ 2011-06-20 21:01 UTC (permalink / raw)
To: linux-i2c-u79uwXL29TY76Z2rM5mHXA
Cc: Wolfram Sang, MyungJoo Ham, Anton Vorontsov, Kyungmin Park
A few new i2c-drivers came into the kernel which clear the clientdata-pointer
on exit or error. This is obsolete meanwhile, the core will do it.
Signed-off-by: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
Cc: MyungJoo Ham <myungjoo.ham-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
Cc: Anton Vorontsov <cbouatmailru-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Kyungmin Park <kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
---
This is more a cleanup than a bugfix. Still, would be happy to have this
obsolete programming style largely removed in 3.0 if possible.
drivers/power/max17042_battery.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/power/max17042_battery.c b/drivers/power/max17042_battery.c
index c5c8805..09f7496 100644
--- a/drivers/power/max17042_battery.c
+++ b/drivers/power/max17042_battery.c
@@ -183,7 +183,6 @@ static int __devinit max17042_probe(struct i2c_client *client,
ret = power_supply_register(&client->dev, &chip->battery);
if (ret) {
dev_err(&client->dev, "failed: power supply register\n");
- i2c_set_clientdata(client, NULL);
kfree(chip);
return ret;
}
@@ -202,7 +201,6 @@ static int __devexit max17042_remove(struct i2c_client *client)
struct max17042_chip *chip = i2c_get_clientdata(client);
power_supply_unregister(&chip->battery);
- i2c_set_clientdata(client, NULL);
kfree(chip);
return 0;
}
--
1.7.2.5
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH] power: Remove obsolete cleanup for clientdata
[not found] ` <1308603674-19264-3-git-send-email-w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
@ 2011-06-21 8:54 ` Jean Delvare
[not found] ` <20110621105456.05839025-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2011-07-08 13:10 ` Anton Vorontsov
1 sibling, 1 reply; 11+ messages in thread
From: Jean Delvare @ 2011-06-21 8:54 UTC (permalink / raw)
To: Wolfram Sang
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA, MyungJoo Ham, Anton Vorontsov,
Kyungmin Park
On Mon, 20 Jun 2011 23:01:14 +0200, Wolfram Sang wrote:
> A few new i2c-drivers came into the kernel which clear the clientdata-pointer
> on exit or error. This is obsolete meanwhile, the core will do it.
>
> Signed-off-by: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
> Cc: MyungJoo Ham <myungjoo.ham-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> Cc: Anton Vorontsov <cbouatmailru-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Cc: Kyungmin Park <kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
Acked-by: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
> ---
>
> This is more a cleanup than a bugfix. Still, would be happy to have this
> obsolete programming style largely removed in 3.0 if possible.
>
> drivers/power/max17042_battery.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/power/max17042_battery.c b/drivers/power/max17042_battery.c
> index c5c8805..09f7496 100644
> --- a/drivers/power/max17042_battery.c
> +++ b/drivers/power/max17042_battery.c
> @@ -183,7 +183,6 @@ static int __devinit max17042_probe(struct i2c_client *client,
> ret = power_supply_register(&client->dev, &chip->battery);
> if (ret) {
> dev_err(&client->dev, "failed: power supply register\n");
> - i2c_set_clientdata(client, NULL);
> kfree(chip);
> return ret;
> }
> @@ -202,7 +201,6 @@ static int __devexit max17042_remove(struct i2c_client *client)
> struct max17042_chip *chip = i2c_get_clientdata(client);
>
> power_supply_unregister(&chip->battery);
> - i2c_set_clientdata(client, NULL);
> kfree(chip);
> return 0;
> }
--
Jean Delvare
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] leds: Remove obsolete cleanup for clientdata
[not found] ` <1308603674-19264-2-git-send-email-w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
@ 2011-06-21 8:55 ` Jean Delvare
0 siblings, 0 replies; 11+ messages in thread
From: Jean Delvare @ 2011-06-21 8:55 UTC (permalink / raw)
To: Wolfram Sang; +Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA, Richard Purdie
On Mon, 20 Jun 2011 23:01:13 +0200, Wolfram Sang wrote:
> A few new i2c-drivers came into the kernel which clear the clientdata-pointer
> on exit or error. This is obsolete meanwhile, the core will do it.
>
> Signed-off-by: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
> Cc: Richard Purdie <rpurdie-Fm38FmjxZ/leoWH0uzbU5w@public.gmane.org>
Acked-by: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
> ---
>
> This is more a cleanup than a bugfix. Still, would be happy to have this
> obsolete programming style largely removed in 3.0 if possible.
>
> drivers/leds/leds-lm3530.c | 1 -
> 1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/leds/leds-lm3530.c b/drivers/leds/leds-lm3530.c
> index 4d7ce76..59f5604 100644
> --- a/drivers/leds/leds-lm3530.c
> +++ b/drivers/leds/leds-lm3530.c
> @@ -382,7 +382,6 @@ err_class_register:
> err_reg_init:
> regulator_put(drvdata->regulator);
> err_regulator_get:
> - i2c_set_clientdata(client, NULL);
> kfree(drvdata);
> err_out:
> return err;
--
Jean Delvare
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] input/keyboard: Remove obsolete cleanup for clientdata
[not found] ` <1308603674-19264-1-git-send-email-w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2011-06-20 21:01 ` [PATCH] leds: " Wolfram Sang
2011-06-20 21:01 ` [PATCH] power: " Wolfram Sang
@ 2011-06-21 8:55 ` Jean Delvare
2011-06-21 10:40 ` Dmitry Torokhov
2 siblings, 1 reply; 11+ messages in thread
From: Jean Delvare @ 2011-06-21 8:55 UTC (permalink / raw)
To: Wolfram Sang
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA, Dmitry Torokhov, Bo Shen,
Axel Lin, linux-input-u79uwXL29TY76Z2rM5mHXA
On Mon, 20 Jun 2011 23:01:12 +0200, Wolfram Sang wrote:
> A few new i2c-drivers came into the kernel which clear the clientdata-pointer
> on exit or error. This is obsolete meanwhile, the core will do it.
>
> Signed-off-by: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
> Cc: Dmitry Torokhov <dmitry.torokhov-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Cc: Bo Shen <voice.shen-AIFe0yeh4nAAvxtiuMwx3w@public.gmane.org>
> Cc: Axel Lin <axel.lin-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Acked-by: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
> ---
>
> This is more a cleanup than a bugfix. Still, would be happy to have this
> obsolete programming style largely removed in 3.0 if possible.
>
> drivers/input/keyboard/qt1070.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/input/keyboard/qt1070.c b/drivers/input/keyboard/qt1070.c
> index ca7b891..b21bf5b 100644
> --- a/drivers/input/keyboard/qt1070.c
> +++ b/drivers/input/keyboard/qt1070.c
> @@ -239,8 +239,6 @@ static int __devexit qt1070_remove(struct i2c_client *client)
> input_unregister_device(data->input);
> kfree(data);
>
> - i2c_set_clientdata(client, NULL);
> -
> return 0;
> }
>
--
Jean Delvare
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] input/keyboard: Remove obsolete cleanup for clientdata
2011-06-21 8:55 ` [PATCH] input/keyboard: " Jean Delvare
@ 2011-06-21 10:40 ` Dmitry Torokhov
0 siblings, 0 replies; 11+ messages in thread
From: Dmitry Torokhov @ 2011-06-21 10:40 UTC (permalink / raw)
To: Jean Delvare; +Cc: Wolfram Sang, linux-i2c, Bo Shen, Axel Lin, linux-input
On Tue, Jun 21, 2011 at 10:55:32AM +0200, Jean Delvare wrote:
> On Mon, 20 Jun 2011 23:01:12 +0200, Wolfram Sang wrote:
> > A few new i2c-drivers came into the kernel which clear the clientdata-pointer
> > on exit or error. This is obsolete meanwhile, the core will do it.
> >
> > Signed-off-by: Wolfram Sang <w.sang@pengutronix.de>
> > Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
> > Cc: Bo Shen <voice.shen@atmel.com>
> > Cc: Axel Lin <axel.lin@gmail.com>
>
> Acked-by: Jean Delvare <khali@linux-fr.org>
>
Applied, thanks Wolfram.
--
Dmitry
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] power: Remove obsolete cleanup for clientdata
[not found] ` <20110621105456.05839025-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
@ 2011-07-08 9:15 ` Wolfram Sang
[not found] ` <20110708091556.GE2048-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
0 siblings, 1 reply; 11+ messages in thread
From: Wolfram Sang @ 2011-07-08 9:15 UTC (permalink / raw)
To: Jean Delvare
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA, MyungJoo Ham, Anton Vorontsov,
Kyungmin Park
[-- Attachment #1: Type: text/plain, Size: 2249 bytes --]
On Tue, Jun 21, 2011 at 10:54:56AM +0200, Jean Delvare wrote:
> On Mon, 20 Jun 2011 23:01:14 +0200, Wolfram Sang wrote:
> > A few new i2c-drivers came into the kernel which clear the clientdata-pointer
> > on exit or error. This is obsolete meanwhile, the core will do it.
> >
> > Signed-off-by: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
> > Cc: MyungJoo Ham <myungjoo.ham-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> > Cc: Anton Vorontsov <cbouatmailru-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> > Cc: Kyungmin Park <kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
>
> Acked-by: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
Anton, can you pick it for 3.1?
>
> > ---
> >
> > This is more a cleanup than a bugfix. Still, would be happy to have this
> > obsolete programming style largely removed in 3.0 if possible.
> >
> > drivers/power/max17042_battery.c | 2 --
> > 1 files changed, 0 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/power/max17042_battery.c b/drivers/power/max17042_battery.c
> > index c5c8805..09f7496 100644
> > --- a/drivers/power/max17042_battery.c
> > +++ b/drivers/power/max17042_battery.c
> > @@ -183,7 +183,6 @@ static int __devinit max17042_probe(struct i2c_client *client,
> > ret = power_supply_register(&client->dev, &chip->battery);
> > if (ret) {
> > dev_err(&client->dev, "failed: power supply register\n");
> > - i2c_set_clientdata(client, NULL);
> > kfree(chip);
> > return ret;
> > }
> > @@ -202,7 +201,6 @@ static int __devexit max17042_remove(struct i2c_client *client)
> > struct max17042_chip *chip = i2c_get_clientdata(client);
> >
> > power_supply_unregister(&chip->battery);
> > - i2c_set_clientdata(client, NULL);
> > kfree(chip);
> > return 0;
> > }
>
>
> --
> Jean Delvare
> --
> To unsubscribe from this list: send the line "unsubscribe linux-i2c" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] power: Remove obsolete cleanup for clientdata
[not found] ` <20110708091556.GE2048-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
@ 2011-07-08 9:28 ` Anton Vorontsov
0 siblings, 0 replies; 11+ messages in thread
From: Anton Vorontsov @ 2011-07-08 9:28 UTC (permalink / raw)
To: Wolfram Sang
Cc: Jean Delvare, linux-i2c-u79uwXL29TY76Z2rM5mHXA, MyungJoo Ham,
Kyungmin Park
On Fri, Jul 08, 2011 at 11:15:56AM +0200, Wolfram Sang wrote:
> On Tue, Jun 21, 2011 at 10:54:56AM +0200, Jean Delvare wrote:
> > On Mon, 20 Jun 2011 23:01:14 +0200, Wolfram Sang wrote:
> > > A few new i2c-drivers came into the kernel which clear the clientdata-pointer
> > > on exit or error. This is obsolete meanwhile, the core will do it.
> > >
> > > Signed-off-by: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
> > > Cc: MyungJoo Ham <myungjoo.ham-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> > > Cc: Anton Vorontsov <cbouatmailru-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> > > Cc: Kyungmin Park <kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> >
> > Acked-by: Jean Delvare <khali-PUYAD+kWke1g9hUCZPvPmw@public.gmane.org>
>
> Anton, can you pick it for 3.1?
Will do. Thanks!
--
Anton Vorontsov
Email: cbouatmailru-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] power: Remove obsolete cleanup for clientdata
[not found] ` <1308603674-19264-3-git-send-email-w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2011-06-21 8:54 ` Jean Delvare
@ 2011-07-08 13:10 ` Anton Vorontsov
[not found] ` <20110708131049.GD29056-wnGakbxT3iijyJ0x5qLZdcN33GVbZNy3@public.gmane.org>
1 sibling, 1 reply; 11+ messages in thread
From: Anton Vorontsov @ 2011-07-08 13:10 UTC (permalink / raw)
To: Wolfram Sang
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA, MyungJoo Ham, Kyungmin Park
On Mon, Jun 20, 2011 at 11:01:14PM +0200, Wolfram Sang wrote:
> A few new i2c-drivers came into the kernel which clear the clientdata-pointer
> on exit or error. This is obsolete meanwhile, the core will do it.
>
> Signed-off-by: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
> Cc: MyungJoo Ham <myungjoo.ham-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> Cc: Anton Vorontsov <cbouatmailru-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Cc: Kyungmin Park <kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> ---
>
> This is more a cleanup than a bugfix. Still, would be happy to have this
> obsolete programming style largely removed in 3.0 if possible.
Applied for 3.1, sorry. This is not a regression fix.
Thanks,
>
> drivers/power/max17042_battery.c | 2 --
> 1 files changed, 0 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/power/max17042_battery.c b/drivers/power/max17042_battery.c
> index c5c8805..09f7496 100644
> --- a/drivers/power/max17042_battery.c
> +++ b/drivers/power/max17042_battery.c
> @@ -183,7 +183,6 @@ static int __devinit max17042_probe(struct i2c_client *client,
> ret = power_supply_register(&client->dev, &chip->battery);
> if (ret) {
> dev_err(&client->dev, "failed: power supply register\n");
> - i2c_set_clientdata(client, NULL);
> kfree(chip);
> return ret;
> }
> @@ -202,7 +201,6 @@ static int __devexit max17042_remove(struct i2c_client *client)
> struct max17042_chip *chip = i2c_get_clientdata(client);
>
> power_supply_unregister(&chip->battery);
> - i2c_set_clientdata(client, NULL);
> kfree(chip);
> return 0;
> }
--
Anton Vorontsov
Email: cbouatmailru-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH] power: Remove obsolete cleanup for clientdata
[not found] ` <20110708131049.GD29056-wnGakbxT3iijyJ0x5qLZdcN33GVbZNy3@public.gmane.org>
@ 2011-07-08 13:40 ` Wolfram Sang
0 siblings, 0 replies; 11+ messages in thread
From: Wolfram Sang @ 2011-07-08 13:40 UTC (permalink / raw)
To: Anton Vorontsov
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA, MyungJoo Ham, Kyungmin Park
[-- Attachment #1: Type: text/plain, Size: 1020 bytes --]
On Fri, Jul 08, 2011 at 05:10:49PM +0400, Anton Vorontsov wrote:
> On Mon, Jun 20, 2011 at 11:01:14PM +0200, Wolfram Sang wrote:
> > A few new i2c-drivers came into the kernel which clear the clientdata-pointer
> > on exit or error. This is obsolete meanwhile, the core will do it.
> >
> > Signed-off-by: Wolfram Sang <w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
> > Cc: MyungJoo Ham <myungjoo.ham-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> > Cc: Anton Vorontsov <cbouatmailru-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> > Cc: Kyungmin Park <kyungmin.park-Sze3O3UU22JBDgjK7y7TUQ@public.gmane.org>
> > ---
> >
> > This is more a cleanup than a bugfix. Still, would be happy to have this
> > obsolete programming style largely removed in 3.0 if possible.
>
> Applied for 3.1, sorry. This is not a regression fix.
3.1 is fine, too. Thanks!
--
Pengutronix e.K. | Wolfram Sang |
Industrial Linux Solutions | http://www.pengutronix.de/ |
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2011-07-08 13:40 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-06-20 21:01 [PATCH] input/keyboard: Remove obsolete cleanup for clientdata Wolfram Sang
[not found] ` <1308603674-19264-1-git-send-email-w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2011-06-20 21:01 ` [PATCH] leds: " Wolfram Sang
[not found] ` <1308603674-19264-2-git-send-email-w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2011-06-21 8:55 ` Jean Delvare
2011-06-20 21:01 ` [PATCH] power: " Wolfram Sang
[not found] ` <1308603674-19264-3-git-send-email-w.sang-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2011-06-21 8:54 ` Jean Delvare
[not found] ` <20110621105456.05839025-R0o5gVi9kd7kN2dkZ6Wm7A@public.gmane.org>
2011-07-08 9:15 ` Wolfram Sang
[not found] ` <20110708091556.GE2048-bIcnvbaLZ9MEGnE8C9+IrQ@public.gmane.org>
2011-07-08 9:28 ` Anton Vorontsov
2011-07-08 13:10 ` Anton Vorontsov
[not found] ` <20110708131049.GD29056-wnGakbxT3iijyJ0x5qLZdcN33GVbZNy3@public.gmane.org>
2011-07-08 13:40 ` Wolfram Sang
2011-06-21 8:55 ` [PATCH] input/keyboard: " Jean Delvare
2011-06-21 10:40 ` Dmitry Torokhov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.