* [PATCH] net/natsemi: Fix module parameter permissions
@ 2011-07-08 9:01 Jean Delvare
2011-07-08 16:05 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Jean Delvare @ 2011-07-08 9:01 UTC (permalink / raw)
To: netdev; +Cc: Tim Hockin, Mark Brown
The third parameter of module_param is supposed to represent sysfs
file permissions. A value of "1" leads to the following:
$ ls -l /sys/module/natsemi/parameters/
total 0
---------x 1 root root 4096 Jul 8 09:46 dspcfg_workaround
I am changing it to "0" to align with the other module parameters in
this driver.
Signed-off-by: Jean Delvare <jdelvare@suse.de>
Cc: Tim Hockin <thockin@hockin.org>
Cc: Mark Brown <broonie@opensource.wolfsonmicro.com>
---
drivers/net/natsemi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- linux-3.0-rc6.orig/drivers/net/natsemi.c 2011-05-30 20:45:13.000000000 +0200
+++ linux-3.0-rc6/drivers/net/natsemi.c 2011-07-08 09:57:47.000000000 +0200
@@ -140,7 +140,7 @@ MODULE_LICENSE("GPL");
module_param(mtu, int, 0);
module_param(debug, int, 0);
module_param(rx_copybreak, int, 0);
-module_param(dspcfg_workaround, int, 1);
+module_param(dspcfg_workaround, int, 0);
module_param_array(options, int, NULL, 0);
module_param_array(full_duplex, int, NULL, 0);
MODULE_PARM_DESC(mtu, "DP8381x MTU (all boards)");
--
Jean Delvare
Suse L3
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] net/natsemi: Fix module parameter permissions
2011-07-08 9:01 [PATCH] net/natsemi: Fix module parameter permissions Jean Delvare
@ 2011-07-08 16:05 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2011-07-08 16:05 UTC (permalink / raw)
To: jdelvare; +Cc: netdev, thockin, broonie
From: Jean Delvare <jdelvare@suse.de>
Date: Fri, 8 Jul 2011 11:01:28 +0200
> The third parameter of module_param is supposed to represent sysfs
> file permissions. A value of "1" leads to the following:
>
> $ ls -l /sys/module/natsemi/parameters/
> total 0
> ---------x 1 root root 4096 Jul 8 09:46 dspcfg_workaround
>
> I am changing it to "0" to align with the other module parameters in
> this driver.
>
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
Applied, thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-07-08 16:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-07-08 9:01 [PATCH] net/natsemi: Fix module parameter permissions Jean Delvare
2011-07-08 16:05 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.