* [PATCH 8/8] Staging: comedi: fix printk() issue in pcl818.c
[not found] <[PATCH 7/7]Staging: comedi: fix printk issue in pcl818.c>
@ 2011-07-11 7:19 ` Ravishankar
2011-07-11 8:06 ` Dan Carpenter
0 siblings, 1 reply; 2+ messages in thread
From: Ravishankar @ 2011-07-11 7:19 UTC (permalink / raw)
To: gregkh, wfp5p; +Cc: devel, linux-kernel, Ravishankar, Ravishankar
From: Ravishankar <ravi.shankar@greenturtles.in>
This is a patch to the pcl818.c file that fixes up a printk warning found by the checkpatch.pl tool
Signed-off-by: Ravishankar <ravishankarkm32@gmail.com>
---
drivers/staging/comedi/drivers/pcl818.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/comedi/drivers/pcl818.c b/drivers/staging/comedi/drivers/pcl818.c
index ae097b3..21f1cc9 100644
--- a/drivers/staging/comedi/drivers/pcl818.c
+++ b/drivers/staging/comedi/drivers/pcl818.c
@@ -1447,7 +1447,7 @@ static int ai_cmd(struct comedi_device *dev, struct comedi_subdevice *s)
struct comedi_cmd *cmd = &s->async->cmd;
int retval;
- printk("pcl818_ai_cmd()\n");
+ printk(KERN_INFO "pcl818_ai_cmd()\n");
devpriv->ai_n_chan = cmd->chanlist_len;
devpriv->ai_chanlist = cmd->chanlist;
devpriv->ai_flags = cmd->flags;
@@ -1465,7 +1465,7 @@ static int ai_cmd(struct comedi_device *dev, struct comedi_subdevice *s)
if (cmd->convert_src == TRIG_TIMER) { /* mode 1 */
devpriv->ai_timer1 = cmd->convert_arg;
retval = pcl818_ai_cmd_mode(1, dev, s);
- printk("pcl818_ai_cmd() end\n");
+ printk(KERN_INFO "pcl818_ai_cmd() end\n");
return retval;
}
if (cmd->convert_src == TRIG_EXT) { /* mode 3 */
@@ -1484,7 +1484,7 @@ static int pcl818_ai_cancel(struct comedi_device *dev,
struct comedi_subdevice *s)
{
if (devpriv->irq_blocked > 0) {
- printk("pcl818_ai_cancel()\n");
+ printk(KERN_INFO "pcl818_ai_cancel()\n");
devpriv->irq_was_now_closed = 1;
switch (devpriv->ai_mode) {
--
1.6.5.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH 8/8] Staging: comedi: fix printk() issue in pcl818.c
2011-07-11 7:19 ` [PATCH 8/8] Staging: comedi: fix printk() issue in pcl818.c Ravishankar
@ 2011-07-11 8:06 ` Dan Carpenter
0 siblings, 0 replies; 2+ messages in thread
From: Dan Carpenter @ 2011-07-11 8:06 UTC (permalink / raw)
To: Ravishankar; +Cc: gregkh, wfp5p, devel, linux-kernel, Ravishankar
On Mon, Jul 11, 2011 at 12:49:14PM +0530, Ravishankar wrote:
> From: Ravishankar <ravi.shankar@greenturtles.in>
>
> This is a patch to the pcl818.c file that fixes up a printk warning found by the checkpatch.pl tool
>
> Signed-off-by: Ravishankar <ravishankarkm32@gmail.com>
> ---
> drivers/staging/comedi/drivers/pcl818.c | 6 +++---
> 1 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/comedi/drivers/pcl818.c b/drivers/staging/comedi/drivers/pcl818.c
> index ae097b3..21f1cc9 100644
> --- a/drivers/staging/comedi/drivers/pcl818.c
> +++ b/drivers/staging/comedi/drivers/pcl818.c
> @@ -1447,7 +1447,7 @@ static int ai_cmd(struct comedi_device *dev, struct comedi_subdevice *s)
> struct comedi_cmd *cmd = &s->async->cmd;
> int retval;
>
> - printk("pcl818_ai_cmd()\n");
> + printk(KERN_INFO "pcl818_ai_cmd()\n");
KERN_INFO is too high a level here. Ideally this would just be
removed. Possibly made into a dev_dbg().
The same is true for some other printks in this series.
regards,
dan carpenter
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-07-11 8:08 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <[PATCH 7/7]Staging: comedi: fix printk issue in pcl818.c>
2011-07-11 7:19 ` [PATCH 8/8] Staging: comedi: fix printk() issue in pcl818.c Ravishankar
2011-07-11 8:06 ` Dan Carpenter
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.