All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: wzt wzt <wzt.wzt@gmail.com>
Cc: Andi Kleen <ak@linux.intel.com>, Michal Hocko <mhocko@suse.cz>,
	mingo@redhat.com, linux-kernel@vger.kernel.org, x86@kernel.org,
	tglx@linutronix.de, hpa@zytor.com
Subject: Re: [PATCH] x86: Fix memory leak of init_vdso_vars()
Date: Mon, 11 Jul 2011 12:04:18 +0200	[thread overview]
Message-ID: <20110711100418.GC9859@elte.hu> (raw)
In-Reply-To: <CAEQi4bfm7zp-Lq-Hn8JD7Dq7fOzyt2-X9Kk_jB07S_S55uC81w@mail.gmail.com>


* wzt wzt <wzt.wzt@gmail.com> wrote:

> maybe, we can just panic() when kmalloc failed instead of add a new 
> GFP_PANIC.
> 
> new patch will coming soon.
> 
> On Fri, Jul 8, 2011 at 2:33 AM, Andi Kleen <ak@linux.intel.com> wrote:
> > When you run out of memory at early system boot (this is early
> > system boot only) the system is toast anyways. There's no way
> > to recover.
> >
> > I would just add a few GFP_PANICs and then drop the error paths.

That's a very sloppy way of doing it: should anyone ever want to 
reuse this function *not* in an init path (which is a future 
possibility with the vdso) it will have a nasty panic() embedded in 
it ...

Thanks,

	Ingo

  reply	other threads:[~2011-07-11 10:04 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-05  6:21 [PATCH] x86: Fix memory leak of init_vdso_vars() wzt
2011-07-07 13:14 ` Michal Hocko
2011-07-07 18:33   ` Andi Kleen
2011-07-11  3:23     ` wzt wzt
2011-07-11 10:04       ` Ingo Molnar [this message]
2011-07-21 14:33 ` Andy Lutomirski
2011-07-21 17:08   ` Andi Kleen
2011-07-21 17:26     ` Andrew Lutomirski
2011-07-21 18:38       ` Ingo Molnar
2011-07-21 19:39         ` Andrew Lutomirski
2011-07-21 19:43           ` Ingo Molnar
2011-07-21 19:47           ` [PATCH] x86-64: Do not allocate memory for the vDSO Andy Lutomirski
2011-07-21 20:52             ` [tip:x86/vdso] x86-64, vdso: " tip-bot for Andy Lutomirski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110711100418.GC9859@elte.hu \
    --to=mingo@elte.hu \
    --cc=ak@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mhocko@suse.cz \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=wzt.wzt@gmail.com \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.