Re: [PATCH] x86: Fix memory leak of init_vdso_vars()

[Ingo Molnar <mingo@elte.hu>]

* Andrew Lutomirski <luto@mit.edu> wrote:

> On Thu, Jul 21, 2011 at 1:08 PM, Andi Kleen <ak@linux.intel.com> wrote:
> > On Thu, Jul 21, 2011 at 10:33:14AM -0400, Andy Lutomirski wrote:
> >> From: Zhitong Wang <wzt.wzt@gmail.com>
> >>
> >> If init_vdso_vars ran out of memory (not very likely), then it would
> >> leak a few pages as well.
> >>
> >> Also rename init_vdso_vars to just init_vdso, since initializing
> >> vvars is just about the only thing this function doesn't do.
> >
> > Just add a GFP_PANIC, there's no way to recover from this.
> > Your system will not work without a vdso.
>
> Ingo objected to this before, although I'm not convinved.  Calling 
> init_vdso_vars more than once will cause major problems (like 
> double-patching of alternatives).  If there's too little memory for 
> it to work, then presumably there's also too little memory to start 
> init.
>
>  (Also, I bet that no one ever audited whether the ELF loader works 
> right if the vDSO failed to load.)
> 
> Ingo?

This assumes that the system actually needs an ELF loader - if a 
static binary is booted via a init= boot parameter it might not be 
needed.

Memory failure injection code will also cause this to panic early 
during bootup spuriously.

Really, we should cleanly tear down what we built up and fail cleanly 
as well, no need to be sloppy since we already have the patch. That 
some other code down the boot chain might be sloppy is no excuse to 
be sloppy here.

Would be nice to stick a WARN_ON() into the oom branch though, as 
it's clearly an anomalous condition.

(btw., there's no GFP_PANIC, we never had any such flag for the page 
allocator.)

Thanks,

	Ingo