[PATCH] Doc:cgroup:fix a cpuset's file description in cpusets.txt

[PATCH] Doc:cgroup:fix a cpuset's file description in cpusets.txt

[Wanlong Gao]

Only the root cpuset has cpuset.memory_pressure_enabled flag,
but not the only one.

Signed-off-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>
---
 Documentation/cgroups/cpusets.txt |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/Documentation/cgroups/cpusets.txt b/Documentation/cgroups/cpusets.txt
index 5b0d78e..5c51ed4 100644
--- a/Documentation/cgroups/cpusets.txt
+++ b/Documentation/cgroups/cpusets.txt
@@ -180,7 +180,7 @@ files describing that cpuset:
  - cpuset.sched_load_balance flag: if set, load balance within CPUs on that cpuset
  - cpuset.sched_relax_domain_level: the searching range when migrating tasks
 
-In addition, the root cpuset only has the following file:
+In addition, only the root cpuset has the following file:
  - cpuset.memory_pressure_enabled flag: compute memory_pressure?
 
 New cpusets are created using the mkdir system call or shell
-- 
1.7.4.1

Re: [PATCH] Doc:cgroup:fix a cpuset's file description in cpusets.txt

[Randy Dunlap]

On Sun, 10 Jul 2011 16:58:33 +0800 Wanlong Gao wrote:

> Only the root cpuset has cpuset.memory_pressure_enabled flag,
> but not the only one.
> 
> Signed-off-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>

Applied.  Thanks.

> ---
>  Documentation/cgroups/cpusets.txt |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/Documentation/cgroups/cpusets.txt b/Documentation/cgroups/cpusets.txt
> index 5b0d78e..5c51ed4 100644
> --- a/Documentation/cgroups/cpusets.txt
> +++ b/Documentation/cgroups/cpusets.txt
> @@ -180,7 +180,7 @@ files describing that cpuset:
>   - cpuset.sched_load_balance flag: if set, load balance within CPUs on that cpuset
>   - cpuset.sched_relax_domain_level: the searching range when migrating tasks
>  
> -In addition, the root cpuset only has the following file:
> +In addition, only the root cpuset has the following file:
>   - cpuset.memory_pressure_enabled flag: compute memory_pressure?
>  
>  New cpusets are created using the mkdir system call or shell
> -- 


---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

Re: [PATCH] Doc:cgroup:fix a cpuset's file description in cpusets.txt

[Paul Menage]

On Sun, Jul 10, 2011 at 1:58 AM, Wanlong Gao <wanlong.gao@gmail.com> wrote:
> Only the root cpuset has cpuset.memory_pressure_enabled flag,
> but not the only one.
>
> Signed-off-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>

Acked-by: Paul Menage <menage@google.com>

The original was actually correct English, when parsed as "(the root
cpuset only) (has the following file)", but I guess ambiguous. I'd be
inclined to just remove the word "only", since it's unnecessary in its
new location.

Paul

Re: [PATCH] Doc:cgroup:fix a cpuset's file description in cpusets.txt

[Randy Dunlap]

On Mon, 11 Jul 2011 10:23:53 -0700 Paul Menage wrote:

> On Sun, Jul 10, 2011 at 1:58 AM, Wanlong Gao <wanlong.gao@gmail.com> wrote:
> > Only the root cpuset has cpuset.memory_pressure_enabled flag,
> > but not the only one.
> >
> > Signed-off-by: Wanlong Gao <gaowanlong@cn.fujitsu.com>
> 
> Acked-by: Paul Menage <menage@google.com>

Thanks.

> The original was actually correct English, when parsed as "(the root
> cpuset only) (has the following file)", but I guess ambiguous. I'd be
> inclined to just remove the word "only", since it's unnecessary in its
> new location.

Yes, it's ambiguous and/or too restrictive.
Yes, we could just drop the word "only".

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***