All of lore.kernel.org
 help / color / mirror / Atom feed
From: Scott Wood <scottwood@freescale.com>
To: Fabio Baltieri <fabio.baltieri@gmail.com>
Cc: Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	Poonam Aggrwal <poonam.aggrwal@freescale.com>,
	<linuxppc-dev@lists.ozlabs.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] powerpc/85xx: fix mpic configuration in CAMP mode
Date: Mon, 11 Jul 2011 14:38:59 -0500	[thread overview]
Message-ID: <20110711143859.0e6c95d8@schlenkerla.am.freescale.net> (raw)
In-Reply-To: <CABkP77e6vLmLxk3wCP39GJ7+yKnJZFc7BPUZ1OkdA8d7KkBCiw@mail.gmail.com>

On Sun, 10 Jul 2011 20:55:32 +0200
Fabio Baltieri <fabio.baltieri@gmail.com> wrote:

> Change the string to check for CAMP mode boot on MPC85xx (eg. P2020) to match
> the one in the corresponding dts files (p2020rdb_camp_core{0,1}.dts).
> 
> Without this fix the mpic is configured as in the SMP boot mode, which causes
> the first core to report a protected source interrupt error for devices
> of the other core and lock up.
> 
> Signed-off-by: Fabio Baltieri <fabio.baltieri@gmail.com>
> ---
>  arch/powerpc/platforms/85xx/mpc85xx_rdb.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/powerpc/platforms/85xx/mpc85xx_rdb.c
> b/arch/powerpc/platforms/85xx/mpc85xx_rdb.c
> index 088f30b..a1e5e70 100644
> --- a/arch/powerpc/platforms/85xx/mpc85xx_rdb.c
> +++ b/arch/powerpc/platforms/85xx/mpc85xx_rdb.c
> @@ -58,7 +58,7 @@ void __init mpc85xx_rdb_pic_init(void)
>  		return;
>  	}
> 
> -	if (of_flat_dt_is_compatible(root, "fsl,85XXRDB-CAMP")) {
> +	if (of_flat_dt_is_compatible(root, "fsl,MPC85XXRDB-CAMP")) {
>  		mpic = mpic_alloc(np, r.start,
>  			MPIC_PRIMARY |
>  			MPIC_BIG_ENDIAN | MPIC_BROKEN_FRR_NIRQS,

Shouldn't we be setting MPIC_SINGLE_DEST_CPU in this case (as we do for
the other case)?

Or just drop this and specify pic-no-reset in the mpic node.

-Scott


WARNING: multiple messages have this Message-ID (diff)
From: Scott Wood <scottwood@freescale.com>
To: Fabio Baltieri <fabio.baltieri@gmail.com>
Cc: Poonam Aggrwal <poonam.aggrwal@freescale.com>,
	linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] powerpc/85xx: fix mpic configuration in CAMP mode
Date: Mon, 11 Jul 2011 14:38:59 -0500	[thread overview]
Message-ID: <20110711143859.0e6c95d8@schlenkerla.am.freescale.net> (raw)
In-Reply-To: <CABkP77e6vLmLxk3wCP39GJ7+yKnJZFc7BPUZ1OkdA8d7KkBCiw@mail.gmail.com>

On Sun, 10 Jul 2011 20:55:32 +0200
Fabio Baltieri <fabio.baltieri@gmail.com> wrote:

> Change the string to check for CAMP mode boot on MPC85xx (eg. P2020) to match
> the one in the corresponding dts files (p2020rdb_camp_core{0,1}.dts).
> 
> Without this fix the mpic is configured as in the SMP boot mode, which causes
> the first core to report a protected source interrupt error for devices
> of the other core and lock up.
> 
> Signed-off-by: Fabio Baltieri <fabio.baltieri@gmail.com>
> ---
>  arch/powerpc/platforms/85xx/mpc85xx_rdb.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/powerpc/platforms/85xx/mpc85xx_rdb.c
> b/arch/powerpc/platforms/85xx/mpc85xx_rdb.c
> index 088f30b..a1e5e70 100644
> --- a/arch/powerpc/platforms/85xx/mpc85xx_rdb.c
> +++ b/arch/powerpc/platforms/85xx/mpc85xx_rdb.c
> @@ -58,7 +58,7 @@ void __init mpc85xx_rdb_pic_init(void)
>  		return;
>  	}
> 
> -	if (of_flat_dt_is_compatible(root, "fsl,85XXRDB-CAMP")) {
> +	if (of_flat_dt_is_compatible(root, "fsl,MPC85XXRDB-CAMP")) {
>  		mpic = mpic_alloc(np, r.start,
>  			MPIC_PRIMARY |
>  			MPIC_BIG_ENDIAN | MPIC_BROKEN_FRR_NIRQS,

Shouldn't we be setting MPIC_SINGLE_DEST_CPU in this case (as we do for
the other case)?

Or just drop this and specify pic-no-reset in the mpic node.

-Scott

  reply	other threads:[~2011-07-11 19:39 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-10 18:55 [PATCH] powerpc/85xx: fix mpic configuration in CAMP mode Fabio Baltieri
2011-07-11 19:38 ` Scott Wood [this message]
2011-07-11 19:38   ` Scott Wood
2011-07-12  7:38   ` Fabio Baltieri
2011-07-12  7:38     ` Fabio Baltieri
2011-07-12  7:49   ` [PATCH v2] " Fabio Baltieri
2011-07-12  7:49     ` Fabio Baltieri
2011-07-22  8:28     ` Kumar Gala
2011-07-22  8:28       ` Kumar Gala

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110711143859.0e6c95d8@schlenkerla.am.freescale.net \
    --to=scottwood@freescale.com \
    --cc=benh@kernel.crashing.org \
    --cc=fabio.baltieri@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=poonam.aggrwal@freescale.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.