All of lore.kernel.org
 help / color / mirror / Atom feed
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Cong Wang <amwang@redhat.com>
Cc: Takao Indoh <indou.takao@jp.fujitsu.com>,
	linux-kernel@vger.kernel.org, ebiederm@xmission.com,
	vgoyal@redhat.com, rdunlap@xenotime.net, lenb@kernel.org,
	linux-doc@vger.kernel.org, linux-acpi@vger.kernel.org,
	mjg@redhat.com
Subject: Re: [PATCH v2] acpi: introduce "acpi_rsdp=" parameter for kdump
Date: Tue, 12 Jul 2011 09:31:19 -0400	[thread overview]
Message-ID: <20110712133119.GA7377@dumpdata.com> (raw)
In-Reply-To: <4E1C223A.9000705@redhat.com>

On Tue, Jul 12, 2011 at 06:30:18PM +0800, Cong Wang wrote:
> 于 2011年07月11日 23:14, Takao Indoh 写道:
> >Revised version of the patch which was posted by Cong WANG
> >
> >Changes in v2:
> >* Change parameter name from "acpi_addr" to "acpi_rsdp"
> >* Add CONFIG_KEXEC
> 
> Thanks for updating it! Definitely looks good to me,

The only comment I've is that it would be good to include in the
patch description which sysfs attribute is used by the kexec tools
to read in the physical address to be passed in.

Otherwise it looks good to me too.
> 
> Reviewed-by: WANG Cong <amwang@redhat.com>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Cong Wang <amwang@redhat.com>
Cc: Takao Indoh <indou.takao@jp.fujitsu.com>,
	linux-kernel@vger.kernel.org, ebiederm@xmission.com,
	vgoyal@redhat.com, rdunlap@xenotime.net, lenb@kernel.org,
	linux-doc@vger.kernel.org, linux-acpi@vger.kernel.org,
	mjg@redhat.com
Subject: Re: [PATCH v2] acpi: introduce "acpi_rsdp=" parameter for kdump
Date: Tue, 12 Jul 2011 09:31:19 -0400	[thread overview]
Message-ID: <20110712133119.GA7377@dumpdata.com> (raw)
In-Reply-To: <4E1C223A.9000705@redhat.com>

On Tue, Jul 12, 2011 at 06:30:18PM +0800, Cong Wang wrote:
> 于 2011年07月11日 23:14, Takao Indoh 写道:
> >Revised version of the patch which was posted by Cong WANG
> >
> >Changes in v2:
> >* Change parameter name from "acpi_addr" to "acpi_rsdp"
> >* Add CONFIG_KEXEC
> 
> Thanks for updating it! Definitely looks good to me,

The only comment I've is that it would be good to include in the
patch description which sysfs attribute is used by the kexec tools
to read in the physical address to be passed in.

Otherwise it looks good to me too.
> 
> Reviewed-by: WANG Cong <amwang@redhat.com>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/

  reply	other threads:[~2011-07-12 13:31 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-11 15:14 [PATCH v2] acpi: introduce "acpi_rsdp=" parameter for kdump Takao Indoh
2011-07-11 17:23 ` Konrad Rzeszutek Wilk
2011-07-11 17:27   ` Matthew Garrett
2011-07-12 10:30 ` Cong Wang
2011-07-12 10:30   ` Cong Wang
2011-07-12 13:31   ` Konrad Rzeszutek Wilk [this message]
2011-07-12 13:31     ` Konrad Rzeszutek Wilk
2011-07-14 22:05     ` Takao Indoh
2011-07-16 22:41       ` Len Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110712133119.GA7377@dumpdata.com \
    --to=konrad.wilk@oracle.com \
    --cc=amwang@redhat.com \
    --cc=ebiederm@xmission.com \
    --cc=indou.takao@jp.fujitsu.com \
    --cc=lenb@kernel.org \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mjg@redhat.com \
    --cc=rdunlap@xenotime.net \
    --cc=vgoyal@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.