All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stanislaw Gruszka <sgruszka@redhat.com>
To: "John W. Linville" <linville@tuxdriver.com>
Cc: Joe Perches <joe@perches.com>,
	linux-wireless@vger.kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] iwlegacy: Add missing comma between constant string array
Date: Wed, 13 Jul 2011 11:25:38 +0200	[thread overview]
Message-ID: <20110713092538.GA2429@redhat.com> (raw)
In-Reply-To: <20110711183542.GB2650@tuxdriver.com>

On Mon, Jul 11, 2011 at 02:35:42PM -0400, John W. Linville wrote:
> How is this array indexed?  Aren't you changing the index of the
> later strings?

We read index directly from device memory (and check agains
ARRAY_SIZE). Patch make indexing correct with code author
intention, ACK. iwlagn should be simmilarly fine.

Stanislaw

> On Fri, Jul 08, 2011 at 11:20:24PM -0700, Joe Perches wrote:
> > Multiple quoted strings are concatenated without comma separators.
> > 
> > Signed-off-by: Joe Perches <joe@perches.com>
> > ---
> >  drivers/net/wireless/iwlegacy/iwl4965-base.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> > diff --git a/drivers/net/wireless/iwlegacy/iwl4965-base.c b/drivers/net/wireless/iwlegacy/iwl4965-base.c
> > index 46242d2..1433466 100644
> > --- a/drivers/net/wireless/iwlegacy/iwl4965-base.c
> > +++ b/drivers/net/wireless/iwlegacy/iwl4965-base.c
> > @@ -1484,7 +1484,7 @@ static const char * const desc_lookup_text[] = {
> >  	"NMI_INTERRUPT_DATA_ACTION_PT",
> >  	"NMI_TRM_HW_ER",
> >  	"NMI_INTERRUPT_TRM",
> > -	"NMI_INTERRUPT_BREAK_POINT"
> > +	"NMI_INTERRUPT_BREAK_POINT",
> >  	"DEBUG_0",
> >  	"DEBUG_1",
> >  	"DEBUG_2",
> > -- 
> > 1.7.6.131.g99019
> > 
> > 
> 
> -- 
> John W. Linville		Someday the world will need a hero, and you
> linville@tuxdriver.com			might be all we have.  Be ready.
> --
> To unsubscribe from this list: send the line "unsubscribe linux-wireless" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2011-07-13  9:25 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-09  6:20 [PATCH 0/3] Add missing commas Joe Perches
2011-07-09  6:20 ` [PATCH 1/3] benet: Add missing comma between constant string array Joe Perches
2011-07-09  9:57   ` David Miller
2011-07-09  6:20 ` [PATCH 2/3] iwlegacy: " Joe Perches
2011-07-11 18:35   ` John W. Linville
2011-07-13  9:25     ` Stanislaw Gruszka [this message]
2011-07-09  6:20 ` [PATCH 3/3] iwlagn: " Joe Perches
2011-07-11 13:42   ` Guy, Wey-Yi
2011-07-11 18:35   ` John W. Linville

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110713092538.GA2429@redhat.com \
    --to=sgruszka@redhat.com \
    --cc=joe@perches.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=linville@tuxdriver.com \
    --cc=netdev@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.