* [Buildroot] [PATCH] pcsc-lite and ccid support
@ 2011-07-12 10:10 ruckuus at gmail.com
2011-07-12 15:38 ` Thomas Petazzoni
0 siblings, 1 reply; 13+ messages in thread
From: ruckuus at gmail.com @ 2011-07-12 10:10 UTC (permalink / raw)
To: buildroot
From: Dwi Sasongko S <ruckuus@gmail.com>
This is support for a generic usb smartcard reader.
See the project page:
http://pcsclite.alioth.debian.org/
List of supported hardware:
http://pcsclite.alioth.debian.org/ccid/section.html
Signed-off-by: Dwi Sasongko S <ruckuus@gmail.com>
---
package/Config.in | 2 ++
package/ccid/Config.in | 15 +++++++++++++++
package/ccid/ccid.mk | 13 +++++++++++++
package/pcsc-lite/Config.in | 8 ++++++++
package/pcsc-lite/pcsc-lite.mk | 13 +++++++++++++
5 files changed, 51 insertions(+), 0 deletions(-)
create mode 100644 package/ccid/Config.in
create mode 100644 package/ccid/ccid.mk
create mode 100644 package/pcsc-lite/Config.in
create mode 100644 package/pcsc-lite/pcsc-lite.mk
diff --git a/package/Config.in b/package/Config.in
index 09aa76a..db82d95 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -303,6 +303,7 @@ source "package/libiqrf/Config.in"
source "package/libusb/Config.in"
source "package/libusb-compat/Config.in"
source "package/python-serial/Config.in"
+source "package/pcsc-lite/Config.in"
endmenu
if BROKEN
@@ -342,6 +343,7 @@ source "package/libnspr/Config.in"
source "package/liboil/Config.in"
source "package/libsigc/Config.in"
source "package/startup-notification/Config.in"
+source "package/ccid/Config.in"
endmenu
menu "Text and terminal handling"
diff --git a/package/ccid/Config.in b/package/ccid/Config.in
new file mode 100644
index 0000000..35bec37
--- /dev/null
+++ b/package/ccid/Config.in
@@ -0,0 +1,15 @@
+config BR2_PACKAGE_CCID
+ bool "ccid"
+ select BR2_PACKAGE_PKG_CONFIG
+ select BR2_PACKAGE_LIBUSB
+ select BR2_PACKAGE_PCSC_LITE
+ help
+ This package provides the source code for a generic USB CCID
+ (Chip/Smart Card Interface Device) driver and ICCD (Integrated Circuit(s) Card Devices)
+
+ For more information, please visit the project page:
+ http://pcsclite.alioth.debian.org/ccid.html
+
+ List of supported hardware:
+ http://pcsclite.alioth.debian.org/ccid/section.html
+
diff --git a/package/ccid/ccid.mk b/package/ccid/ccid.mk
new file mode 100644
index 0000000..3263ccd
--- /dev/null
+++ b/package/ccid/ccid.mk
@@ -0,0 +1,13 @@
+##########################################################
+#
+# CCID
+#
+# ########################################################
+CCID_VERSION = 1.4.4
+CCID_SOURCE = ccid-$(CCID_VERSION).tar.bz2
+CCID_SITE = https://alioth.debian.org/frs/download.php/3579
+CCID_INSTALL_STAGING = YES
+CCID_INSTALL_TARGET = YES
+CCID_DEPENDENCIES = pkg-config libusb pcsc-lite
+
+$(eval $(call AUTOTARGETS, package, ccid))
diff --git a/package/pcsc-lite/Config.in b/package/pcsc-lite/Config.in
new file mode 100644
index 0000000..55ac6d3
--- /dev/null
+++ b/package/pcsc-lite/Config.in
@@ -0,0 +1,8 @@
+config BR2_PACKAGE_PCSC_LITE
+ bool "pcsc-lite"
+ select BR2_PACKAGE_LIBUSB
+ help
+ Middleware to access a smart card using SCard API (PC/SC).
+ For more information, please visit:
+ http://pcsclite.alioth.debian.org/pcsclite.html
+
diff --git a/package/pcsc-lite/pcsc-lite.mk b/package/pcsc-lite/pcsc-lite.mk
new file mode 100644
index 0000000..2fdda5f
--- /dev/null
+++ b/package/pcsc-lite/pcsc-lite.mk
@@ -0,0 +1,13 @@
+##########################################################
+#
+# PCSC-Lite
+#
+# ########################################################
+PCSC_LITE_VERSION = 1.7.4
+PCSC_LITE_SOURCE = pcsc-lite-$(PCSC_LITE_VERSION).tar.bz2
+PCSC_LITE_SITE = https://alioth.debian.org/frs/download.php/3598
+PCSC_LITE_INSTALL_STAGING = YES
+PCSC_LITE_INSTALL_TARGET = YES
+PCSC_LITE_CONF_OPT = --disable-libudev --enable-libusb --enable-embedded
+
+$(eval $(call AUTOTARGETS, package, pcsc-lite))
--
1.7.0.4
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [Buildroot] [PATCH] pcsc-lite and ccid support
2011-07-12 10:10 [Buildroot] [PATCH] pcsc-lite and ccid support ruckuus at gmail.com
@ 2011-07-12 15:38 ` Thomas Petazzoni
2011-07-12 17:07 ` Dwi Sasongko Supriyadi
0 siblings, 1 reply; 13+ messages in thread
From: Thomas Petazzoni @ 2011-07-12 15:38 UTC (permalink / raw)
To: buildroot
Le Tue, 12 Jul 2011 17:10:37 +0700,
ruckuus at gmail.com a ?crit :
> +config BR2_PACKAGE_CCID
> + bool "ccid"
> + select BR2_PACKAGE_PKG_CONFIG
No, I don't think you need pkg-config on the target.
> +CCID_DEPENDENCIES = pkg-config libusb pcsc-lite
Are you really sure you need pkg-config on the target ? Usually,
pkg-config is needed in the host. In this case, add "host-pkg-config"
to the DEPENDENCIES variable, and do not "select" anything related to
BR2_PACKAGE_PKG_CONFIG in the Config.in file.
> +$(eval $(call AUTOTARGETS, package, ccid))
No space after the commas:
$(eval $(call AUTOTARGETS,package,ccid))
> diff --git a/package/pcsc-lite/Config.in b/package/pcsc-lite/Config.in
> new file mode 100644
> index 0000000..55ac6d3
> --- /dev/null
> +++ b/package/pcsc-lite/Config.in
> @@ -0,0 +1,8 @@
> +config BR2_PACKAGE_PCSC_LITE
> + bool "pcsc-lite"
> + select BR2_PACKAGE_LIBUSB
> + help
> + Middleware to access a smart card using SCard API (PC/SC).
> + For more information, please visit:
> + http://pcsclite.alioth.debian.org/pcsclite.html
> +
> diff --git a/package/pcsc-lite/pcsc-lite.mk b/package/pcsc-lite/pcsc-lite.mk
> new file mode 100644
> index 0000000..2fdda5f
> --- /dev/null
> +++ b/package/pcsc-lite/pcsc-lite.mk
> @@ -0,0 +1,13 @@
> +##########################################################
> +#
> +# PCSC-Lite
> +#
> +# ########################################################
> +PCSC_LITE_VERSION = 1.7.4
> +PCSC_LITE_SOURCE = pcsc-lite-$(PCSC_LITE_VERSION).tar.bz2
> +PCSC_LITE_SITE = https://alioth.debian.org/frs/download.php/3598
> +PCSC_LITE_INSTALL_STAGING = YES
> +PCSC_LITE_INSTALL_TARGET = YES
> +PCSC_LITE_CONF_OPT = --disable-libudev --enable-libusb --enable-embedded
According to your Config.in, this package depends on LIBUSB. If it is
indeed the case, then libusb should be in the DEPENDENCIES variable of
this package.
> +$(eval $(call AUTOTARGETS, package, pcsc-lite))
No spaces after commas.
$(eval $(call AUTOTARGETS,package,pcsc-lite))
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Buildroot] [PATCH] pcsc-lite and ccid support
2011-07-12 15:38 ` Thomas Petazzoni
@ 2011-07-12 17:07 ` Dwi Sasongko Supriyadi
2011-07-13 7:38 ` Dwi Sasongko Supriyadi
0 siblings, 1 reply; 13+ messages in thread
From: Dwi Sasongko Supriyadi @ 2011-07-12 17:07 UTC (permalink / raw)
To: buildroot
On Tue, Jul 12, 2011 at 10:38 PM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Le Tue, 12 Jul 2011 17:10:37 +0700,
> ruckuus at gmail.com a ?crit :
>
>> +config BR2_PACKAGE_CCID
>> + ? ? bool "ccid"
>> + ? ? select BR2_PACKAGE_PKG_CONFIG
>
> No, I don't think you need pkg-config on the target.
>
>> +CCID_DEPENDENCIES = pkg-config libusb pcsc-lite
>
> Are you really sure you need pkg-config on the target ? Usually,
> pkg-config is needed in the host. In this case, add "host-pkg-config"
> to the DEPENDENCIES variable, and do not "select" anything related to
> BR2_PACKAGE_PKG_CONFIG in the Config.in file.
>
Ok. Actually no need pkg-config on the target, you are right, I need
host-pkg-config instead.
>> +$(eval $(call AUTOTARGETS, package, ccid))
>
> No space after the commas:
>
> $(eval $(call AUTOTARGETS,package,ccid))
>
>> diff --git a/package/pcsc-lite/Config.in b/package/pcsc-lite/Config.in
>> new file mode 100644
>> index 0000000..55ac6d3
>> --- /dev/null
>> +++ b/package/pcsc-lite/Config.in
>> @@ -0,0 +1,8 @@
>> +config BR2_PACKAGE_PCSC_LITE
>> + ? ? bool "pcsc-lite"
>> + ? ? select BR2_PACKAGE_LIBUSB
>> + ? ? help
>> + ? ? ? Middleware to access a smart card using SCard API (PC/SC).
>> + ? ? ? For more information, please visit:
>> + ? ? ? http://pcsclite.alioth.debian.org/pcsclite.html
>> +
>> diff --git a/package/pcsc-lite/pcsc-lite.mk b/package/pcsc-lite/pcsc-lite.mk
>> new file mode 100644
>> index 0000000..2fdda5f
>> --- /dev/null
>> +++ b/package/pcsc-lite/pcsc-lite.mk
>> @@ -0,0 +1,13 @@
>> +##########################################################
>> +#
>> +# PCSC-Lite
>> +#
>> +# ########################################################
>> +PCSC_LITE_VERSION = 1.7.4
>> +PCSC_LITE_SOURCE = pcsc-lite-$(PCSC_LITE_VERSION).tar.bz2
>> +PCSC_LITE_SITE = https://alioth.debian.org/frs/download.php/3598
>> +PCSC_LITE_INSTALL_STAGING = YES
>> +PCSC_LITE_INSTALL_TARGET = YES
>> +PCSC_LITE_CONF_OPT = --disable-libudev --enable-libusb --enable-embedded
>
> According to your Config.in, this package depends on LIBUSB. If it is
> indeed the case, then libusb should be in the DEPENDENCIES variable of
> this package.
>
Yes, I forgot this. Now it is corrected.
>> +$(eval $(call AUTOTARGETS, package, pcsc-lite))
>
> No spaces after commas.
>
> $(eval $(call AUTOTARGETS,package,pcsc-lite))
>
Thanks for your patience reviewing my patch.
The updated version is already submitted.
Best regards,
--
Dwi Sasongko S
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Buildroot] [PATCH] pcsc-lite and ccid support
2011-07-12 17:07 ` Dwi Sasongko Supriyadi
@ 2011-07-13 7:38 ` Dwi Sasongko Supriyadi
2011-07-13 8:29 ` Thomas Petazzoni
0 siblings, 1 reply; 13+ messages in thread
From: Dwi Sasongko Supriyadi @ 2011-07-13 7:38 UTC (permalink / raw)
To: buildroot
Hello Thomas,
On Wed, Jul 13, 2011 at 12:07 AM, Dwi Sasongko Supriyadi
<ruckuus@gmail.com> wrote:
> On Tue, Jul 12, 2011 at 10:38 PM, Thomas Petazzoni
> <thomas.petazzoni@free-electrons.com> wrote:
>> Le Tue, 12 Jul 2011 17:10:37 +0700,
>> ruckuus at gmail.com a ?crit :
>>
>>> +config BR2_PACKAGE_CCID
>>> + ? ? bool "ccid"
>>> + ? ? select BR2_PACKAGE_PKG_CONFIG
>>
>> No, I don't think you need pkg-config on the target.
>>
>>> +CCID_DEPENDENCIES = pkg-config libusb pcsc-lite
>>
>> Are you really sure you need pkg-config on the target ? Usually,
>> pkg-config is needed in the host. In this case, add "host-pkg-config"
>> to the DEPENDENCIES variable, and do not "select" anything related to
>> BR2_PACKAGE_PKG_CONFIG in the Config.in file.
>>
>
> Ok. Actually no need pkg-config on the target, you are right, I need
> host-pkg-config instead.
>
>>> +$(eval $(call AUTOTARGETS, package, ccid))
>>
>> No space after the commas:
>>
>> $(eval $(call AUTOTARGETS,package,ccid))
>>
>>> diff --git a/package/pcsc-lite/Config.in b/package/pcsc-lite/Config.in
>>> new file mode 100644
>>> index 0000000..55ac6d3
>>> --- /dev/null
>>> +++ b/package/pcsc-lite/Config.in
>>> @@ -0,0 +1,8 @@
>>> +config BR2_PACKAGE_PCSC_LITE
>>> + ? ? bool "pcsc-lite"
>>> + ? ? select BR2_PACKAGE_LIBUSB
>>> + ? ? help
>>> + ? ? ? Middleware to access a smart card using SCard API (PC/SC).
>>> + ? ? ? For more information, please visit:
>>> + ? ? ? http://pcsclite.alioth.debian.org/pcsclite.html
>>> +
>>> diff --git a/package/pcsc-lite/pcsc-lite.mk b/package/pcsc-lite/pcsc-lite.mk
>>> new file mode 100644
>>> index 0000000..2fdda5f
>>> --- /dev/null
>>> +++ b/package/pcsc-lite/pcsc-lite.mk
>>> @@ -0,0 +1,13 @@
>>> +##########################################################
>>> +#
>>> +# PCSC-Lite
>>> +#
>>> +# ########################################################
>>> +PCSC_LITE_VERSION = 1.7.4
>>> +PCSC_LITE_SOURCE = pcsc-lite-$(PCSC_LITE_VERSION).tar.bz2
>>> +PCSC_LITE_SITE = https://alioth.debian.org/frs/download.php/3598
>>> +PCSC_LITE_INSTALL_STAGING = YES
>>> +PCSC_LITE_INSTALL_TARGET = YES
>>> +PCSC_LITE_CONF_OPT = --disable-libudev --enable-libusb --enable-embedded
>>
>> According to your Config.in, this package depends on LIBUSB. If it is
>> indeed the case, then libusb should be in the DEPENDENCIES variable of
>> this package.
>>
>
> Yes, I forgot this. Now it is corrected.
>
>>> +$(eval $(call AUTOTARGETS, package, pcsc-lite))
>>
>> No spaces after commas.
>>
>> $(eval $(call AUTOTARGETS,package,pcsc-lite))
>>
>
> Thanks for your patience reviewing my patch.
>
> The updated version is already submitted.
>
Enclosed is the modified version. I have sent the patch previously via
git send-email (yesterday) but there was no response. Please let me
know should I miss anything.
Thanks and regards,
--
Dwi Sasongko S
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Support-for-a-generic-usb-smartcard-reader.patch
Type: text/x-patch
Size: 3937 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20110713/41cbfafd/attachment.bin>
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Buildroot] [PATCH] pcsc-lite and ccid support
2011-07-13 7:38 ` Dwi Sasongko Supriyadi
@ 2011-07-13 8:29 ` Thomas Petazzoni
0 siblings, 0 replies; 13+ messages in thread
From: Thomas Petazzoni @ 2011-07-13 8:29 UTC (permalink / raw)
To: buildroot
Hello,
Le Wed, 13 Jul 2011 14:38:21 +0700,
Dwi Sasongko Supriyadi <ruckuus@gmail.com> a ?crit :
> Enclosed is the modified version. I have sent the patch previously via
> git send-email (yesterday) but there was no response. Please let me
> know should I miss anything.
You didn't miss anything. From a review perspective, the patches look
fine to me.
Now, it's up to Peter, the project maintainer, to merge them when he
finds the time to review/test them.
Regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Buildroot] [PATCH] pcsc-lite and ccid support
@ 2011-07-12 17:04 ruckuus at gmail.com
0 siblings, 0 replies; 13+ messages in thread
From: ruckuus at gmail.com @ 2011-07-12 17:04 UTC (permalink / raw)
To: buildroot
From: Dwi Sasongko S <ruckuus@gmail.com>
This is support for a generic usb smartcard reader.
See the project page:
http://pcsclite.alioth.debian.org/
List of supported hardware:
http://pcsclite.alioth.debian.org/ccid/section.html
Signed-off-by: Dwi Sasongko S <ruckuus@gmail.com>
---
package/Config.in | 2 ++
package/ccid/Config.in | 14 ++++++++++++++
package/ccid/ccid.mk | 13 +++++++++++++
package/pcsc-lite/Config.in | 8 ++++++++
package/pcsc-lite/pcsc-lite.mk | 14 ++++++++++++++
5 files changed, 51 insertions(+), 0 deletions(-)
create mode 100644 package/ccid/Config.in
create mode 100644 package/ccid/ccid.mk
create mode 100644 package/pcsc-lite/Config.in
create mode 100644 package/pcsc-lite/pcsc-lite.mk
diff --git a/package/Config.in b/package/Config.in
index 09aa76a..db82d95 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -303,6 +303,7 @@ source "package/libiqrf/Config.in"
source "package/libusb/Config.in"
source "package/libusb-compat/Config.in"
source "package/python-serial/Config.in"
+source "package/pcsc-lite/Config.in"
endmenu
if BROKEN
@@ -342,6 +343,7 @@ source "package/libnspr/Config.in"
source "package/liboil/Config.in"
source "package/libsigc/Config.in"
source "package/startup-notification/Config.in"
+source "package/ccid/Config.in"
endmenu
menu "Text and terminal handling"
diff --git a/package/ccid/Config.in b/package/ccid/Config.in
new file mode 100644
index 0000000..04b6948
--- /dev/null
+++ b/package/ccid/Config.in
@@ -0,0 +1,14 @@
+config BR2_PACKAGE_CCID
+ bool "ccid"
+ select BR2_PACKAGE_LIBUSB
+ select BR2_PACKAGE_PCSC_LITE
+ help
+ This package provides the source code for a generic USB CCID
+ (Chip/Smart Card Interface Device) driver and ICCD (Integrated Circuit(s) Card Devices)
+
+ For more information, please visit the project page:
+ http://pcsclite.alioth.debian.org/ccid.html
+
+ List of supported hardware:
+ http://pcsclite.alioth.debian.org/ccid/section.html
+
diff --git a/package/ccid/ccid.mk b/package/ccid/ccid.mk
new file mode 100644
index 0000000..ee0f34c
--- /dev/null
+++ b/package/ccid/ccid.mk
@@ -0,0 +1,13 @@
+##########################################################
+#
+# CCID
+#
+# ########################################################
+CCID_VERSION = 1.4.4
+CCID_SOURCE = ccid-$(CCID_VERSION).tar.bz2
+CCID_SITE = https://alioth.debian.org/frs/download.php/3579
+CCID_INSTALL_STAGING = YES
+CCID_INSTALL_TARGET = YES
+CCID_DEPENDENCIES = host-pkg-config libusb pcsc-lite
+
+$(eval $(call AUTOTARGETS,package,ccid))
diff --git a/package/pcsc-lite/Config.in b/package/pcsc-lite/Config.in
new file mode 100644
index 0000000..55ac6d3
--- /dev/null
+++ b/package/pcsc-lite/Config.in
@@ -0,0 +1,8 @@
+config BR2_PACKAGE_PCSC_LITE
+ bool "pcsc-lite"
+ select BR2_PACKAGE_LIBUSB
+ help
+ Middleware to access a smart card using SCard API (PC/SC).
+ For more information, please visit:
+ http://pcsclite.alioth.debian.org/pcsclite.html
+
diff --git a/package/pcsc-lite/pcsc-lite.mk b/package/pcsc-lite/pcsc-lite.mk
new file mode 100644
index 0000000..92314ea
--- /dev/null
+++ b/package/pcsc-lite/pcsc-lite.mk
@@ -0,0 +1,14 @@
+##########################################################
+#
+# PCSC-Lite
+#
+# ########################################################
+PCSC_LITE_VERSION = 1.7.4
+PCSC_LITE_SOURCE = pcsc-lite-$(PCSC_LITE_VERSION).tar.bz2
+PCSC_LITE_SITE = https://alioth.debian.org/frs/download.php/3598
+PCSC_LITE_INSTALL_STAGING = YES
+PCSC_LITE_INSTALL_TARGET = YES
+PCSC_LITE_DEPENDENCIES = libusb
+PCSC_LITE_CONF_OPT = --disable-libudev --enable-libusb --enable-embedded
+
+$(eval $(call AUTOTARGETS,package,pcsc-lite))
--
1.7.0.4
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [Buildroot] [PATCH] pcsc-lite and ccid support
@ 2011-07-12 6:28 ruckuus at gmail.com
2011-07-12 6:43 ` Thomas Petazzoni
0 siblings, 1 reply; 13+ messages in thread
From: ruckuus at gmail.com @ 2011-07-12 6:28 UTC (permalink / raw)
To: buildroot
From: Dwi Sasongko S <ruckuus@gmail.com>
Support for accessing USB smart card reader.
http://pcsclite.alioth.debian.org/
Signed-off-by: Dwi Sasongko S <ruckuus@gmail.com>
---
package/Config.in | 2 ++
package/ccid/Config.in | 6 ++++++
package/ccid/ccid.mk | 13 +++++++++++++
package/pcsc-lite/Config.in | 6 ++++++
package/pcsc-lite/pcsc-lite.mk | 14 ++++++++++++++
5 files changed, 41 insertions(+), 0 deletions(-)
create mode 100644 package/ccid/Config.in
create mode 100644 package/ccid/ccid.mk
create mode 100644 package/pcsc-lite/Config.in
create mode 100644 package/pcsc-lite/pcsc-lite.mk
diff --git a/package/Config.in b/package/Config.in
index 09aa76a..db82d95 100644
--- a/package/Config.in
+++ b/package/Config.in
@@ -303,6 +303,7 @@ source "package/libiqrf/Config.in"
source "package/libusb/Config.in"
source "package/libusb-compat/Config.in"
source "package/python-serial/Config.in"
+source "package/pcsc-lite/Config.in"
endmenu
if BROKEN
@@ -342,6 +343,7 @@ source "package/libnspr/Config.in"
source "package/liboil/Config.in"
source "package/libsigc/Config.in"
source "package/startup-notification/Config.in"
+source "package/ccid/Config.in"
endmenu
menu "Text and terminal handling"
diff --git a/package/ccid/Config.in b/package/ccid/Config.in
new file mode 100644
index 0000000..d5ff34e
--- /dev/null
+++ b/package/ccid/Config.in
@@ -0,0 +1,6 @@
+config BR2_PACKAGE_CCID
+ depends on BR2_PACKAGE_PCSC_LITE
+ bool "ccid"
+ help
+ Card reader driver
+
diff --git a/package/ccid/ccid.mk b/package/ccid/ccid.mk
new file mode 100644
index 0000000..2eb2e4d
--- /dev/null
+++ b/package/ccid/ccid.mk
@@ -0,0 +1,13 @@
+##########################################################
+#
+# CCID
+#
+# ########################################################
+CCID_VERSION = 5706
+CCID_SITE = svn://anonscm.debian.org/pcsclite/trunk/Drivers/ccid
+CCID_INSTALL_STAGING = YES
+CCID_INSTALL_TARGET = YES
+CCID_AUTORECONF = YES
+CCID_DEPENDENCIES = pcsc-lite libusb
+
+$(eval $(call AUTOTARGETS, package, ccid))
diff --git a/package/pcsc-lite/Config.in b/package/pcsc-lite/Config.in
new file mode 100644
index 0000000..51e32c8
--- /dev/null
+++ b/package/pcsc-lite/Config.in
@@ -0,0 +1,6 @@
+config BR2_PACKAGE_PCSC_LITE
+ select BR2_PACKAGE_CCID
+ bool "pcsc-lite"
+ help
+ Middleware to be used with PC/SC
+
diff --git a/package/pcsc-lite/pcsc-lite.mk b/package/pcsc-lite/pcsc-lite.mk
new file mode 100644
index 0000000..9457b75
--- /dev/null
+++ b/package/pcsc-lite/pcsc-lite.mk
@@ -0,0 +1,14 @@
+##########################################################
+#
+# PCSC-Lite
+#
+# ########################################################
+PCSC_LITE_VERSION = 5853
+PCSC_LITE_SITE = svn://anonscm.debian.org/pcsclite/trunk/PCSC
+PCSC_LITE_INSTALL_STAGING = YES
+PCSC_LITE_INSTALL_TARGET = YES
+PCSC_LITE_AUTORECONF = YES
+PCSC_LITE_CONF_OPT = --disable-libudev --enable-libusb --enable-embedded
+PCSC_LITE_DEPENDENCIES=libusb
+
+$(eval $(call AUTOTARGETS, package, pcsc-lite))
--
1.7.0.4
^ permalink raw reply related [flat|nested] 13+ messages in thread
* [Buildroot] [PATCH] pcsc-lite and ccid support
2011-07-12 6:28 ruckuus at gmail.com
@ 2011-07-12 6:43 ` Thomas Petazzoni
2011-07-12 7:03 ` Dwi Sasongko Supriyadi
0 siblings, 1 reply; 13+ messages in thread
From: Thomas Petazzoni @ 2011-07-12 6:43 UTC (permalink / raw)
To: buildroot
Hello !
Thanks for those patches. A few comments below.
Le Tue, 12 Jul 2011 13:28:09 +0700,
ruckuus at gmail.com a ?crit :
> --- /dev/null
> +++ b/package/ccid/Config.in
> @@ -0,0 +1,6 @@
> +config BR2_PACKAGE_CCID
> + depends on BR2_PACKAGE_PCSC_LITE
If I understood correctly ccid is a set of programs that depends on
pcsc-lite which is a library ? If this is the case, then you should
turn this into :
select BR2_PACKAGE_PCSC_LITE
This is because we prefer to have automatic selection of required
dependencies.
> + bool "ccid"
> + help
> + Card reader driver
The help message should be intended with one tab + 2 spaces. The
description could also be a little bit more elaborate (which type of
hardware is supported, etc.). And we typically include the URL of the
project. See other packages for examples.
> +##########################################################
> +#
> +# CCID
> +#
> +# ########################################################
> +CCID_VERSION = 5706
> +CCID_SITE = svn://anonscm.debian.org/pcsclite/trunk/Drivers/ccid
The latest ccid release is 1.4.4, dated May 2011, which doesn't seem to
be that old. In general, we prefer using stable releases rather than
SVN versions when possible. Do you have a good reason for choosing a
specific SVN version instead of the latest project release ?
> +CCID_INSTALL_STAGING = YES
> +CCID_INSTALL_TARGET = YES
> +CCID_AUTORECONF = YES
> +CCID_DEPENDENCIES = pcsc-lite libusb
If you depend on libusb here, then the CCID package should also:
select BR2_PACKAGE_LIBUSB
> +$(eval $(call AUTOTARGETS, package, ccid))
> diff --git a/package/pcsc-lite/Config.in b/package/pcsc-lite/Config.in
> new file mode 100644
> index 0000000..51e32c8
> --- /dev/null
> +++ b/package/pcsc-lite/Config.in
> @@ -0,0 +1,6 @@
> +config BR2_PACKAGE_PCSC_LITE
> + select BR2_PACKAGE_CCID
Is it pcsc that depends on ccid, or ccid that depends on pcsc ?
According to your *_DEPENDENCIES variable, it's ccid that depends on
pcsc-lite, so the "select BR2_PACKAGE_CCID" here should go away.
> + bool "pcsc-lite"
> + help
> + Middleware to be used with PC/SC
Same comment as above: indentation is tab + 2 spaces, more elaborate
description, and project URL.
> +##########################################################
> +#
> +# PCSC-Lite
> +#
> +# ########################################################
> +PCSC_LITE_VERSION = 5853
> +PCSC_LITE_SITE = svn://anonscm.debian.org/pcsclite/trunk/PCSC
Same question, SVN version really needed ?
> +PCSC_LITE_INSTALL_STAGING = YES
> +PCSC_LITE_INSTALL_TARGET = YES
> +PCSC_LITE_AUTORECONF = YES
> +PCSC_LITE_CONF_OPT = --disable-libudev --enable-libusb
> --enable-embedded +PCSC_LITE_DEPENDENCIES=libusb
> +
> +$(eval $(call AUTOTARGETS, package, pcsc-lite))
Again, thanks for proposing those two packages!
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Buildroot] [PATCH] pcsc-lite and ccid support
2011-07-12 6:43 ` Thomas Petazzoni
@ 2011-07-12 7:03 ` Dwi Sasongko Supriyadi
2011-07-12 7:17 ` Thomas Petazzoni
0 siblings, 1 reply; 13+ messages in thread
From: Dwi Sasongko Supriyadi @ 2011-07-12 7:03 UTC (permalink / raw)
To: buildroot
Hello again,
Thanks for the comments. My answer interpolated below.
On Tue, Jul 12, 2011 at 1:43 PM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Hello !
>
> Thanks for those patches. A few comments below.
>
> Le Tue, 12 Jul 2011 13:28:09 +0700,
> ruckuus at gmail.com a ?crit :
>
>> --- /dev/null
>> +++ b/package/ccid/Config.in
>> @@ -0,0 +1,6 @@
>> +config BR2_PACKAGE_CCID
>> + ? ? depends on BR2_PACKAGE_PCSC_LITE
>
> If I understood correctly ccid is a set of programs that depends on
> pcsc-lite which is a library ? If this is the case, then you should
> turn this into :
>
> ? ? ? ?select BR2_PACKAGE_PCSC_LITE
>
Understood.
> This is because we prefer to have automatic selection of required
> dependencies.
>
>> + ? ? bool "ccid"
>> + ? ? help
>> + ? ? ? ? ? ? Card reader driver
>
> The help message should be intended with one tab + 2 spaces. The
> description could also be a little bit more elaborate (which type of
> hardware is supported, etc.). And we typically include the URL of the
> project. See other packages for examples.
>
Understood.
>> +##########################################################
>> +#
>> +# CCID
>> +#
>> +# ########################################################
>> +CCID_VERSION = 5706
>> +CCID_SITE = svn://anonscm.debian.org/pcsclite/trunk/Drivers/ccid
>
> The latest ccid release is 1.4.4, dated May 2011, which doesn't seem to
> be that old. In general, we prefer using stable releases rather than
> SVN versions when possible. Do you have a good reason for choosing a
> specific SVN version instead of the latest project release ?
>
It should have been using the latest version.
The reason is somehow fuzzy for me, and I need your advise. The idea
is to keep the changes in .mk file as less as possible when there is
new release, so in above case we only need to change the CCID_VERSION
based on SVN version.
I agree to use the stable release which is in this case will look as follow:
CCID_VERSION = 1.4.4
CCID_SOURCE = ccid-$(CCID_VERSION).tar.bz2
CCID_SITE = https://alioth.debian.org/frs/download.php/3579
Comparing to the previous release: 1.4.3
CCID_VERSION = 1.4.3
CCID_SOURCE = ccid-$(CCID_VERSION).tar.bz2
CCID_SITE = https://alioth.debian.org/frs/download.php/3535
There will be changes in CCID_VERSION and CCID_SITE when upgrading
from 1.4.3 to 1.4.4
Please advise, should this is not reasonable
>> +CCID_INSTALL_STAGING = YES
>> +CCID_INSTALL_TARGET = YES
>> +CCID_AUTORECONF = YES
>> +CCID_DEPENDENCIES = pcsc-lite libusb
>
> If you depend on libusb here, then the CCID package should also:
>
> ? ? ? ?select BR2_PACKAGE_LIBUSB
>
Understood
>> +$(eval $(call AUTOTARGETS, package, ccid))
>> diff --git a/package/pcsc-lite/Config.in b/package/pcsc-lite/Config.in
>> new file mode 100644
>> index 0000000..51e32c8
>> --- /dev/null
>> +++ b/package/pcsc-lite/Config.in
>> @@ -0,0 +1,6 @@
>> +config BR2_PACKAGE_PCSC_LITE
>> + ? ? select BR2_PACKAGE_CCID
>
> Is it pcsc that depends on ccid, or ccid that depends on pcsc ?
> According to your *_DEPENDENCIES variable, it's ccid that depends on
> pcsc-lite, so the "select BR2_PACKAGE_CCID" here should go away.
>
Mmm ... actually CCID depends on PCSC. I will fix that.
>> + ? ? bool "pcsc-lite"
>> + ? ? help
>> + ? ? ? ? ? ? Middleware to be used with PC/SC
>
> Same comment as above: indentation is tab + 2 spaces, more elaborate
> description, and project URL.
>
>> +##########################################################
>> +#
>> +# PCSC-Lite
>> +#
>> +# ########################################################
>> +PCSC_LITE_VERSION = 5853
>> +PCSC_LITE_SITE = svn://anonscm.debian.org/pcsclite/trunk/PCSC
>
> Same question, SVN version really needed ?
>
Actually no. When checking out from SVN it will always get the latest version.
>> +PCSC_LITE_INSTALL_STAGING = YES
>> +PCSC_LITE_INSTALL_TARGET = YES
>> +PCSC_LITE_AUTORECONF = YES
>> +PCSC_LITE_CONF_OPT = --disable-libudev --enable-libusb
>> --enable-embedded +PCSC_LITE_DEPENDENCIES=libusb
>> +
>> +$(eval $(call AUTOTARGETS, package, pcsc-lite))
>
> Again, thanks for proposing those two packages!
>
Many thanks for your comments. This is my first attempt on buildroot,
I will try my best to accomplish it.
Best regards,
DWI
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Buildroot] [PATCH] pcsc-lite and ccid support
2011-07-12 7:03 ` Dwi Sasongko Supriyadi
@ 2011-07-12 7:17 ` Thomas Petazzoni
2011-07-12 10:10 ` Dwi Sasongko Supriyadi
0 siblings, 1 reply; 13+ messages in thread
From: Thomas Petazzoni @ 2011-07-12 7:17 UTC (permalink / raw)
To: buildroot
Hello Dwi,
Le Tue, 12 Jul 2011 14:03:01 +0700,
Dwi Sasongko Supriyadi <ruckuus@gmail.com> a ?crit :
> > The latest ccid release is 1.4.4, dated May 2011, which doesn't
> > seem to be that old. In general, we prefer using stable releases
> > rather than SVN versions when possible. Do you have a good reason
> > for choosing a specific SVN version instead of the latest project
> > release ?
> >
>
> It should have been using the latest version.
>
> The reason is somehow fuzzy for me, and I need your advise. The idea
> is to keep the changes in .mk file as less as possible when there is
> new release, so in above case we only need to change the CCID_VERSION
> based on SVN version.
>
> I agree to use the stable release which is in this case will look as
> follow:
>
> CCID_VERSION = 1.4.4
> CCID_SOURCE = ccid-$(CCID_VERSION).tar.bz2
> CCID_SITE = https://alioth.debian.org/frs/download.php/3579
>
> Comparing to the previous release: 1.4.3
> CCID_VERSION = 1.4.3
> CCID_SOURCE = ccid-$(CCID_VERSION).tar.bz2
> CCID_SITE = https://alioth.debian.org/frs/download.php/3535
>
> There will be changes in CCID_VERSION and CCID_SITE when upgrading
> from 1.4.3 to 1.4.4
>
> Please advise, should this is not reasonable
Well, I think updating two lines (CCID_VERSION and CCID_SITE) is
reasonable when the package version needs to be changed. It would of
course have been better if Alioth did not use this strange (and
stupid?) URL scheme, but that's the way it is.
> >> +CCID_AUTORECONF = YES
Presumably, if you use the tarball versions, the ./configure script and
Makefile.in files will already be available, so this line could be
removed.
> >> +##########################################################
> >> +#
> >> +# PCSC-Lite
> >> +#
> >> +# ########################################################
> >> +PCSC_LITE_VERSION = 5853
> >> +PCSC_LITE_SITE = svn://anonscm.debian.org/pcsclite/trunk/PCSC
> >
> > Same question, SVN version really needed ?
> >
>
> Actually no. When checking out from SVN it will always get the latest
> version.
No, with what you have written, it will always get revision 5853, and
nothing else. It'd be better to use the tarball version here as well.
> >> +PCSC_LITE_AUTORECONF = YES
And remove this line.
> Many thanks for your comments. This is my first attempt on buildroot,
> I will try my best to accomplish it.
And your first attempt is very good! Thanks for contributing!
Regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Buildroot] [PATCH] pcsc-lite and ccid support
2011-07-12 7:17 ` Thomas Petazzoni
@ 2011-07-12 10:10 ` Dwi Sasongko Supriyadi
2011-07-12 11:50 ` Thomas Petazzoni
0 siblings, 1 reply; 13+ messages in thread
From: Dwi Sasongko Supriyadi @ 2011-07-12 10:10 UTC (permalink / raw)
To: buildroot
Hello Thomas,
On Tue, Jul 12, 2011 at 2:17 PM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Hello Dwi,
>
> Le Tue, 12 Jul 2011 14:03:01 +0700,
> Dwi Sasongko Supriyadi <ruckuus@gmail.com> a ?crit :
>
>> > The latest ccid release is 1.4.4, dated May 2011, which doesn't
>> > seem to be that old. In general, we prefer using stable releases
>> > rather than SVN versions when possible. Do you have a good reason
>> > for choosing a specific SVN version instead of the latest project
>> > release ?
>> >
>>
>> It should have been using the latest version.
>>
>> The reason is somehow fuzzy for me, and I need your advise. The idea
>> is to keep the changes in .mk file as less as possible when there is
>> new release, so in above case we only need to change the CCID_VERSION
>> based on SVN version.
>>
>> I agree to use the stable release which is in this case will look as
>> follow:
>>
>> CCID_VERSION = 1.4.4
>> CCID_SOURCE = ccid-$(CCID_VERSION).tar.bz2
>> CCID_SITE = https://alioth.debian.org/frs/download.php/3579
>>
>> Comparing to the previous release: 1.4.3
>> CCID_VERSION = 1.4.3
>> CCID_SOURCE = ccid-$(CCID_VERSION).tar.bz2
>> CCID_SITE = https://alioth.debian.org/frs/download.php/3535
>>
>> There will be changes in CCID_VERSION and CCID_SITE when upgrading
>> from 1.4.3 to 1.4.4
>>
>> Please advise, should this is not reasonable
>
> Well, I think updating two lines (CCID_VERSION and CCID_SITE) is
> reasonable when the package version needs to be changed. It would of
> course have been better if Alioth did not use this strange (and
> stupid?) URL scheme, but that's the way it is.
>
I have modified the url to point to the tarball instead of SVN
>> >> +CCID_AUTORECONF = YES
>
> Presumably, if you use the tarball versions, the ./configure script and
> Makefile.in files will already be available, so this line could be
> removed.
>
Thank you for this info.
>> >> +##########################################################
>> >> +#
>> >> +# PCSC-Lite
>> >> +#
>> >> +# ########################################################
>> >> +PCSC_LITE_VERSION = 5853
>> >> +PCSC_LITE_SITE = svn://anonscm.debian.org/pcsclite/trunk/PCSC
>> >
>> > Same question, SVN version really needed ?
>> >
>>
>> Actually no. When checking out from SVN it will always get the latest
>> version.
>
> No, with what you have written, it will always get revision 5853, and
> nothing else. It'd be better to use the tarball version here as well.
>
Indeed, when saying it will check out the latest version what I mean
is when the version is not specified.
>> >> +PCSC_LITE_AUTORECONF = YES
>
> And remove this line.
>
>> Many thanks for your comments. This is my first attempt on buildroot,
>> I will try my best to accomplish it.
>
> And your first attempt is very good! Thanks for contributing!
>
Thank you.
I have already modified the patch after testing from scratch
(recompile everything) and found out that there are other dependencies
for ccid.
Should I send the patch here or creating another thread?
Thanks in advance,
DWI
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Buildroot] [PATCH] pcsc-lite and ccid support
2011-07-12 10:10 ` Dwi Sasongko Supriyadi
@ 2011-07-12 11:50 ` Thomas Petazzoni
2011-07-12 15:07 ` Dwi Sasongko Supriyadi
0 siblings, 1 reply; 13+ messages in thread
From: Thomas Petazzoni @ 2011-07-12 11:50 UTC (permalink / raw)
To: buildroot
Le Tue, 12 Jul 2011 17:10:01 +0700,
Dwi Sasongko Supriyadi <ruckuus@gmail.com> a ?crit :
> I have already modified the patch after testing from scratch
> (recompile everything) and found out that there are other dependencies
> for ccid.
Ok.
> Should I send the patch here or creating another thread?
Either way is fine.
Regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
^ permalink raw reply [flat|nested] 13+ messages in thread
* [Buildroot] [PATCH] pcsc-lite and ccid support
2011-07-12 11:50 ` Thomas Petazzoni
@ 2011-07-12 15:07 ` Dwi Sasongko Supriyadi
0 siblings, 0 replies; 13+ messages in thread
From: Dwi Sasongko Supriyadi @ 2011-07-12 15:07 UTC (permalink / raw)
To: buildroot
On Tue, Jul 12, 2011 at 6:50 PM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> Le Tue, 12 Jul 2011 17:10:01 +0700,
> Dwi Sasongko Supriyadi <ruckuus@gmail.com> a ?crit :
>
>> I have already modified the patch after testing from scratch
>> (recompile everything) and found out that there are other dependencies
>> for ccid.
>
> Ok.
>
>> Should I send the patch here or creating another thread?
>
> Either way is fine.
Thanks. I have sent the modified version in previous e-mail actually.
Best regards,
DWI
^ permalink raw reply [flat|nested] 13+ messages in thread
end of thread, other threads:[~2011-07-13 8:29 UTC | newest]
Thread overview: 13+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-07-12 10:10 [Buildroot] [PATCH] pcsc-lite and ccid support ruckuus at gmail.com
2011-07-12 15:38 ` Thomas Petazzoni
2011-07-12 17:07 ` Dwi Sasongko Supriyadi
2011-07-13 7:38 ` Dwi Sasongko Supriyadi
2011-07-13 8:29 ` Thomas Petazzoni
-- strict thread matches above, loose matches on Subject: below --
2011-07-12 17:04 ruckuus at gmail.com
2011-07-12 6:28 ruckuus at gmail.com
2011-07-12 6:43 ` Thomas Petazzoni
2011-07-12 7:03 ` Dwi Sasongko Supriyadi
2011-07-12 7:17 ` Thomas Petazzoni
2011-07-12 10:10 ` Dwi Sasongko Supriyadi
2011-07-12 11:50 ` Thomas Petazzoni
2011-07-12 15:07 ` Dwi Sasongko Supriyadi
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.