Re: [PATCH] minix: v3 super-block does not have s_state field

[Karel Zak <kzak@redhat.com>]

On Wed, Jul 13, 2011 at 01:33:03PM +0200, Sami Kerola wrote:
> On Wed, Jul 13, 2011 at 06:05, Davidlohr Bueso <dave@gnu.org> wrote:
> > I don't think we should always rely on having the kernel headers, that's
> > why the fallback is provided.
> [snip]
> > I think with this patch we address the issue without removing our
> > fallback.
> 
> Hi Dave et.al.
> 
> The preprocessor directive bellow is problematic. I don't see where,
> or how, it might get satisfied so I am afraid the 'fall back' is
> always in use regardless whether an user has kernel headers or not.
> 
> #ifdef KERNEL_INCLUDES_ARE_CLEAN
> 
> To fix that I modified the patch to use autoconf to check whether each
> necessary header is present, and use them if possible. Notice that
> Dave that I wrote your name to Reviewed-by patch line so it would be
> nice to hear that you're OK with the change. See the attachment, or
> pull from my repository.

 This is wrong way... the kernel types (e.g. u32, s64) are
 *unexpected* in util-linux. The new code should not use this junk. We
 have <stdint.h> and <inttypes.h>.
 
 The mkfs.minix should not depend on kernel headers. It's normal that
 we use our own (on kernel independent) copy of FS superbloks. See
 libblkid code.

 There is libblkid/src/superblocks/minix.c where are minix
 superblocks, it would be probably better to move the superblocks to
 iniclude/minix.h and use it everywhere.

    Karel

-- 
 Karel Zak  <kzak@redhat.com>
 http://karelzak.blogspot.com