* [PATCH] tulip: Disable debugging messages by default
@ 2011-07-18 12:40 Jean Delvare
2011-07-18 14:50 ` [PATCH] tulip: dmfe: Remove old log spamming pr_debugs Joe Perches
0 siblings, 1 reply; 5+ messages in thread
From: Jean Delvare @ 2011-07-18 12:40 UTC (permalink / raw)
To: netdev; +Cc: Grant Grundler, Joe Perches
With debugging messages enabled by default, one user complained [1]
that his log was spammed with these messages:
[ 6233.528227] dmfe: tdes0=7fff0000
[ 6237.651056] dmfe: tdes0=7fff0000
[ 6237.651060] dmfe: tdes0=7fff0000
[ 6237.696019] dmfe: tdes0=7fff0000
[ 6237.696022] dmfe: tdes0=7fff0000
[ 6238.028810] dmfe: tdes0=7fff0000
[ 6238.028814] dmfe: tdes0=7fff0000
[ 6238.073544] dmfe: tdes0=7fff0000
[ 6238.073547] dmfe: tdes0=7fff0000
With dynamic debugging available, I think it makes no sense to enable
debugging messages by default, especially for such old drivers which
aren't been actively developed any longer.
[1] http://lists.opensuse.org/opensuse-kernel/2011-07/msg00060.html
Signed-off-by: Jean Delvare <jdelvare@suse.de>
Cc: Grant Grundler <grundler@parisc-linux.org>
Cc: Joe Perches <joe@perches.com>
---
drivers/net/tulip/Makefile | 2 --
1 file changed, 2 deletions(-)
--- a/drivers/net/tulip/Makefile
+++ b/drivers/net/tulip/Makefile
@@ -2,8 +2,6 @@
# Makefile for the Linux "Tulip" family network device drivers.
#
-ccflags-$(CONFIG_NET_TULIP) := -DDEBUG
-
obj-$(CONFIG_PCMCIA_XIRCOM) += xircom_cb.o
obj-$(CONFIG_DM9102) += dmfe.o
obj-$(CONFIG_WINBOND_840) += winbond-840.o
--
Jean Delvare
Suse L3
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] tulip: dmfe: Remove old log spamming pr_debugs
2011-07-18 12:40 [PATCH] tulip: Disable debugging messages by default Jean Delvare
@ 2011-07-18 14:50 ` Joe Perches
2011-07-18 17:45 ` David Miller
0 siblings, 1 reply; 5+ messages in thread
From: Joe Perches @ 2011-07-18 14:50 UTC (permalink / raw)
To: Jean Delvare, Grant Grundler; +Cc: netdev, linux-kernel
Commit 726b65ad444d ("tulip: Convert uses of KERN_DEBUG") enabled
some old previously inactive uses of pr_debug converted by
commit dde7c8ef1679 ("tulip/dmfe.c: Use dev_<level> and pr_<level>").
Remove these pr_debugs.
Signed-off-by: Joe Perches <joe@perches.com>
---
On Mon, 2011-07-18 at 14:40 +0200, Jean Delvare wrote:
With debugging messages enabled by default, one user complained [1]
> that his log was spammed with these messages:
> [ 6233.528227] dmfe: tdes0=7fff0000
I do not mind at all disabling the default
debugging logging from tulip.
It looks as if some pr_debugs could be
removed as these were commented out at one
time and brought back by commit dde7c8ef.
drivers/net/tulip/dmfe.c | 4 ----
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/drivers/net/tulip/dmfe.c b/drivers/net/tulip/dmfe.c
index 4685127..9a21ca3 100644
--- a/drivers/net/tulip/dmfe.c
+++ b/drivers/net/tulip/dmfe.c
@@ -879,7 +879,6 @@ static void dmfe_free_tx_pkt(struct DEVICE *dev, struct dmfe_board_info * db)
txptr = db->tx_remove_ptr;
while(db->tx_packet_cnt) {
tdes0 = le32_to_cpu(txptr->tdes0);
- pr_debug("tdes0=%x\n", tdes0);
if (tdes0 & 0x80000000)
break;
@@ -889,7 +888,6 @@ static void dmfe_free_tx_pkt(struct DEVICE *dev, struct dmfe_board_info * db)
/* Transmit statistic counter */
if ( tdes0 != 0x7fffffff ) {
- pr_debug("tdes0=%x\n", tdes0);
dev->stats.collisions += (tdes0 >> 3) & 0xf;
dev->stats.tx_bytes += le32_to_cpu(txptr->tdes1) & 0x7ff;
if (tdes0 & TDES0_ERR_MASK) {
@@ -986,7 +984,6 @@ static void dmfe_rx_packet(struct DEVICE *dev, struct dmfe_board_info * db)
/* error summary bit check */
if (rdes0 & 0x8000) {
/* This is a error packet */
- pr_debug("rdes0: %x\n", rdes0);
dev->stats.rx_errors++;
if (rdes0 & 1)
dev->stats.rx_fifo_errors++;
@@ -1638,7 +1635,6 @@ static u8 dmfe_sense_speed(struct dmfe_board_info * db)
else /* DM9102/DM9102A */
phy_mode = phy_read(db->ioaddr,
db->phy_addr, 17, db->chip_id) & 0xf000;
- pr_debug("Phy_mode %x\n", phy_mode);
switch (phy_mode) {
case 0x1000: db->op_mode = DMFE_10MHF; break;
case 0x2000: db->op_mode = DMFE_10MFD; break;
--
1.7.6.131.g99019
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] tulip: dmfe: Remove old log spamming pr_debugs
2011-07-18 14:50 ` [PATCH] tulip: dmfe: Remove old log spamming pr_debugs Joe Perches
@ 2011-07-18 17:45 ` David Miller
2011-07-18 18:05 ` Joe Perches
0 siblings, 1 reply; 5+ messages in thread
From: David Miller @ 2011-07-18 17:45 UTC (permalink / raw)
To: joe; +Cc: jdelvare, grundler, netdev, linux-kernel
From: Joe Perches <joe@perches.com>
Date: Mon, 18 Jul 2011 07:50:33 -0700
> Commit 726b65ad444d ("tulip: Convert uses of KERN_DEBUG") enabled
> some old previously inactive uses of pr_debug converted by
> commit dde7c8ef1679 ("tulip/dmfe.c: Use dev_<level> and pr_<level>").
>
> Remove these pr_debugs.
>
> Signed-off-by: Joe Perches <joe@perches.com>
Applied.
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] tulip: dmfe: Remove old log spamming pr_debugs
2011-07-18 17:45 ` David Miller
@ 2011-07-18 18:05 ` Joe Perches
2011-07-18 18:11 ` David Miller
0 siblings, 1 reply; 5+ messages in thread
From: Joe Perches @ 2011-07-18 18:05 UTC (permalink / raw)
To: David Miller; +Cc: jdelvare, grundler, netdev, linux-kernel
On Mon, 2011-07-18 at 10:45 -0700, David Miller wrote:
> From: Joe Perches <joe@perches.com>
> Date: Mon, 18 Jul 2011 07:50:33 -0700
> > Commit 726b65ad444d ("tulip: Convert uses of KERN_DEBUG") enabled
> > some old previously inactive uses of pr_debug converted by
> > commit dde7c8ef1679 ("tulip/dmfe.c: Use dev_<level> and pr_<level>").
> > Remove these pr_debugs.
> > Signed-off-by: Joe Perches <joe@perches.com>
> Applied.
I believe this should go into current if you push
one more to Linus or maybe stable for 3.0.
cheers, Joe
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] tulip: dmfe: Remove old log spamming pr_debugs
2011-07-18 18:05 ` Joe Perches
@ 2011-07-18 18:11 ` David Miller
0 siblings, 0 replies; 5+ messages in thread
From: David Miller @ 2011-07-18 18:11 UTC (permalink / raw)
To: joe; +Cc: jdelvare, grundler, netdev, linux-kernel
From: Joe Perches <joe@perches.com>
Date: Mon, 18 Jul 2011 11:05:32 -0700
> On Mon, 2011-07-18 at 10:45 -0700, David Miller wrote:
>> From: Joe Perches <joe@perches.com>
>> Date: Mon, 18 Jul 2011 07:50:33 -0700
>> > Commit 726b65ad444d ("tulip: Convert uses of KERN_DEBUG") enabled
>> > some old previously inactive uses of pr_debug converted by
>> > commit dde7c8ef1679 ("tulip/dmfe.c: Use dev_<level> and pr_<level>").
>> > Remove these pr_debugs.
>> > Signed-off-by: Joe Perches <joe@perches.com>
>> Applied.
>
> I believe this should go into current if you push
> one more to Linus or maybe stable for 3.0.
I know, that's why I added it to net-2.6
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2011-07-18 18:11 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-07-18 12:40 [PATCH] tulip: Disable debugging messages by default Jean Delvare
2011-07-18 14:50 ` [PATCH] tulip: dmfe: Remove old log spamming pr_debugs Joe Perches
2011-07-18 17:45 ` David Miller
2011-07-18 18:05 ` Joe Perches
2011-07-18 18:11 ` David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.