All of lore.kernel.org
 help / color / mirror / Atom feed
From: Michal Marek <mmarek@suse.cz>
To: "Víctor M. Jáquez L." <vjaquez@igalia.com>
Cc: linux-kernel@vger.kernel.org, linux-kbuild@vger.kernel.org,
	Jianbin Kang <kjbmail@gmail.com>, Sam Ravnborg <sam@ravnborg.org>
Subject: Re: [PATCH] kbuild: incremental tags updating with GNU GLOBAL
Date: Mon, 25 Jul 2011 15:20:40 +0200	[thread overview]
Message-ID: <20110725132040.GE4482@sepie.suse.cz> (raw)
In-Reply-To: <20110711131725.GA26907@lit.local.igalia.com>

On Mon, Jul 11, 2011 at 03:17:25PM +0200, Víctor M. Jáquez L. wrote:
> On Mon, Jul 11, 2011 at 02:17:38PM +0200, Michal Marek wrote:
> > On 11.7.2011 12:26, Víctor Manuel Jáquez Leal wrote:
> > >Instead of generating the tag database each time the target is ran, is better
> > >just update incrementally the database. It will expend less time.
> > >
> > >Signed-off-by: Víctor Manuel Jáquez Leal<vjaquez@igalia.com>
> > >---
> > >  scripts/tags.sh |    6 +++++-
> > >  1 files changed, 5 insertions(+), 1 deletions(-)
> > >
> > >diff --git a/scripts/tags.sh b/scripts/tags.sh
> > >index 75c5d24..6a2fedc 100755
> > >--- a/scripts/tags.sh
> > >+++ b/scripts/tags.sh
> > >@@ -116,7 +116,11 @@ docscope()
> > >
> > >  dogtags()
> > >  {
> > >-	all_sources | gtags -f -
> > >+	if global -p; then
> > >+		global -u
> > >+	else
> > >+		all_sources | gtags -f -
> > >+	fi
> > 
> > Will this handle new source files properly?
> 
> I ran a quick test and yes, it does.

I installed global and tried it myself:
1) The first 'make gtags' run prints a rather confusing message (fixable)
 $ make gtags
   GEN     gtags
   global: GTAGS not found.
 $
2) A second run indexes the _whole_ tree, including everything under
arch/. The point of the tags.sh script is that it indexes only files
relevant to the current architecture. If someone wants to index the
whole tree, they can run global directly.

Michal

  reply	other threads:[~2011-07-25 13:20 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-11 10:26 [PATCH] kbuild: incremental tags updating with GNU GLOBAL Víctor Manuel Jáquez Leal
2011-07-11 12:17 ` Michal Marek
2011-07-11 13:17   ` Víctor M. Jáquez L.
2011-07-25 13:20     ` Michal Marek [this message]
2011-07-25 13:37       ` Víctor M. Jáquez L.

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110725132040.GE4482@sepie.suse.cz \
    --to=mmarek@suse.cz \
    --cc=kjbmail@gmail.com \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sam@ravnborg.org \
    --cc=vjaquez@igalia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.