* [PATCH 0/2] Build fixes related to undefined struct scatterlist
@ 2011-07-26 18:49 ` Rafael J. Wysocki
0 siblings, 0 replies; 18+ messages in thread
From: Rafael J. Wysocki @ 2011-07-26 18:49 UTC (permalink / raw)
To: Linus Torvalds; +Cc: LKML, linux-sh, Greg Kroah-Hartman, linux-usb
Hi,
The following two patches fix build issues caused by undefined struct
scatterlist.
Thanks,
Rafael
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH 0/2] Build fixes related to undefined struct scatterlist
@ 2011-07-26 18:49 ` Rafael J. Wysocki
0 siblings, 0 replies; 18+ messages in thread
From: Rafael J. Wysocki @ 2011-07-26 18:49 UTC (permalink / raw)
To: Linus Torvalds; +Cc: LKML, linux-sh, Greg Kroah-Hartman, linux-usb
Hi,
The following two patches fix build issues caused by undefined struct
scatterlist.
Thanks,
Rafael
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH 1/2] MMC / TMIO: Fix build issue related to struct scatterlist
2011-07-26 18:49 ` Rafael J. Wysocki
@ 2011-07-26 18:50 ` Rafael J. Wysocki
-1 siblings, 0 replies; 18+ messages in thread
From: Rafael J. Wysocki @ 2011-07-26 18:50 UTC (permalink / raw)
To: Linus Torvalds; +Cc: LKML, linux-sh, Greg Kroah-Hartman, linux-usb, linux-mmc
From: Rafael J. Wysocki <rjw@sisk.pl>
Fix build issue caused by undefined struct scatterlist in
drivers/mmc/host/tmio_mmc.c.
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
---
drivers/mmc/host/tmio_mmc.h | 1 +
drivers/usb/renesas_usbhs/fifo.c | 1 +
2 files changed, 2 insertions(+)
Index: linux-2.6/drivers/mmc/host/tmio_mmc.h
=================================--- linux-2.6.orig/drivers/mmc/host/tmio_mmc.h
+++ linux-2.6/drivers/mmc/host/tmio_mmc.h
@@ -21,6 +21,7 @@
#include <linux/mutex.h>
#include <linux/pagemap.h>
#include <linux/spinlock.h>
+#include <linux/scatterlist.h>
/* Definitions for values the CTRL_SDIO_STATUS register can take. */
#define TMIO_SDIO_STAT_IOIRQ 0x0001
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH 1/2] MMC / TMIO: Fix build issue related to struct scatterlist
@ 2011-07-26 18:50 ` Rafael J. Wysocki
0 siblings, 0 replies; 18+ messages in thread
From: Rafael J. Wysocki @ 2011-07-26 18:50 UTC (permalink / raw)
To: Linus Torvalds; +Cc: LKML, linux-sh, Greg Kroah-Hartman, linux-usb, linux-mmc
From: Rafael J. Wysocki <rjw@sisk.pl>
Fix build issue caused by undefined struct scatterlist in
drivers/mmc/host/tmio_mmc.c.
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
---
drivers/mmc/host/tmio_mmc.h | 1 +
drivers/usb/renesas_usbhs/fifo.c | 1 +
2 files changed, 2 insertions(+)
Index: linux-2.6/drivers/mmc/host/tmio_mmc.h
===================================================================
--- linux-2.6.orig/drivers/mmc/host/tmio_mmc.h
+++ linux-2.6/drivers/mmc/host/tmio_mmc.h
@@ -21,6 +21,7 @@
#include <linux/mutex.h>
#include <linux/pagemap.h>
#include <linux/spinlock.h>
+#include <linux/scatterlist.h>
/* Definitions for values the CTRL_SDIO_STATUS register can take. */
#define TMIO_SDIO_STAT_IOIRQ 0x0001
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH 2/2] USB / Renesas: Fix build issue related to struct scatterlist
2011-07-26 18:49 ` Rafael J. Wysocki
@ 2011-07-26 18:51 ` Rafael J. Wysocki
-1 siblings, 0 replies; 18+ messages in thread
From: Rafael J. Wysocki @ 2011-07-26 18:51 UTC (permalink / raw)
To: Linus Torvalds; +Cc: LKML, linux-sh, Greg Kroah-Hartman, linux-usb
From: Rafael J. Wysocki <rjw@sisk.pl>
Fix build issue caused by undefined struct scatterlist in
drivers/usb/renesas_usbhs/fifo.c.
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
---
drivers/usb/renesas_usbhs/fifo.c | 1 +
1 file changed, 1 insertion(+)
Index: linux-2.6/drivers/usb/renesas_usbhs/fifo.c
=================================--- linux-2.6.orig/drivers/usb/renesas_usbhs/fifo.c
+++ linux-2.6/drivers/usb/renesas_usbhs/fifo.c
@@ -16,6 +16,7 @@
*/
#include <linux/delay.h>
#include <linux/io.h>
+#include <linux/scatterlist.h>
#include "./common.h"
#include "./pipe.h"
^ permalink raw reply [flat|nested] 18+ messages in thread
* [PATCH 2/2] USB / Renesas: Fix build issue related to struct scatterlist
@ 2011-07-26 18:51 ` Rafael J. Wysocki
0 siblings, 0 replies; 18+ messages in thread
From: Rafael J. Wysocki @ 2011-07-26 18:51 UTC (permalink / raw)
To: Linus Torvalds; +Cc: LKML, linux-sh, Greg Kroah-Hartman, linux-usb
From: Rafael J. Wysocki <rjw@sisk.pl>
Fix build issue caused by undefined struct scatterlist in
drivers/usb/renesas_usbhs/fifo.c.
Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
---
drivers/usb/renesas_usbhs/fifo.c | 1 +
1 file changed, 1 insertion(+)
Index: linux-2.6/drivers/usb/renesas_usbhs/fifo.c
===================================================================
--- linux-2.6.orig/drivers/usb/renesas_usbhs/fifo.c
+++ linux-2.6/drivers/usb/renesas_usbhs/fifo.c
@@ -16,6 +16,7 @@
*/
#include <linux/delay.h>
#include <linux/io.h>
+#include <linux/scatterlist.h>
#include "./common.h"
#include "./pipe.h"
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 1/2] MMC / TMIO: Fix build issue related to struct
2011-07-26 18:50 ` Rafael J. Wysocki
@ 2011-07-27 20:40 ` Guennadi Liakhovetski
-1 siblings, 0 replies; 18+ messages in thread
From: Guennadi Liakhovetski @ 2011-07-27 20:40 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Linus Torvalds, LKML, linux-sh, Greg Kroah-Hartman, linux-usb,
linux-mmc, Chris Ball
(added MMC maintainer to CC:)
On Tue, 26 Jul 2011, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rjw@sisk.pl>
>
> Fix build issue caused by undefined struct scatterlist in
> drivers/mmc/host/tmio_mmc.c.
>
> Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
A nitpick, if I may: sCatterlist comes before sPinlock in my versions of
most popular alphabets;-) Please, fix (or maybe Chris can fix it himself),
after which:
Acked-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Thanks
Guennadi
> ---
> drivers/mmc/host/tmio_mmc.h | 1 +
> drivers/usb/renesas_usbhs/fifo.c | 1 +
> 2 files changed, 2 insertions(+)
>
> Index: linux-2.6/drivers/mmc/host/tmio_mmc.h
> =================================> --- linux-2.6.orig/drivers/mmc/host/tmio_mmc.h
> +++ linux-2.6/drivers/mmc/host/tmio_mmc.h
> @@ -21,6 +21,7 @@
> #include <linux/mutex.h>
> #include <linux/pagemap.h>
> #include <linux/spinlock.h>
> +#include <linux/scatterlist.h>
>
> /* Definitions for values the CTRL_SDIO_STATUS register can take. */
> #define TMIO_SDIO_STAT_IOIRQ 0x0001
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 1/2] MMC / TMIO: Fix build issue related to struct scatterlist
@ 2011-07-27 20:40 ` Guennadi Liakhovetski
0 siblings, 0 replies; 18+ messages in thread
From: Guennadi Liakhovetski @ 2011-07-27 20:40 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Linus Torvalds, LKML, linux-sh, Greg Kroah-Hartman, linux-usb,
linux-mmc, Chris Ball
(added MMC maintainer to CC:)
On Tue, 26 Jul 2011, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rjw@sisk.pl>
>
> Fix build issue caused by undefined struct scatterlist in
> drivers/mmc/host/tmio_mmc.c.
>
> Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
A nitpick, if I may: sCatterlist comes before sPinlock in my versions of
most popular alphabets;-) Please, fix (or maybe Chris can fix it himself),
after which:
Acked-by: Guennadi Liakhovetski <g.liakhovetski@gmx.de>
Thanks
Guennadi
> ---
> drivers/mmc/host/tmio_mmc.h | 1 +
> drivers/usb/renesas_usbhs/fifo.c | 1 +
> 2 files changed, 2 insertions(+)
>
> Index: linux-2.6/drivers/mmc/host/tmio_mmc.h
> ===================================================================
> --- linux-2.6.orig/drivers/mmc/host/tmio_mmc.h
> +++ linux-2.6/drivers/mmc/host/tmio_mmc.h
> @@ -21,6 +21,7 @@
> #include <linux/mutex.h>
> #include <linux/pagemap.h>
> #include <linux/spinlock.h>
> +#include <linux/scatterlist.h>
>
> /* Definitions for values the CTRL_SDIO_STATUS register can take. */
> #define TMIO_SDIO_STAT_IOIRQ 0x0001
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-usb" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 1/2] MMC / TMIO: Fix build issue related to struct scatterlist
2011-07-26 18:50 ` Rafael J. Wysocki
@ 2011-07-27 21:47 ` Chris Ball
-1 siblings, 0 replies; 18+ messages in thread
From: Chris Ball @ 2011-07-27 21:47 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Linus Torvalds, LKML, linux-sh, Greg Kroah-Hartman, linux-usb, linux-mmc
Hi Rafael,
On Tue, Jul 26 2011, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rjw@sisk.pl>
>
> Fix build issue caused by undefined struct scatterlist in
> drivers/mmc/host/tmio_mmc.c.
>
> Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
> ---
> drivers/mmc/host/tmio_mmc.h | 1 +
> drivers/usb/renesas_usbhs/fifo.c | 1 +
> 2 files changed, 2 insertions(+)
>
> Index: linux-2.6/drivers/mmc/host/tmio_mmc.h
> =================================> --- linux-2.6.orig/drivers/mmc/host/tmio_mmc.h
> +++ linux-2.6/drivers/mmc/host/tmio_mmc.h
> @@ -21,6 +21,7 @@
> #include <linux/mutex.h>
> #include <linux/pagemap.h>
> #include <linux/spinlock.h>
> +#include <linux/scatterlist.h>
>
> /* Definitions for values the CTRL_SDIO_STATUS register can take. */
> #define TMIO_SDIO_STAT_IOIRQ 0x0001
I'm not able to reproduce the build failure here.
drivers/mmc/host/tmio_mmc.c already performs "#include <linux/scatterlist.h>"
itself (and always has done), so I'm confused about why this is necessary.
Do you have a copy of your build log with the error?
Thanks,
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 1/2] MMC / TMIO: Fix build issue related to struct scatterlist
@ 2011-07-27 21:47 ` Chris Ball
0 siblings, 0 replies; 18+ messages in thread
From: Chris Ball @ 2011-07-27 21:47 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Linus Torvalds, LKML, linux-sh, Greg Kroah-Hartman, linux-usb, linux-mmc
Hi Rafael,
On Tue, Jul 26 2011, Rafael J. Wysocki wrote:
> From: Rafael J. Wysocki <rjw@sisk.pl>
>
> Fix build issue caused by undefined struct scatterlist in
> drivers/mmc/host/tmio_mmc.c.
>
> Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
> ---
> drivers/mmc/host/tmio_mmc.h | 1 +
> drivers/usb/renesas_usbhs/fifo.c | 1 +
> 2 files changed, 2 insertions(+)
>
> Index: linux-2.6/drivers/mmc/host/tmio_mmc.h
> ===================================================================
> --- linux-2.6.orig/drivers/mmc/host/tmio_mmc.h
> +++ linux-2.6/drivers/mmc/host/tmio_mmc.h
> @@ -21,6 +21,7 @@
> #include <linux/mutex.h>
> #include <linux/pagemap.h>
> #include <linux/spinlock.h>
> +#include <linux/scatterlist.h>
>
> /* Definitions for values the CTRL_SDIO_STATUS register can take. */
> #define TMIO_SDIO_STAT_IOIRQ 0x0001
I'm not able to reproduce the build failure here.
drivers/mmc/host/tmio_mmc.c already performs "#include <linux/scatterlist.h>"
itself (and always has done), so I'm confused about why this is necessary.
Do you have a copy of your build log with the error?
Thanks,
- Chris.
--
Chris Ball <cjb@laptop.org> <http://printf.net/>
One Laptop Per Child
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 1/2] MMC / TMIO: Fix build issue related to struct scatterlist
2011-07-27 20:40 ` [PATCH 1/2] MMC / TMIO: Fix build issue related to struct scatterlist Guennadi Liakhovetski
@ 2011-07-27 21:56 ` Rafael J. Wysocki
-1 siblings, 0 replies; 18+ messages in thread
From: Rafael J. Wysocki @ 2011-07-27 21:56 UTC (permalink / raw)
To: Guennadi Liakhovetski
Cc: Linus Torvalds, LKML, linux-sh, Greg Kroah-Hartman, linux-usb,
linux-mmc, Chris Ball
On Wednesday, July 27, 2011, Guennadi Liakhovetski wrote:
> (added MMC maintainer to CC:)
>
> On Tue, 26 Jul 2011, Rafael J. Wysocki wrote:
>
> > From: Rafael J. Wysocki <rjw@sisk.pl>
> >
> > Fix build issue caused by undefined struct scatterlist in
> > drivers/mmc/host/tmio_mmc.c.
> >
> > Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
>
> A nitpick, if I may: sCatterlist comes before sPinlock in my versions of
> most popular alphabets;-) Please, fix (or maybe Chris can fix it himself),
I'm not sure what you mean exactly (perhaps it's too late).
Rafael
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 1/2] MMC / TMIO: Fix build issue related to struct scatterlist
@ 2011-07-27 21:56 ` Rafael J. Wysocki
0 siblings, 0 replies; 18+ messages in thread
From: Rafael J. Wysocki @ 2011-07-27 21:56 UTC (permalink / raw)
To: Guennadi Liakhovetski
Cc: Linus Torvalds, LKML, linux-sh, Greg Kroah-Hartman, linux-usb,
linux-mmc, Chris Ball
On Wednesday, July 27, 2011, Guennadi Liakhovetski wrote:
> (added MMC maintainer to CC:)
>
> On Tue, 26 Jul 2011, Rafael J. Wysocki wrote:
>
> > From: Rafael J. Wysocki <rjw@sisk.pl>
> >
> > Fix build issue caused by undefined struct scatterlist in
> > drivers/mmc/host/tmio_mmc.c.
> >
> > Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
>
> A nitpick, if I may: sCatterlist comes before sPinlock in my versions of
> most popular alphabets;-) Please, fix (or maybe Chris can fix it himself),
I'm not sure what you mean exactly (perhaps it's too late).
Rafael
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 1/2] MMC / TMIO: Fix build issue related to struct scatterlist
2011-07-27 21:47 ` Chris Ball
@ 2011-07-27 22:06 ` Rafael J. Wysocki
-1 siblings, 0 replies; 18+ messages in thread
From: Rafael J. Wysocki @ 2011-07-27 22:06 UTC (permalink / raw)
To: Chris Ball
Cc: Linus Torvalds, LKML, linux-sh, Greg Kroah-Hartman, linux-usb, linux-mmc
On Wednesday, July 27, 2011, Chris Ball wrote:
> Hi Rafael,
>
> On Tue, Jul 26 2011, Rafael J. Wysocki wrote:
> > From: Rafael J. Wysocki <rjw@sisk.pl>
> >
> > Fix build issue caused by undefined struct scatterlist in
> > drivers/mmc/host/tmio_mmc.c.
> >
> > Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
> > ---
> > drivers/mmc/host/tmio_mmc.h | 1 +
> > drivers/usb/renesas_usbhs/fifo.c | 1 +
> > 2 files changed, 2 insertions(+)
> >
> > Index: linux-2.6/drivers/mmc/host/tmio_mmc.h
> > =================================> > --- linux-2.6.orig/drivers/mmc/host/tmio_mmc.h
> > +++ linux-2.6/drivers/mmc/host/tmio_mmc.h
> > @@ -21,6 +21,7 @@
> > #include <linux/mutex.h>
> > #include <linux/pagemap.h>
> > #include <linux/spinlock.h>
> > +#include <linux/scatterlist.h>
> >
> > /* Definitions for values the CTRL_SDIO_STATUS register can take. */
> > #define TMIO_SDIO_STAT_IOIRQ 0x0001
>
> I'm not able to reproduce the build failure here.
>
> drivers/mmc/host/tmio_mmc.c already performs "#include <linux/scatterlist.h>"
> itself (and always has done), so I'm confused about why this is necessary.
> Do you have a copy of your build log with the error?
tmio_mmc.h is included by sh_mobile_sdhi.c too and that one doesn't include
scatterlist.h, which causes a build failure to happen, becuase of the
bounce_sg member of struct tmio_mmc_host.
The patch has been merged already anyway.
Thanks,
Rafael
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 1/2] MMC / TMIO: Fix build issue related to struct scatterlist
@ 2011-07-27 22:06 ` Rafael J. Wysocki
0 siblings, 0 replies; 18+ messages in thread
From: Rafael J. Wysocki @ 2011-07-27 22:06 UTC (permalink / raw)
To: Chris Ball
Cc: Linus Torvalds, LKML, linux-sh, Greg Kroah-Hartman, linux-usb, linux-mmc
On Wednesday, July 27, 2011, Chris Ball wrote:
> Hi Rafael,
>
> On Tue, Jul 26 2011, Rafael J. Wysocki wrote:
> > From: Rafael J. Wysocki <rjw@sisk.pl>
> >
> > Fix build issue caused by undefined struct scatterlist in
> > drivers/mmc/host/tmio_mmc.c.
> >
> > Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
> > ---
> > drivers/mmc/host/tmio_mmc.h | 1 +
> > drivers/usb/renesas_usbhs/fifo.c | 1 +
> > 2 files changed, 2 insertions(+)
> >
> > Index: linux-2.6/drivers/mmc/host/tmio_mmc.h
> > ===================================================================
> > --- linux-2.6.orig/drivers/mmc/host/tmio_mmc.h
> > +++ linux-2.6/drivers/mmc/host/tmio_mmc.h
> > @@ -21,6 +21,7 @@
> > #include <linux/mutex.h>
> > #include <linux/pagemap.h>
> > #include <linux/spinlock.h>
> > +#include <linux/scatterlist.h>
> >
> > /* Definitions for values the CTRL_SDIO_STATUS register can take. */
> > #define TMIO_SDIO_STAT_IOIRQ 0x0001
>
> I'm not able to reproduce the build failure here.
>
> drivers/mmc/host/tmio_mmc.c already performs "#include <linux/scatterlist.h>"
> itself (and always has done), so I'm confused about why this is necessary.
> Do you have a copy of your build log with the error?
tmio_mmc.h is included by sh_mobile_sdhi.c too and that one doesn't include
scatterlist.h, which causes a build failure to happen, becuase of the
bounce_sg member of struct tmio_mmc_host.
The patch has been merged already anyway.
Thanks,
Rafael
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 1/2] MMC / TMIO: Fix build issue related to struct
2011-07-27 21:56 ` Rafael J. Wysocki
@ 2011-07-28 20:09 ` Guennadi Liakhovetski
-1 siblings, 0 replies; 18+ messages in thread
From: Guennadi Liakhovetski @ 2011-07-28 20:09 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Linus Torvalds, LKML, linux-sh, Greg Kroah-Hartman, linux-usb,
linux-mmc, Chris Ball
On Wed, 27 Jul 2011, Rafael J. Wysocki wrote:
> On Wednesday, July 27, 2011, Guennadi Liakhovetski wrote:
> > (added MMC maintainer to CC:)
> >
> > On Tue, 26 Jul 2011, Rafael J. Wysocki wrote:
> >
> > > From: Rafael J. Wysocki <rjw@sisk.pl>
> > >
> > > Fix build issue caused by undefined struct scatterlist in
> > > drivers/mmc/host/tmio_mmc.c.
> > >
> > > Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
> >
> > A nitpick, if I may: sCatterlist comes before sPinlock in my versions of
> > most popular alphabets;-) Please, fix (or maybe Chris can fix it himself),
>
> I'm not sure what you mean exactly (perhaps it's too late).
I mean, that the headers are atm sorted alphabetically and should remain
so, therefore you should add the new header one line higher. As for
compile failure or not: I haven't seen any compile failures myself, but
the patch is academically correct, because structs, declared in tmio_mmc.h
embed struct scatterlist, therefore the header has to be included in that
header too.
Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 1/2] MMC / TMIO: Fix build issue related to struct scatterlist
@ 2011-07-28 20:09 ` Guennadi Liakhovetski
0 siblings, 0 replies; 18+ messages in thread
From: Guennadi Liakhovetski @ 2011-07-28 20:09 UTC (permalink / raw)
To: Rafael J. Wysocki
Cc: Linus Torvalds, LKML, linux-sh, Greg Kroah-Hartman, linux-usb,
linux-mmc, Chris Ball
On Wed, 27 Jul 2011, Rafael J. Wysocki wrote:
> On Wednesday, July 27, 2011, Guennadi Liakhovetski wrote:
> > (added MMC maintainer to CC:)
> >
> > On Tue, 26 Jul 2011, Rafael J. Wysocki wrote:
> >
> > > From: Rafael J. Wysocki <rjw@sisk.pl>
> > >
> > > Fix build issue caused by undefined struct scatterlist in
> > > drivers/mmc/host/tmio_mmc.c.
> > >
> > > Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
> >
> > A nitpick, if I may: sCatterlist comes before sPinlock in my versions of
> > most popular alphabets;-) Please, fix (or maybe Chris can fix it himself),
>
> I'm not sure what you mean exactly (perhaps it's too late).
I mean, that the headers are atm sorted alphabetically and should remain
so, therefore you should add the new header one line higher. As for
compile failure or not: I haven't seen any compile failures myself, but
the patch is academically correct, because structs, declared in tmio_mmc.h
embed struct scatterlist, therefore the header has to be included in that
header too.
Thanks
Guennadi
---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 1/2] MMC / TMIO: Fix build issue related to struct scatterlist
2011-07-28 20:09 ` [PATCH 1/2] MMC / TMIO: Fix build issue related to struct scatterlist Guennadi Liakhovetski
@ 2011-07-28 21:07 ` Rafael J. Wysocki
-1 siblings, 0 replies; 18+ messages in thread
From: Rafael J. Wysocki @ 2011-07-28 21:07 UTC (permalink / raw)
To: Guennadi Liakhovetski
Cc: Linus Torvalds, LKML, linux-sh, Greg Kroah-Hartman, linux-usb,
linux-mmc, Chris Ball
On Thursday, July 28, 2011, Guennadi Liakhovetski wrote:
> On Wed, 27 Jul 2011, Rafael J. Wysocki wrote:
>
> > On Wednesday, July 27, 2011, Guennadi Liakhovetski wrote:
> > > (added MMC maintainer to CC:)
> > >
> > > On Tue, 26 Jul 2011, Rafael J. Wysocki wrote:
> > >
> > > > From: Rafael J. Wysocki <rjw@sisk.pl>
> > > >
> > > > Fix build issue caused by undefined struct scatterlist in
> > > > drivers/mmc/host/tmio_mmc.c.
> > > >
> > > > Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
> > >
> > > A nitpick, if I may: sCatterlist comes before sPinlock in my versions of
> > > most popular alphabets;-) Please, fix (or maybe Chris can fix it himself),
> >
> > I'm not sure what you mean exactly (perhaps it's too late).
>
> I mean, that the headers are atm sorted alphabetically and should remain
> so, therefore you should add the new header one line higher.
Ah. Well, as I said the patch had been merged already, so obviously
Linus didn't care. :-)
> As for compile failure or not: I haven't seen any compile failures myself, but
> the patch is academically correct, because structs, declared in tmio_mmc.h
> embed struct scatterlist, therefore the header has to be included in that
> header too.
Exactly. I've seen a real failure, though.
Thanks,
Rafael
^ permalink raw reply [flat|nested] 18+ messages in thread
* Re: [PATCH 1/2] MMC / TMIO: Fix build issue related to struct scatterlist
@ 2011-07-28 21:07 ` Rafael J. Wysocki
0 siblings, 0 replies; 18+ messages in thread
From: Rafael J. Wysocki @ 2011-07-28 21:07 UTC (permalink / raw)
To: Guennadi Liakhovetski
Cc: Linus Torvalds, LKML, linux-sh, Greg Kroah-Hartman, linux-usb,
linux-mmc, Chris Ball
On Thursday, July 28, 2011, Guennadi Liakhovetski wrote:
> On Wed, 27 Jul 2011, Rafael J. Wysocki wrote:
>
> > On Wednesday, July 27, 2011, Guennadi Liakhovetski wrote:
> > > (added MMC maintainer to CC:)
> > >
> > > On Tue, 26 Jul 2011, Rafael J. Wysocki wrote:
> > >
> > > > From: Rafael J. Wysocki <rjw@sisk.pl>
> > > >
> > > > Fix build issue caused by undefined struct scatterlist in
> > > > drivers/mmc/host/tmio_mmc.c.
> > > >
> > > > Signed-off-by: Rafael J. Wysocki <rjw@sisk.pl>
> > >
> > > A nitpick, if I may: sCatterlist comes before sPinlock in my versions of
> > > most popular alphabets;-) Please, fix (or maybe Chris can fix it himself),
> >
> > I'm not sure what you mean exactly (perhaps it's too late).
>
> I mean, that the headers are atm sorted alphabetically and should remain
> so, therefore you should add the new header one line higher.
Ah. Well, as I said the patch had been merged already, so obviously
Linus didn't care. :-)
> As for compile failure or not: I haven't seen any compile failures myself, but
> the patch is academically correct, because structs, declared in tmio_mmc.h
> embed struct scatterlist, therefore the header has to be included in that
> header too.
Exactly. I've seen a real failure, though.
Thanks,
Rafael
^ permalink raw reply [flat|nested] 18+ messages in thread
end of thread, other threads:[~2011-07-28 21:07 UTC | newest]
Thread overview: 18+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-07-26 18:49 [PATCH 0/2] Build fixes related to undefined struct scatterlist Rafael J. Wysocki
2011-07-26 18:49 ` Rafael J. Wysocki
2011-07-26 18:50 ` [PATCH 1/2] MMC / TMIO: Fix build issue related to " Rafael J. Wysocki
2011-07-26 18:50 ` Rafael J. Wysocki
2011-07-27 20:40 ` [PATCH 1/2] MMC / TMIO: Fix build issue related to struct Guennadi Liakhovetski
2011-07-27 20:40 ` [PATCH 1/2] MMC / TMIO: Fix build issue related to struct scatterlist Guennadi Liakhovetski
2011-07-27 21:56 ` Rafael J. Wysocki
2011-07-27 21:56 ` Rafael J. Wysocki
2011-07-28 20:09 ` [PATCH 1/2] MMC / TMIO: Fix build issue related to struct Guennadi Liakhovetski
2011-07-28 20:09 ` [PATCH 1/2] MMC / TMIO: Fix build issue related to struct scatterlist Guennadi Liakhovetski
2011-07-28 21:07 ` Rafael J. Wysocki
2011-07-28 21:07 ` Rafael J. Wysocki
2011-07-27 21:47 ` Chris Ball
2011-07-27 21:47 ` Chris Ball
2011-07-27 22:06 ` Rafael J. Wysocki
2011-07-27 22:06 ` Rafael J. Wysocki
2011-07-26 18:51 ` [PATCH 2/2] USB / Renesas: " Rafael J. Wysocki
2011-07-26 18:51 ` Rafael J. Wysocki
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.