All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] SOUND: Fix txx9aclc.c build
@ 2011-07-28 11:26 ` Ralf Baechle
  0 siblings, 0 replies; 4+ messages in thread
From: Ralf Baechle @ 2011-07-28 11:26 UTC (permalink / raw)
  To: Jaroslav Kysela, Takashi Iwai, Liam Girdwood, Atsushi Nemoto, Mark Brown
  Cc: alsa-devel, linux-kernel, linux-mips

552d1ef6b5a98d7b95959d5b139071e3c90cebf1 [ASoC: core - Optimise and refactor
pcm_new() to pass only rtd] breaks compilation of txx9aclc.c:

  CC [M]  sound/soc/txx9/txx9aclc.o
/home/ralf/src/linux/linux-mips/sound/soc/txx9/txx9aclc.c: In function 'txx9aclc_pcm_new':
/home/ralf/src/linux/linux-mips/sound/soc/txx9/txx9aclc.c:318:3: error: 'card' undeclared (first use in this function)
/home/ralf/src/linux/linux-mips/sound/soc/txx9/txx9aclc.c:318:3: note: each undeclared identifier is reported only once for each function it appears in
make[5]: *** [sound/soc/txx9/txx9aclc.o] Error 1

Fixed by providing a definition for card.

Signed-off-by: Ralf Baechle <ralf@linux-mips.org>

 sound/soc/txx9/txx9aclc.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/sound/soc/txx9/txx9aclc.c b/sound/soc/txx9/txx9aclc.c
index 34aa972..3de99af 100644
--- a/sound/soc/txx9/txx9aclc.c
+++ b/sound/soc/txx9/txx9aclc.c
@@ -290,6 +290,7 @@ static void txx9aclc_pcm_free_dma_buffers(struct snd_pcm *pcm)
 
 static int txx9aclc_pcm_new(struct snd_soc_pcm_runtime *rtd)
 {
+	struct snd_card *card = rtd->card->snd_card;
 	struct snd_soc_dai *dai = rtd->cpu_dai;
 	struct snd_pcm *pcm = rtd->pcm;
 	struct platform_device *pdev = to_platform_device(dai->platform->dev);

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* [PATCH] SOUND: Fix txx9aclc.c build
@ 2011-07-28 11:26 ` Ralf Baechle
  0 siblings, 0 replies; 4+ messages in thread
From: Ralf Baechle @ 2011-07-28 11:26 UTC (permalink / raw)
  To: Jaroslav Kysela, Takashi Iwai, Liam Girdwood, Atsushi Nemoto, Mark Brown
  Cc: linux-mips, alsa-devel, linux-kernel

552d1ef6b5a98d7b95959d5b139071e3c90cebf1 [ASoC: core - Optimise and refactor
pcm_new() to pass only rtd] breaks compilation of txx9aclc.c:

  CC [M]  sound/soc/txx9/txx9aclc.o
/home/ralf/src/linux/linux-mips/sound/soc/txx9/txx9aclc.c: In function 'txx9aclc_pcm_new':
/home/ralf/src/linux/linux-mips/sound/soc/txx9/txx9aclc.c:318:3: error: 'card' undeclared (first use in this function)
/home/ralf/src/linux/linux-mips/sound/soc/txx9/txx9aclc.c:318:3: note: each undeclared identifier is reported only once for each function it appears in
make[5]: *** [sound/soc/txx9/txx9aclc.o] Error 1

Fixed by providing a definition for card.

Signed-off-by: Ralf Baechle <ralf@linux-mips.org>

 sound/soc/txx9/txx9aclc.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/sound/soc/txx9/txx9aclc.c b/sound/soc/txx9/txx9aclc.c
index 34aa972..3de99af 100644
--- a/sound/soc/txx9/txx9aclc.c
+++ b/sound/soc/txx9/txx9aclc.c
@@ -290,6 +290,7 @@ static void txx9aclc_pcm_free_dma_buffers(struct snd_pcm *pcm)
 
 static int txx9aclc_pcm_new(struct snd_soc_pcm_runtime *rtd)
 {
+	struct snd_card *card = rtd->card->snd_card;
 	struct snd_soc_dai *dai = rtd->cpu_dai;
 	struct snd_pcm *pcm = rtd->pcm;
 	struct platform_device *pdev = to_platform_device(dai->platform->dev);

^ permalink raw reply related	[flat|nested] 4+ messages in thread
* Re: [PATCH] SOUND: Fix txx9aclc.c build
  2011-07-28 11:26 ` Ralf Baechle
@ 2011-07-29  5:55   ` Takashi Iwai
  -1 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2011-07-29  5:55 UTC (permalink / raw)
  To: Ralf Baechle
  Cc: Jaroslav Kysela, Liam Girdwood, Atsushi Nemoto, Mark Brown,
	alsa-devel, linux-kernel, linux-mips

At Thu, 28 Jul 2011 12:26:16 +0100,
Ralf Baechle wrote:
> 
> 552d1ef6b5a98d7b95959d5b139071e3c90cebf1 [ASoC: core - Optimise and refactor
> pcm_new() to pass only rtd] breaks compilation of txx9aclc.c:
> 
>   CC [M]  sound/soc/txx9/txx9aclc.o
> /home/ralf/src/linux/linux-mips/sound/soc/txx9/txx9aclc.c: In function 'txx9aclc_pcm_new':
> /home/ralf/src/linux/linux-mips/sound/soc/txx9/txx9aclc.c:318:3: error: 'card' undeclared (first use in this function)
> /home/ralf/src/linux/linux-mips/sound/soc/txx9/txx9aclc.c:318:3: note: each undeclared identifier is reported only once for each function it appears in
> make[5]: *** [sound/soc/txx9/txx9aclc.o] Error 1
> 
> Fixed by providing a definition for card.
> 
> Signed-off-by: Ralf Baechle <ralf@linux-mips.org>

Thanks, I applied now to fix/asoc branch of sound git tree.


Takashi

> 
>  sound/soc/txx9/txx9aclc.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/sound/soc/txx9/txx9aclc.c b/sound/soc/txx9/txx9aclc.c
> index 34aa972..3de99af 100644
> --- a/sound/soc/txx9/txx9aclc.c
> +++ b/sound/soc/txx9/txx9aclc.c
> @@ -290,6 +290,7 @@ static void txx9aclc_pcm_free_dma_buffers(struct snd_pcm *pcm)
>  
>  static int txx9aclc_pcm_new(struct snd_soc_pcm_runtime *rtd)
>  {
> +	struct snd_card *card = rtd->card->snd_card;
>  	struct snd_soc_dai *dai = rtd->cpu_dai;
>  	struct snd_pcm *pcm = rtd->pcm;
>  	struct platform_device *pdev = to_platform_device(dai->platform->dev);
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread
* Re: [PATCH] SOUND: Fix txx9aclc.c build
@ 2011-07-29  5:55   ` Takashi Iwai
  0 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2011-07-29  5:55 UTC (permalink / raw)
  To: Ralf Baechle
  Cc: linux-mips, alsa-devel, Atsushi Nemoto, Mark Brown, linux-kernel,
	Liam Girdwood

At Thu, 28 Jul 2011 12:26:16 +0100,
Ralf Baechle wrote:
> 
> 552d1ef6b5a98d7b95959d5b139071e3c90cebf1 [ASoC: core - Optimise and refactor
> pcm_new() to pass only rtd] breaks compilation of txx9aclc.c:
> 
>   CC [M]  sound/soc/txx9/txx9aclc.o
> /home/ralf/src/linux/linux-mips/sound/soc/txx9/txx9aclc.c: In function 'txx9aclc_pcm_new':
> /home/ralf/src/linux/linux-mips/sound/soc/txx9/txx9aclc.c:318:3: error: 'card' undeclared (first use in this function)
> /home/ralf/src/linux/linux-mips/sound/soc/txx9/txx9aclc.c:318:3: note: each undeclared identifier is reported only once for each function it appears in
> make[5]: *** [sound/soc/txx9/txx9aclc.o] Error 1
> 
> Fixed by providing a definition for card.
> 
> Signed-off-by: Ralf Baechle <ralf@linux-mips.org>

Thanks, I applied now to fix/asoc branch of sound git tree.


Takashi

> 
>  sound/soc/txx9/txx9aclc.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/sound/soc/txx9/txx9aclc.c b/sound/soc/txx9/txx9aclc.c
> index 34aa972..3de99af 100644
> --- a/sound/soc/txx9/txx9aclc.c
> +++ b/sound/soc/txx9/txx9aclc.c
> @@ -290,6 +290,7 @@ static void txx9aclc_pcm_free_dma_buffers(struct snd_pcm *pcm)
>  
>  static int txx9aclc_pcm_new(struct snd_soc_pcm_runtime *rtd)
>  {
> +	struct snd_card *card = rtd->card->snd_card;
>  	struct snd_soc_dai *dai = rtd->cpu_dai;
>  	struct snd_pcm *pcm = rtd->pcm;
>  	struct platform_device *pdev = to_platform_device(dai->platform->dev);
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-07-29  5:55 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-07-28 11:26 [PATCH] SOUND: Fix txx9aclc.c build Ralf Baechle
2011-07-28 11:26 ` Ralf Baechle
2011-07-29  5:55 ` Takashi Iwai
2011-07-29  5:55   ` Takashi Iwai

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.