* [PATCH 1/2] ASIX: Simplify condition in rx_fixup()
@ 2011-07-27 2:44 Marek Vasut
2011-07-27 2:44 ` [PATCH 2/2] ASIX: Use only 11 bits of header for data size Marek Vasut
2011-07-28 5:40 ` [PATCH 1/2] ASIX: Simplify condition in rx_fixup() David Miller
0 siblings, 2 replies; 9+ messages in thread
From: Marek Vasut @ 2011-07-27 2:44 UTC (permalink / raw)
To: linux-kernel; +Cc: netdev, linux-usb, gregkh, Marek Vasut
Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
---
drivers/net/usb/asix.c | 5 ++---
1 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/net/usb/asix.c b/drivers/net/usb/asix.c
index 5250288..d5b62a4 100644
--- a/drivers/net/usb/asix.c
+++ b/drivers/net/usb/asix.c
@@ -314,10 +314,9 @@ static int asix_rx_fixup(struct usbnet *dev, struct sk_buff *skb)
skb_pull(skb, 4);
while (skb->len > 0) {
- if ((short)(header & 0x0000ffff) !=
- ~((short)((header & 0xffff0000) >> 16))) {
+ if ((header & 0xffff) != ((~header >> 16) & 0xffff))
netdev_err(dev->net, "asix_rx_fixup() Bad Header Length\n");
- }
+
/* get the packet length */
size = (u16) (header & 0x0000ffff);
--
1.7.5.3
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [PATCH 2/2] ASIX: Use only 11 bits of header for data size
2011-07-27 2:44 [PATCH 1/2] ASIX: Simplify condition in rx_fixup() Marek Vasut
@ 2011-07-27 2:44 ` Marek Vasut
2011-07-28 5:40 ` David Miller
2011-07-28 5:40 ` [PATCH 1/2] ASIX: Simplify condition in rx_fixup() David Miller
1 sibling, 1 reply; 9+ messages in thread
From: Marek Vasut @ 2011-07-27 2:44 UTC (permalink / raw)
To: linux-kernel; +Cc: netdev, linux-usb, gregkh, Marek Vasut
The AX88772B uses only 11 bits of the header for the actual size. The other bits
are used for something else. This causes dmesg full of messages:
asix_rx_fixup() Bad Header Length
This patch trims the check to only 11 bits. I believe on older chips, the
remaining 5 top bits are unused.
Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
---
drivers/net/usb/asix.c | 4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
NOTE: If possible, can someone test/verify this patch with other ASIX chips ?
NOTE2: If Ack-ed, Greg, can you get this into -stable?
diff --git a/drivers/net/usb/asix.c b/drivers/net/usb/asix.c
index d5b62a4..c5c4b4d 100644
--- a/drivers/net/usb/asix.c
+++ b/drivers/net/usb/asix.c
@@ -314,11 +314,11 @@ static int asix_rx_fixup(struct usbnet *dev, struct sk_buff *skb)
skb_pull(skb, 4);
while (skb->len > 0) {
- if ((header & 0xffff) != ((~header >> 16) & 0xffff))
+ if ((header & 0x07ff) != ((~header >> 16) & 0x07ff))
netdev_err(dev->net, "asix_rx_fixup() Bad Header Length\n");
/* get the packet length */
- size = (u16) (header & 0x0000ffff);
+ size = (u16) (header & 0x000007ff);
if ((skb->len) - ((size + 1) & 0xfffe) == 0) {
u8 alignment = (unsigned long)skb->data & 0x3;
--
1.7.5.3
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH 1/2] ASIX: Simplify condition in rx_fixup()
2011-07-27 2:44 [PATCH 1/2] ASIX: Simplify condition in rx_fixup() Marek Vasut
2011-07-27 2:44 ` [PATCH 2/2] ASIX: Use only 11 bits of header for data size Marek Vasut
@ 2011-07-28 5:40 ` David Miller
1 sibling, 0 replies; 9+ messages in thread
From: David Miller @ 2011-07-28 5:40 UTC (permalink / raw)
To: marek.vasut; +Cc: linux-kernel, netdev, linux-usb, gregkh
From: Marek Vasut <marek.vasut@gmail.com>
Date: Wed, 27 Jul 2011 04:44:46 +0200
> Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 2/2] ASIX: Use only 11 bits of header for data size
2011-07-27 2:44 ` [PATCH 2/2] ASIX: Use only 11 bits of header for data size Marek Vasut
@ 2011-07-28 5:40 ` David Miller
2011-07-28 6:06 ` Marek Vasut
0 siblings, 1 reply; 9+ messages in thread
From: David Miller @ 2011-07-28 5:40 UTC (permalink / raw)
To: marek.vasut; +Cc: linux-kernel, netdev, linux-usb, gregkh
From: Marek Vasut <marek.vasut@gmail.com>
Date: Wed, 27 Jul 2011 04:44:47 +0200
> The AX88772B uses only 11 bits of the header for the actual size. The other bits
> are used for something else. This causes dmesg full of messages:
>
> asix_rx_fixup() Bad Header Length
>
> This patch trims the check to only 11 bits. I believe on older chips, the
> remaining 5 top bits are unused.
>
> Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
Applied.
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 2/2] ASIX: Use only 11 bits of header for data size
@ 2011-07-28 6:06 ` Marek Vasut
0 siblings, 0 replies; 9+ messages in thread
From: Marek Vasut @ 2011-07-28 6:06 UTC (permalink / raw)
To: David Miller; +Cc: linux-kernel, netdev, linux-usb, gregkh
On Thursday, July 28, 2011 07:40:29 AM David Miller wrote:
> From: Marek Vasut <marek.vasut@gmail.com>
> Date: Wed, 27 Jul 2011 04:44:47 +0200
>
> > The AX88772B uses only 11 bits of the header for the actual size. The
> > other bits
> >
> > are used for something else. This causes dmesg full of messages:
> > asix_rx_fixup() Bad Header Length
> >
> > This patch trims the check to only 11 bits. I believe on older chips, the
> > remaining 5 top bits are unused.
> >
> > Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
>
> Applied.
Hi, did you test it ?
I left NOTEs outside the commit message:
NOTE: If possible, can someone test/verify this patch with other ASIX chips ?
NOTE2: If Ack-ed, Greg, can you get this into -stable?
I hope I won't have a horde of angry people at my door soon ;-)
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 2/2] ASIX: Use only 11 bits of header for data size
@ 2011-07-28 6:06 ` Marek Vasut
0 siblings, 0 replies; 9+ messages in thread
From: Marek Vasut @ 2011-07-28 6:06 UTC (permalink / raw)
To: David Miller
Cc: linux-kernel-u79uwXL29TY76Z2rM5mHXA,
netdev-u79uwXL29TY76Z2rM5mHXA, linux-usb-u79uwXL29TY76Z2rM5mHXA,
gregkh-l3A5Bk7waGM
On Thursday, July 28, 2011 07:40:29 AM David Miller wrote:
> From: Marek Vasut <marek.vasut-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> Date: Wed, 27 Jul 2011 04:44:47 +0200
>
> > The AX88772B uses only 11 bits of the header for the actual size. The
> > other bits
> >
> > are used for something else. This causes dmesg full of messages:
> > asix_rx_fixup() Bad Header Length
> >
> > This patch trims the check to only 11 bits. I believe on older chips, the
> > remaining 5 top bits are unused.
> >
> > Signed-off-by: Marek Vasut <marek.vasut-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
>
> Applied.
Hi, did you test it ?
I left NOTEs outside the commit message:
NOTE: If possible, can someone test/verify this patch with other ASIX chips ?
NOTE2: If Ack-ed, Greg, can you get this into -stable?
I hope I won't have a horde of angry people at my door soon ;-)
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 2/2] ASIX: Use only 11 bits of header for data size
2011-07-28 6:06 ` Marek Vasut
(?)
@ 2011-07-28 15:18 ` Greg KH
2011-07-28 16:17 ` Marek Vasut
-1 siblings, 1 reply; 9+ messages in thread
From: Greg KH @ 2011-07-28 15:18 UTC (permalink / raw)
To: Marek Vasut; +Cc: David Miller, linux-kernel, netdev, linux-usb, gregkh
On Thu, Jul 28, 2011 at 08:06:18AM +0200, Marek Vasut wrote:
> On Thursday, July 28, 2011 07:40:29 AM David Miller wrote:
> > From: Marek Vasut <marek.vasut@gmail.com>
> > Date: Wed, 27 Jul 2011 04:44:47 +0200
> >
> > > The AX88772B uses only 11 bits of the header for the actual size. The
> > > other bits
> > >
> > > are used for something else. This causes dmesg full of messages:
> > > asix_rx_fixup() Bad Header Length
> > >
> > > This patch trims the check to only 11 bits. I believe on older chips, the
> > > remaining 5 top bits are unused.
> > >
> > > Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
> >
> > Applied.
>
> Hi, did you test it ?
>
> I left NOTEs outside the commit message:
>
> NOTE: If possible, can someone test/verify this patch with other ASIX chips ?
> NOTE2: If Ack-ed, Greg, can you get this into -stable?
<formletter>
This is not the correct way to submit patches for inclusion in the
stable kernel tree. Please read Documentation/stable_kernel_rules.txt
for how to do this properly.
</formletter>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 2/2] ASIX: Use only 11 bits of header for data size
@ 2011-07-28 16:17 ` Marek Vasut
0 siblings, 0 replies; 9+ messages in thread
From: Marek Vasut @ 2011-07-28 16:17 UTC (permalink / raw)
To: Greg KH; +Cc: David Miller, linux-kernel, netdev, linux-usb, gregkh
On Thursday, July 28, 2011 05:18:06 PM Greg KH wrote:
> On Thu, Jul 28, 2011 at 08:06:18AM +0200, Marek Vasut wrote:
> > On Thursday, July 28, 2011 07:40:29 AM David Miller wrote:
> > > From: Marek Vasut <marek.vasut@gmail.com>
> > > Date: Wed, 27 Jul 2011 04:44:47 +0200
> > >
> > > > The AX88772B uses only 11 bits of the header for the actual size. The
> > > > other bits
> > > >
> > > > are used for something else. This causes dmesg full of messages:
> > > > asix_rx_fixup() Bad Header Length
> > > >
> > > > This patch trims the check to only 11 bits. I believe on older chips,
> > > > the remaining 5 top bits are unused.
> > > >
> > > > Signed-off-by: Marek Vasut <marek.vasut@gmail.com>
> > >
> > > Applied.
> >
> > Hi, did you test it ?
> >
> > I left NOTEs outside the commit message:
> >
> > NOTE: If possible, can someone test/verify this patch with other ASIX
> > chips ? NOTE2: If Ack-ed, Greg, can you get this into -stable?
>
> <formletter>
>
> This is not the correct way to submit patches for inclusion in the
> stable kernel tree. Please read Documentation/stable_kernel_rules.txt
> for how to do this properly.
Yea I know ... I'm just so very tired (read dead). Sorry
>
> </formletter>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 2/2] ASIX: Use only 11 bits of header for data size
@ 2011-07-28 16:17 ` Marek Vasut
0 siblings, 0 replies; 9+ messages in thread
From: Marek Vasut @ 2011-07-28 16:17 UTC (permalink / raw)
To: Greg KH
Cc: David Miller, linux-kernel-u79uwXL29TY76Z2rM5mHXA,
netdev-u79uwXL29TY76Z2rM5mHXA, linux-usb-u79uwXL29TY76Z2rM5mHXA,
gregkh-l3A5Bk7waGM
On Thursday, July 28, 2011 05:18:06 PM Greg KH wrote:
> On Thu, Jul 28, 2011 at 08:06:18AM +0200, Marek Vasut wrote:
> > On Thursday, July 28, 2011 07:40:29 AM David Miller wrote:
> > > From: Marek Vasut <marek.vasut-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> > > Date: Wed, 27 Jul 2011 04:44:47 +0200
> > >
> > > > The AX88772B uses only 11 bits of the header for the actual size. The
> > > > other bits
> > > >
> > > > are used for something else. This causes dmesg full of messages:
> > > > asix_rx_fixup() Bad Header Length
> > > >
> > > > This patch trims the check to only 11 bits. I believe on older chips,
> > > > the remaining 5 top bits are unused.
> > > >
> > > > Signed-off-by: Marek Vasut <marek.vasut-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
> > >
> > > Applied.
> >
> > Hi, did you test it ?
> >
> > I left NOTEs outside the commit message:
> >
> > NOTE: If possible, can someone test/verify this patch with other ASIX
> > chips ? NOTE2: If Ack-ed, Greg, can you get this into -stable?
>
> <formletter>
>
> This is not the correct way to submit patches for inclusion in the
> stable kernel tree. Please read Documentation/stable_kernel_rules.txt
> for how to do this properly.
Yea I know ... I'm just so very tired (read dead). Sorry
>
> </formletter>
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2011-07-28 16:17 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-07-27 2:44 [PATCH 1/2] ASIX: Simplify condition in rx_fixup() Marek Vasut
2011-07-27 2:44 ` [PATCH 2/2] ASIX: Use only 11 bits of header for data size Marek Vasut
2011-07-28 5:40 ` David Miller
2011-07-28 6:06 ` Marek Vasut
2011-07-28 6:06 ` Marek Vasut
2011-07-28 15:18 ` Greg KH
2011-07-28 16:17 ` Marek Vasut
2011-07-28 16:17 ` Marek Vasut
2011-07-28 5:40 ` [PATCH 1/2] ASIX: Simplify condition in rx_fixup() David Miller
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.