All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] cfb_console: fix build breakage
Date: Fri, 29 Jul 2011 21:48:45 +0200	[thread overview]
Message-ID: <20110729194845.10C03166C86F@gemini.denx.de> (raw)
In-Reply-To: <4E32A86D.1010701@mvista.com>

Dear Sergei Shtylyov,

In message <4E32A86D.1010701@mvista.com> you wrote:
> 
> > diff --git a/drivers/video/cfb_console.c b/drivers/video/cfb_console.c
> > index 77e7285..b56197f 100644
> > --- a/drivers/video/cfb_console.c
> > +++ b/drivers/video/cfb_console.c
> > @@ -1494,7 +1494,7 @@ static void *video_logo (void)
> >
> >   	logo_plot (video_fb_address, VIDEO_COLS, 0, 0);
> >
> > -	sprintf (info, " %s",&version_string);
> > +	sprintf (info, " %s", version_string);
> 
>     This wouldn't pass checkpatch.pl -- remove the space before paren.

Yes, you are right.  But this patch is just intended to fix the
compile problem.

Cleanup patches for this file will follow soon :-)

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A dog always bit deepest on the veterinary hand.
                                    - Terry Pratchett, _Wyrd Sisters_

  reply	other threads:[~2011-07-29 19:48 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-29  7:10 [U-Boot] [PATCH] cfb_console: fix build breakage Andreas Bießmann
2011-07-29  9:28 ` Wolfgang Denk
2011-07-29 12:32 ` Sergei Shtylyov
2011-07-29 19:48   ` Wolfgang Denk [this message]
2011-07-29 19:55 ` [U-Boot] [PATCH 0/3] cfb_console.c - coding style cleanup Wolfgang Denk
2011-07-29 19:55   ` [U-Boot] [PATCH 1/3] Cosmetic: reformat drivers/video/cfb_console.c Wolfgang Denk
2011-08-01 13:14     ` Wolfgang Denk
2011-07-29 19:55   ` [U-Boot] [PATCH 2/3] cfb_console.c: drop custom PRINTD() and use debug() instead Wolfgang Denk
2011-08-01 13:15     ` Wolfgang Denk
2011-07-29 19:55   ` [U-Boot] [PATCH 3/3] cfb_console.c: checkpatch cleanup Wolfgang Denk
2011-07-30 14:12     ` Sergei Shtylyov
2011-07-30 22:45       ` Wolfgang Denk
2011-07-30 22:48     ` [U-Boot] [PATCH 3/3 v2] " Wolfgang Denk
2011-08-01 13:17       ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110729194845.10C03166C86F@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.