All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sergei Shtylyov <sshtylyov@mvista.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/3] cfb_console.c: checkpatch cleanup
Date: Sat, 30 Jul 2011 18:12:33 +0400	[thread overview]
Message-ID: <4E341151.8080309@mvista.com> (raw)
In-Reply-To: <1311969329-1109-4-git-send-email-wd@denx.de>

Hello.

On 29-07-2011 23:55, Wolfgang Denk wrote:

> Fix the following:

> ERROR: do not initialise statics to 0 or NULL
> ERROR: do not use assignment in if condition

> Signed-off-by: Wolfgang Denk<wd@denx.de>
> ---
>   drivers/video/cfb_console.c |   16 ++++++++++------
>   1 files changed, 10 insertions(+), 6 deletions(-)

> diff --git a/drivers/video/cfb_console.c b/drivers/video/cfb_console.c
> index d2dd421..6e9143e 100644
> --- a/drivers/video/cfb_console.c
> +++ b/drivers/video/cfb_console.c
[...]
> @@ -1648,7 +1651,8 @@ static int video_init(void)
>   {
>   	unsigned char color8;
>
> -	if ((pGD = video_hw_init()) == NULL)
> +	pGD = video_hw_init()) == ;

    Did you try to compile this? :-)

WBR, Sergei

  reply	other threads:[~2011-07-30 14:12 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-29  7:10 [U-Boot] [PATCH] cfb_console: fix build breakage Andreas Bießmann
2011-07-29  9:28 ` Wolfgang Denk
2011-07-29 12:32 ` Sergei Shtylyov
2011-07-29 19:48   ` Wolfgang Denk
2011-07-29 19:55 ` [U-Boot] [PATCH 0/3] cfb_console.c - coding style cleanup Wolfgang Denk
2011-07-29 19:55   ` [U-Boot] [PATCH 1/3] Cosmetic: reformat drivers/video/cfb_console.c Wolfgang Denk
2011-08-01 13:14     ` Wolfgang Denk
2011-07-29 19:55   ` [U-Boot] [PATCH 2/3] cfb_console.c: drop custom PRINTD() and use debug() instead Wolfgang Denk
2011-08-01 13:15     ` Wolfgang Denk
2011-07-29 19:55   ` [U-Boot] [PATCH 3/3] cfb_console.c: checkpatch cleanup Wolfgang Denk
2011-07-30 14:12     ` Sergei Shtylyov [this message]
2011-07-30 22:45       ` Wolfgang Denk
2011-07-30 22:48     ` [U-Boot] [PATCH 3/3 v2] " Wolfgang Denk
2011-08-01 13:17       ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E341151.8080309@mvista.com \
    --to=sshtylyov@mvista.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.