All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
To: Randy Dunlap <rdunlap@xenotime.net>
Cc: Greg KH <greg@kroah.com>, Stephen Rothwell <sfr@canb.auug.org.au>,
	Dan Magenheimer <dan.magenheimer@oracle.com>,
	driverdevel <devel@driverdev.osuosl.org>,
	linux-next@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>,
	Nitin Gupta <ngupta@vflare.org>
Subject: Re: linux-next: Tree for Aug 4 (zcache)
Date: Thu, 4 Aug 2011 18:54:13 -0300	[thread overview]
Message-ID: <20110804215412.GE2919@nautilus.holoscopio.com> (raw)
In-Reply-To: <20110804145145.4af47989.rdunlap@xenotime.net>

[-- Attachment #1: Type: text/plain, Size: 1167 bytes --]

On Thu, Aug 04, 2011 at 02:51:45PM -0700, Randy Dunlap wrote:
> On Thu, 4 Aug 2011 14:44:41 -0700 Greg KH wrote:
> 
> > On Thu, Aug 04, 2011 at 02:24:37PM -0700, Randy Dunlap wrote:
> > > On Thu, 4 Aug 2011 14:58:34 +1000 Stephen Rothwell wrote:
> > > 
> > > > Hi all,
> > > > 
> > > > Just in case anyone needs reminding:  Please do not add anything destined
> > > > for v3.2 into linux-next included trees until after v3.1-rc1.
> > > 
> > > 
> > > on i386:
> > > 
> > > drivers/built-in.o: In function `zcache_pampd_create':
> > > zcache-main.c:(.text+0x159b8f): undefined reference to `__udivdi3'
> > 
> > Very wierd, what would cause that?
> 
> I don't see what's weird about it.
> 
> Probably one of these divisions:
> 
> 		if (curr_pers_pampd_count >
> 		    (zv_page_count_policy_percent * totalram_pages) / 100)
> 			goto out;
> 
> or
> 
> 			zv_mean_zsize = xv_get_total_size_bytes(cli->xvpool) /
> 						curr_pers_pampd_count;
> 

The second one. xv_get_total_size_bytes returns u64. I am just
compile-testing a fix.

> 
> ---
> ~Randy
> *** Remember to use Documentation/SubmitChecklist when testing your code ***


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Thadeu Lima de Souza Cascardo <cascardo@holoscopio.com>
To: Randy Dunlap <rdunlap@xenotime.net>
Cc: driverdevel <devel@driverdev.osuosl.org>,
	Stephen Rothwell <sfr@canb.auug.org.au>,
	Dan Magenheimer <dan.magenheimer@oracle.com>,
	LKML <linux-kernel@vger.kernel.org>,
	linux-next@vger.kernel.org, Nitin Gupta <ngupta@vflare.org>
Subject: Re: linux-next: Tree for Aug 4 (zcache)
Date: Thu, 4 Aug 2011 18:54:13 -0300	[thread overview]
Message-ID: <20110804215412.GE2919@nautilus.holoscopio.com> (raw)
In-Reply-To: <20110804145145.4af47989.rdunlap@xenotime.net>


[-- Attachment #1.1: Type: text/plain, Size: 1167 bytes --]

On Thu, Aug 04, 2011 at 02:51:45PM -0700, Randy Dunlap wrote:
> On Thu, 4 Aug 2011 14:44:41 -0700 Greg KH wrote:
> 
> > On Thu, Aug 04, 2011 at 02:24:37PM -0700, Randy Dunlap wrote:
> > > On Thu, 4 Aug 2011 14:58:34 +1000 Stephen Rothwell wrote:
> > > 
> > > > Hi all,
> > > > 
> > > > Just in case anyone needs reminding:  Please do not add anything destined
> > > > for v3.2 into linux-next included trees until after v3.1-rc1.
> > > 
> > > 
> > > on i386:
> > > 
> > > drivers/built-in.o: In function `zcache_pampd_create':
> > > zcache-main.c:(.text+0x159b8f): undefined reference to `__udivdi3'
> > 
> > Very wierd, what would cause that?
> 
> I don't see what's weird about it.
> 
> Probably one of these divisions:
> 
> 		if (curr_pers_pampd_count >
> 		    (zv_page_count_policy_percent * totalram_pages) / 100)
> 			goto out;
> 
> or
> 
> 			zv_mean_zsize = xv_get_total_size_bytes(cli->xvpool) /
> 						curr_pers_pampd_count;
> 

The second one. xv_get_total_size_bytes returns u64. I am just
compile-testing a fix.

> 
> ---
> ~Randy
> *** Remember to use Documentation/SubmitChecklist when testing your code ***


[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

[-- Attachment #2: Type: text/plain, Size: 159 bytes --]

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel

  reply	other threads:[~2011-08-04 21:54 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-04  4:58 linux-next: Tree for Aug 4 Stephen Rothwell
2011-08-04 21:24 ` linux-next: Tree for Aug 4 (zcache) Randy Dunlap
2011-08-04 21:44   ` Greg KH
2011-08-04 21:51     ` Randy Dunlap
2011-08-04 21:54       ` Thadeu Lima de Souza Cascardo [this message]
2011-08-04 21:54         ` Thadeu Lima de Souza Cascardo
2011-08-04 22:00       ` [PATCH] zcache: Use div_u64 for 64-bit division Thadeu Lima de Souza Cascardo
2011-08-04 22:17         ` Randy Dunlap
2011-08-04 22:22 ` [PATCH -next] drivers/base/inode.c: let vmstat_text be optional Randy Dunlap
2011-08-04 22:22   ` Randy Dunlap
2011-08-05  2:38   ` Cong Wang
2011-08-05  2:38     ` Cong Wang
2011-08-05  2:38     ` Cong Wang
2011-08-05  5:43     ` Randy Dunlap
2011-08-05  5:43       ` Randy Dunlap
2011-08-05  8:02       ` Cong Wang
2011-08-05  8:02         ` Cong Wang
2011-08-05  8:02         ` Cong Wang
2011-08-23 21:39   ` Andrew Morton
2011-08-23 21:39     ` Andrew Morton
2011-08-24  3:34     ` [Patch] numa: introduce CONFIG_NUMA_SYSFS for drivers/base/node.c Cong Wang
2011-08-25  2:14       ` Randy Dunlap
2011-08-25  2:14         ` Randy Dunlap
2011-08-25  3:31         ` Cong Wang
2011-08-25  3:31           ` Cong Wang
2011-08-25  3:50           ` Randy Dunlap
2011-08-25  3:50             ` Randy Dunlap
2011-08-25  5:04             ` David Rientjes
2011-08-25  5:04               ` David Rientjes
2011-08-25 10:22               ` Cong Wang
2011-08-25 10:22                 ` Cong Wang
2011-08-25 10:22                 ` Cong Wang
2011-08-25 20:57                 ` David Rientjes
2011-08-25 20:57                   ` David Rientjes
2011-08-29  2:29                   ` Cong Wang
2011-08-29  2:29                     ` Cong Wang
2011-08-29  2:29                     ` Cong Wang
2011-08-25  5:55           ` [patch] numa: fix NUMA compile error when sysfs and procfs are disabled David Rientjes
2011-08-25  5:55             ` David Rientjes
2011-08-25 17:17             ` Randy Dunlap
2011-08-25 17:17               ` Randy Dunlap

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110804215412.GE2919@nautilus.holoscopio.com \
    --to=cascardo@holoscopio.com \
    --cc=dan.magenheimer@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=greg@kroah.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=ngupta@vflare.org \
    --cc=rdunlap@xenotime.net \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.