* [PATCH] cpuidle: Consistent spelling of cpuidle_idle_call()
@ 2011-08-04 16:24 ` David Brown
0 siblings, 0 replies; 12+ messages in thread
From: David Brown @ 2011-08-04 16:24 UTC (permalink / raw)
To: linux-arm-kernel
Commit a0bfa1373859e9d11dc92561a8667588803e42d8 mispells
cpuidle_idle_call() on ARM and SH code. Fix this to be consistent.
Cc: Kevin Hilman <khilman@deeprootsystems.com>
Cc: Paul Mundt <lethal@linux-sh.org>
Cc: x86@kernel.org
Cc: Len Brown <len.brown@intel.com>
Signed-off-by: David Brown <davidb@codeaurora.org>
---
The referenced commit breaks compilation on ARM, and appears it would
do so on SH as well.
David
arch/arm/kernel/process.c | 2 +-
arch/sh/kernel/idle.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/kernel/process.c b/arch/arm/kernel/process.c
index d7ee0d4..1a347f4 100644
--- a/arch/arm/kernel/process.c
+++ b/arch/arm/kernel/process.c
@@ -197,7 +197,7 @@ void cpu_idle(void)
cpu_relax();
} else {
stop_critical_timings();
- if (cpuidle_call_idle())
+ if (cpuidle_idle_call())
pm_idle();
start_critical_timings();
/*
diff --git a/arch/sh/kernel/idle.c b/arch/sh/kernel/idle.c
index 3c45de1..32114e0 100644
--- a/arch/sh/kernel/idle.c
+++ b/arch/sh/kernel/idle.c
@@ -101,7 +101,7 @@ void cpu_idle(void)
local_irq_disable();
/* Don't trace irqs off for idle */
stop_critical_timings();
- if (cpuidle_call_idle())
+ if (cpuidle_idle_call())
pm_idle();
/*
* Sanity check to ensure that pm_idle() returns
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH] cpuidle: Consistent spelling of cpuidle_idle_call()
@ 2011-08-04 16:24 ` David Brown
0 siblings, 0 replies; 12+ messages in thread
From: David Brown @ 2011-08-04 16:24 UTC (permalink / raw)
To: Linus Torvalds, Russell King
Cc: David Brown, linux-kernel, linux-arm-msm, linux-arm-kernel,
linux-sh, Kevin Hilman, Paul Mundt, x86, Len Brown
Commit a0bfa1373859e9d11dc92561a8667588803e42d8 mispells
cpuidle_idle_call() on ARM and SH code. Fix this to be consistent.
Cc: Kevin Hilman <khilman@deeprootsystems.com>
Cc: Paul Mundt <lethal@linux-sh.org>
Cc: x86@kernel.org
Cc: Len Brown <len.brown@intel.com>
Signed-off-by: David Brown <davidb@codeaurora.org>
---
The referenced commit breaks compilation on ARM, and appears it would
do so on SH as well.
David
arch/arm/kernel/process.c | 2 +-
arch/sh/kernel/idle.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/kernel/process.c b/arch/arm/kernel/process.c
index d7ee0d4..1a347f4 100644
--- a/arch/arm/kernel/process.c
+++ b/arch/arm/kernel/process.c
@@ -197,7 +197,7 @@ void cpu_idle(void)
cpu_relax();
} else {
stop_critical_timings();
- if (cpuidle_call_idle())
+ if (cpuidle_idle_call())
pm_idle();
start_critical_timings();
/*
diff --git a/arch/sh/kernel/idle.c b/arch/sh/kernel/idle.c
index 3c45de1..32114e0 100644
--- a/arch/sh/kernel/idle.c
+++ b/arch/sh/kernel/idle.c
@@ -101,7 +101,7 @@ void cpu_idle(void)
local_irq_disable();
/* Don't trace irqs off for idle */
stop_critical_timings();
- if (cpuidle_call_idle())
+ if (cpuidle_idle_call())
pm_idle();
/*
* Sanity check to ensure that pm_idle() returns
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [PATCH] cpuidle: Consistent spelling of cpuidle_idle_call()
@ 2011-08-04 16:24 ` David Brown
0 siblings, 0 replies; 12+ messages in thread
From: David Brown @ 2011-08-04 16:24 UTC (permalink / raw)
To: linux-arm-kernel
Commit a0bfa1373859e9d11dc92561a8667588803e42d8 mispells
cpuidle_idle_call() on ARM and SH code. Fix this to be consistent.
Cc: Kevin Hilman <khilman@deeprootsystems.com>
Cc: Paul Mundt <lethal@linux-sh.org>
Cc: x86 at kernel.org
Cc: Len Brown <len.brown@intel.com>
Signed-off-by: David Brown <davidb@codeaurora.org>
---
The referenced commit breaks compilation on ARM, and appears it would
do so on SH as well.
David
arch/arm/kernel/process.c | 2 +-
arch/sh/kernel/idle.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/kernel/process.c b/arch/arm/kernel/process.c
index d7ee0d4..1a347f4 100644
--- a/arch/arm/kernel/process.c
+++ b/arch/arm/kernel/process.c
@@ -197,7 +197,7 @@ void cpu_idle(void)
cpu_relax();
} else {
stop_critical_timings();
- if (cpuidle_call_idle())
+ if (cpuidle_idle_call())
pm_idle();
start_critical_timings();
/*
diff --git a/arch/sh/kernel/idle.c b/arch/sh/kernel/idle.c
index 3c45de1..32114e0 100644
--- a/arch/sh/kernel/idle.c
+++ b/arch/sh/kernel/idle.c
@@ -101,7 +101,7 @@ void cpu_idle(void)
local_irq_disable();
/* Don't trace irqs off for idle */
stop_critical_timings();
- if (cpuidle_call_idle())
+ if (cpuidle_idle_call())
pm_idle();
/*
* Sanity check to ensure that pm_idle() returns
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
^ permalink raw reply related [flat|nested] 12+ messages in thread
* Re: [PATCH] cpuidle: Consistent spelling of cpuidle_idle_call()
2011-08-04 16:24 ` David Brown
(?)
@ 2011-08-04 17:24 ` Stephen Boyd
-1 siblings, 0 replies; 12+ messages in thread
From: Stephen Boyd @ 2011-08-04 17:24 UTC (permalink / raw)
To: linux-arm-kernel
On 08/04/2011 09:24 AM, David Brown wrote:
> Commit a0bfa1373859e9d11dc92561a8667588803e42d8 mispells
> cpuidle_idle_call() on ARM and SH code. Fix this to be consistent.
>
> Cc: Kevin Hilman <khilman@deeprootsystems.com>
> Cc: Paul Mundt <lethal@linux-sh.org>
> Cc: x86@kernel.org
> Cc: Len Brown <len.brown@intel.com>
> Signed-off-by: David Brown <davidb@codeaurora.org>
> ---
> The referenced commit breaks compilation on ARM, and appears it would
> do so on SH as well.
Mark Brown sent this patch[1] months ago when this build breakage was
noticed in linux-next. What happened to that patch? It looks like the
patch that introduced the breakage was pulled from linux-next shortly
after and then reintroduced today.
[1]https://lkml.org/lkml/2011/4/4/109
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] cpuidle: Consistent spelling of cpuidle_idle_call()
@ 2011-08-04 17:24 ` Stephen Boyd
0 siblings, 0 replies; 12+ messages in thread
From: Stephen Boyd @ 2011-08-04 17:24 UTC (permalink / raw)
To: David Brown
Cc: Linus Torvalds, Russell King, linux-kernel, linux-arm-msm,
linux-arm-kernel, linux-sh, Kevin Hilman, Paul Mundt, x86,
Len Brown, Mark Brown
On 08/04/2011 09:24 AM, David Brown wrote:
> Commit a0bfa1373859e9d11dc92561a8667588803e42d8 mispells
> cpuidle_idle_call() on ARM and SH code. Fix this to be consistent.
>
> Cc: Kevin Hilman <khilman@deeprootsystems.com>
> Cc: Paul Mundt <lethal@linux-sh.org>
> Cc: x86@kernel.org
> Cc: Len Brown <len.brown@intel.com>
> Signed-off-by: David Brown <davidb@codeaurora.org>
> ---
> The referenced commit breaks compilation on ARM, and appears it would
> do so on SH as well.
Mark Brown sent this patch[1] months ago when this build breakage was
noticed in linux-next. What happened to that patch? It looks like the
patch that introduced the breakage was pulled from linux-next shortly
after and then reintroduced today.
[1]https://lkml.org/lkml/2011/4/4/109
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH] cpuidle: Consistent spelling of cpuidle_idle_call()
@ 2011-08-04 17:24 ` Stephen Boyd
0 siblings, 0 replies; 12+ messages in thread
From: Stephen Boyd @ 2011-08-04 17:24 UTC (permalink / raw)
To: linux-arm-kernel
On 08/04/2011 09:24 AM, David Brown wrote:
> Commit a0bfa1373859e9d11dc92561a8667588803e42d8 mispells
> cpuidle_idle_call() on ARM and SH code. Fix this to be consistent.
>
> Cc: Kevin Hilman <khilman@deeprootsystems.com>
> Cc: Paul Mundt <lethal@linux-sh.org>
> Cc: x86 at kernel.org
> Cc: Len Brown <len.brown@intel.com>
> Signed-off-by: David Brown <davidb@codeaurora.org>
> ---
> The referenced commit breaks compilation on ARM, and appears it would
> do so on SH as well.
Mark Brown sent this patch[1] months ago when this build breakage was
noticed in linux-next. What happened to that patch? It looks like the
patch that introduced the breakage was pulled from linux-next shortly
after and then reintroduced today.
[1]https://lkml.org/lkml/2011/4/4/109
--
Sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] cpuidle: Consistent spelling of cpuidle_idle_call()
2011-08-04 17:24 ` Stephen Boyd
(?)
@ 2011-08-04 23:47 ` Mark Brown
-1 siblings, 0 replies; 12+ messages in thread
From: Mark Brown @ 2011-08-04 23:47 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Aug 04, 2011 at 10:24:55AM -0700, Stephen Boyd wrote:
> On 08/04/2011 09:24 AM, David Brown wrote:
> > Commit a0bfa1373859e9d11dc92561a8667588803e42d8 mispells
> > cpuidle_idle_call() on ARM and SH code. Fix this to be consistent.
> > The referenced commit breaks compilation on ARM, and appears it would
> > do so on SH as well.
> Mark Brown sent this patch[1] months ago when this build breakage was
> noticed in linux-next. What happened to that patch? It looks like the
> patch that introduced the breakage was pulled from linux-next shortly
> after and then reintroduced today.
Yeah, as far as I remember Stephen applied my patch to -next as Len
didn't respond to it.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] cpuidle: Consistent spelling of cpuidle_idle_call()
@ 2011-08-04 23:47 ` Mark Brown
0 siblings, 0 replies; 12+ messages in thread
From: Mark Brown @ 2011-08-04 23:47 UTC (permalink / raw)
To: Stephen Boyd
Cc: David Brown, Linus Torvalds, Russell King, linux-kernel,
linux-arm-msm, linux-arm-kernel, linux-sh, Kevin Hilman,
Paul Mundt, x86, Len Brown
On Thu, Aug 04, 2011 at 10:24:55AM -0700, Stephen Boyd wrote:
> On 08/04/2011 09:24 AM, David Brown wrote:
> > Commit a0bfa1373859e9d11dc92561a8667588803e42d8 mispells
> > cpuidle_idle_call() on ARM and SH code. Fix this to be consistent.
> > The referenced commit breaks compilation on ARM, and appears it would
> > do so on SH as well.
> Mark Brown sent this patch[1] months ago when this build breakage was
> noticed in linux-next. What happened to that patch? It looks like the
> patch that introduced the breakage was pulled from linux-next shortly
> after and then reintroduced today.
Yeah, as far as I remember Stephen applied my patch to -next as Len
didn't respond to it.
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH] cpuidle: Consistent spelling of cpuidle_idle_call()
@ 2011-08-04 23:47 ` Mark Brown
0 siblings, 0 replies; 12+ messages in thread
From: Mark Brown @ 2011-08-04 23:47 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Aug 04, 2011 at 10:24:55AM -0700, Stephen Boyd wrote:
> On 08/04/2011 09:24 AM, David Brown wrote:
> > Commit a0bfa1373859e9d11dc92561a8667588803e42d8 mispells
> > cpuidle_idle_call() on ARM and SH code. Fix this to be consistent.
> > The referenced commit breaks compilation on ARM, and appears it would
> > do so on SH as well.
> Mark Brown sent this patch[1] months ago when this build breakage was
> noticed in linux-next. What happened to that patch? It looks like the
> patch that introduced the breakage was pulled from linux-next shortly
> after and then reintroduced today.
Yeah, as far as I remember Stephen applied my patch to -next as Len
didn't respond to it.
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] cpuidle: Consistent spelling of cpuidle_idle_call()
2011-08-04 16:24 ` David Brown
(?)
@ 2011-08-05 10:57 ` Sergei Shtylyov
-1 siblings, 0 replies; 12+ messages in thread
From: Sergei Shtylyov @ 2011-08-05 10:57 UTC (permalink / raw)
To: linux-arm-kernel
Hello.
On 04-08-2011 20:24, David Brown wrote:
> Commit a0bfa1373859e9d11dc92561a8667588803e42d8 mispells
Please also specify that commit's summary in parens.
> cpuidle_idle_call() on ARM and SH code. Fix this to be consistent.
> Cc: Kevin Hilman <khilman@deeprootsystems.com>
> Cc: Paul Mundt <lethal@linux-sh.org>
> Cc: x86@kernel.org
> Cc: Len Brown <len.brown@intel.com>
> Signed-off-by: David Brown<davidb@codeaurora.org>
WBR, Sergei
^ permalink raw reply [flat|nested] 12+ messages in thread
* Re: [PATCH] cpuidle: Consistent spelling of cpuidle_idle_call()
@ 2011-08-05 10:57 ` Sergei Shtylyov
0 siblings, 0 replies; 12+ messages in thread
From: Sergei Shtylyov @ 2011-08-05 10:57 UTC (permalink / raw)
To: David Brown
Cc: Linus Torvalds, Russell King, Len Brown, linux-sh, Kevin Hilman,
linux-arm-msm, x86, linux-kernel, Paul Mundt, linux-arm-kernel
Hello.
On 04-08-2011 20:24, David Brown wrote:
> Commit a0bfa1373859e9d11dc92561a8667588803e42d8 mispells
Please also specify that commit's summary in parens.
> cpuidle_idle_call() on ARM and SH code. Fix this to be consistent.
> Cc: Kevin Hilman <khilman@deeprootsystems.com>
> Cc: Paul Mundt <lethal@linux-sh.org>
> Cc: x86@kernel.org
> Cc: Len Brown <len.brown@intel.com>
> Signed-off-by: David Brown<davidb@codeaurora.org>
WBR, Sergei
^ permalink raw reply [flat|nested] 12+ messages in thread
* [PATCH] cpuidle: Consistent spelling of cpuidle_idle_call()
@ 2011-08-05 10:57 ` Sergei Shtylyov
0 siblings, 0 replies; 12+ messages in thread
From: Sergei Shtylyov @ 2011-08-05 10:57 UTC (permalink / raw)
To: linux-arm-kernel
Hello.
On 04-08-2011 20:24, David Brown wrote:
> Commit a0bfa1373859e9d11dc92561a8667588803e42d8 mispells
Please also specify that commit's summary in parens.
> cpuidle_idle_call() on ARM and SH code. Fix this to be consistent.
> Cc: Kevin Hilman <khilman@deeprootsystems.com>
> Cc: Paul Mundt <lethal@linux-sh.org>
> Cc: x86 at kernel.org
> Cc: Len Brown <len.brown@intel.com>
> Signed-off-by: David Brown<davidb@codeaurora.org>
WBR, Sergei
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2011-08-05 10:58 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-08-04 16:24 [PATCH] cpuidle: Consistent spelling of cpuidle_idle_call() David Brown
2011-08-04 16:24 ` David Brown
2011-08-04 16:24 ` David Brown
2011-08-04 17:24 ` Stephen Boyd
2011-08-04 17:24 ` Stephen Boyd
2011-08-04 17:24 ` Stephen Boyd
2011-08-04 23:47 ` Mark Brown
2011-08-04 23:47 ` Mark Brown
2011-08-04 23:47 ` Mark Brown
2011-08-05 10:57 ` Sergei Shtylyov
2011-08-05 10:57 ` Sergei Shtylyov
2011-08-05 10:57 ` Sergei Shtylyov
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.