All of lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Stephen Warren <swarren@nvidia.com>
Cc: Len Brown <len.brown@intel.com>,
	"Mark Brown (broonie@opensource.wolfsonmicro.com)" 
	<broonie@opensource.wolfsonmicro.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: next-200110804 ARM build break (cpuidle_call_idle)
Date: Fri, 5 Aug 2011 09:29:41 +1000	[thread overview]
Message-ID: <20110805092941.136089871cddff926cf1dbb7@canb.auug.org.au> (raw)
In-Reply-To: <74CDBE0F657A3D45AFBB94109FB122FF049EEAB704@HQMAIL01.nvidia.com>

[-- Attachment #1: Type: text/plain, Size: 1353 bytes --]

Hi Stephen,

On Thu, 4 Aug 2011 13:35:59 -0700 Stephen Warren <swarren@nvidia.com> wrote:
>
> With next-20110804, I'm seeing the following on ARM:
> 
> arch/arm/kernel/process.c: In function 'cpu_idle':
> arch/arm/kernel/process.c:200: error: implicit declaration of function 'cpuidle_call_idle'
> 
> This was previously fixed with:
> 
> https://lkml.org/lkml/2011/4/4/109
> 
> Commit 5f8cf82 (cpuidle: stop using pm_idle) converted arches to use
> cpuidle_idle_call() but contained typos on ARM and SH transposing the
> function name into cpuidle_call_idle().
> 
> Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
> 
> (which I think was included directly in linux-next according to that
> email thread)

Yeah, briefly by the looks of things.

> However, commit 5f8cf82 isn't in linux-next any more, but instead,
> a0bfa13 "cpuidle: stop depending on pm_idle" has replaced it, and has
> the same issue.

It was included first on April 4 and removed after I apllied tha bove fix
on April 15.  From April 18 on, it was not in the tree at all.  I don't
know why it has come back :-(

> Applying Mark's previous fix solves the build problem.

Hi Len.  This patch was wrong the first time around ...
-- 
Cheers,
Stephen Rothwell                    sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/

[-- Attachment #2: Type: application/pgp-signature, Size: 490 bytes --]

  parent reply	other threads:[~2011-08-04 23:30 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-04 20:35 next-200110804 ARM build break (cpuidle_call_idle) Stephen Warren
2011-08-04 23:04 ` Stephen Rothwell
2011-08-04 23:29 ` Stephen Rothwell [this message]
2011-08-05  0:52   ` Stephen Rothwell
2011-08-05  2:42     ` Linus Torvalds
2011-08-05  8:21       ` Ingo Molnar
2011-08-05 19:44       ` Brown, Len

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20110805092941.136089871cddff926cf1dbb7@canb.auug.org.au \
    --to=sfr@canb.auug.org.au \
    --cc=broonie@opensource.wolfsonmicro.com \
    --cc=len.brown@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=swarren@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.