* [PATCHv2 obexd] Use 'nice abort' when canceling outgoing OPP transer
@ 2011-08-09 9:41 Radoslaw Jablonski
2011-08-09 10:01 ` Johan Hedberg
0 siblings, 1 reply; 2+ messages in thread
From: Radoslaw Jablonski @ 2011-08-09 9:41 UTC (permalink / raw)
To: linux-bluetooth; +Cc: Radoslaw Jablonski
Previously client was suddenly disconnecting to cancel
outgoing OPP transfer. Now ABORT command will be sent
before disconnecting with server in that scenario.
This change is required to pass TC_CLIENT_OPH_BV_27_I PTS
test case (not mandatory for qualification).
---
gwobex/obex-xfer.c | 8 --------
1 files changed, 0 insertions(+), 8 deletions(-)
diff --git a/gwobex/obex-xfer.c b/gwobex/obex-xfer.c
index 4013687..3a2ada8 100644
--- a/gwobex/obex-xfer.c
+++ b/gwobex/obex-xfer.c
@@ -98,18 +98,10 @@ gboolean gw_obex_xfer_do_abort(struct gw_obex_xfer *xfer) {
xfer->abort = TRUE;
-#ifdef USE_NICE_ABORT
debug("Performing nice abort\n");
if (OBEX_CancelRequest(xfer->ctx->handle, TRUE) != 0)
return FALSE;
return TRUE;
-#else
- debug("Performing abort through disconnection (without ABORT command)\n");
- xfer->ctx->done = TRUE;
- OBEX_CancelRequest(xfer->ctx->handle, FALSE);
- obex_link_error(xfer->ctx);
- return FALSE;
-#endif
}
GwObexXfer *gw_obex_put_async(GwObex *ctx, const char *name, const char *type,
--
1.7.0.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCHv2 obexd] Use 'nice abort' when canceling outgoing OPP transer
2011-08-09 9:41 [PATCHv2 obexd] Use 'nice abort' when canceling outgoing OPP transer Radoslaw Jablonski
@ 2011-08-09 10:01 ` Johan Hedberg
0 siblings, 0 replies; 2+ messages in thread
From: Johan Hedberg @ 2011-08-09 10:01 UTC (permalink / raw)
To: Radoslaw Jablonski; +Cc: linux-bluetooth
Hi Radek,
On Tue, Aug 09, 2011, Radoslaw Jablonski wrote:
> Previously client was suddenly disconnecting to cancel
> outgoing OPP transfer. Now ABORT command will be sent
> before disconnecting with server in that scenario.
>
> This change is required to pass TC_CLIENT_OPH_BV_27_I PTS
> test case (not mandatory for qualification).
> ---
> gwobex/obex-xfer.c | 8 --------
> 1 files changed, 0 insertions(+), 8 deletions(-)
Applied. Thanks.
Johan
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-08-09 10:01 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-08-09 9:41 [PATCHv2 obexd] Use 'nice abort' when canceling outgoing OPP transer Radoslaw Jablonski
2011-08-09 10:01 ` Johan Hedberg
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.