From: "G, Manjunath Kondaiah" <manjugk@ti.com> To: Grant Likely <grant.likely@secretlab.ca> Cc: "Cousson, Benoit" <b-cousson@ti.com>, "devicetree-discuss@lists.ozlabs.org" <devicetree-discuss@lists.ozlabs.org>, "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org> Subject: Re: [RFC/PATCH 10/14] dt: Add pd_size to AUXDATA structure Date: Wed, 10 Aug 2011 21:32:04 +0530 [thread overview] Message-ID: <20110810160204.GA2091@manju-desktop> (raw) In-Reply-To: <CACxGe6tq43M6x-pQS4CHTsjiNORLgMzWXL7Hn0GzTFMNCrRzAA@mail.gmail.com> On Wed, Aug 10, 2011 at 07:16:30AM -0600, Grant Likely wrote: > On Wed, Aug 10, 2011 at 5:57 AM, Cousson, Benoit <b-cousson@ti.com> wrote: > > On 8/9/2011 4:10 PM, G, Manjunath Kondaiah wrote: > >> > >> Add pd_size in the AUXDATA structure so that device drivers which require > >> platform_data size can pass along with AUXDATA. > > > > It is really needed by device driver? Or is it because omap_device_build is > > using platform_device_add_data that is doing a copy of the pdata and thus > > require the size? > > Yes, I have the same question. What is the reason for needing the > platform data size? Yes. It is required by "omap_device_build" which in turn calls "platform_device_add_data" and copies using "kmemdup" and original pdata pointer memory will get freed. It is required by hwmod and not device driver. I can change description. > > g. > > > > >> Signed-off-by: G, Manjunath Kondaiah<manjugk@ti.com> > >> --- > >> drivers/of/platform.c | 2 ++ > >> include/linux/of_platform.h | 5 +++++ > >> 2 files changed, 7 insertions(+), 0 deletions(-) > >> > >> diff --git a/drivers/of/platform.c b/drivers/of/platform.c > >> index ebbbf42..4b27286 100644 > >> --- a/drivers/of/platform.c > >> +++ b/drivers/of/platform.c > >> @@ -565,6 +565,7 @@ static int of_platform_bus_create(struct device_node > >> *bus, > >> struct platform_device *dev; > >> const char *bus_id = NULL; > >> void *platform_data = NULL; > >> + int pd_size; > > > > Maybe platform_data_size will be a little bit more consistent? Thought shorter name is better and still it should be readable. -M -- To unsubscribe from this list: send the line "unsubscribe linux-omap" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: manjugk@ti.com (G, Manjunath Kondaiah) To: linux-arm-kernel@lists.infradead.org Subject: [RFC/PATCH 10/14] dt: Add pd_size to AUXDATA structure Date: Wed, 10 Aug 2011 21:32:04 +0530 [thread overview] Message-ID: <20110810160204.GA2091@manju-desktop> (raw) In-Reply-To: <CACxGe6tq43M6x-pQS4CHTsjiNORLgMzWXL7Hn0GzTFMNCrRzAA@mail.gmail.com> On Wed, Aug 10, 2011 at 07:16:30AM -0600, Grant Likely wrote: > On Wed, Aug 10, 2011 at 5:57 AM, Cousson, Benoit <b-cousson@ti.com> wrote: > > On 8/9/2011 4:10 PM, G, Manjunath Kondaiah wrote: > >> > >> Add pd_size in the AUXDATA structure so that device drivers which require > >> platform_data size can pass along with AUXDATA. > > > > It is really needed by device driver? Or is it because omap_device_build is > > using platform_device_add_data that is doing a copy of the pdata and thus > > require the size? > > Yes, I have the same question. What is the reason for needing the > platform data size? Yes. It is required by "omap_device_build" which in turn calls "platform_device_add_data" and copies using "kmemdup" and original pdata pointer memory will get freed. It is required by hwmod and not device driver. I can change description. > > g. > > > > >> Signed-off-by: G, Manjunath Kondaiah<manjugk@ti.com> > >> --- > >> ?drivers/of/platform.c ? ? ? | ? ?2 ++ > >> ?include/linux/of_platform.h | ? ?5 +++++ > >> ?2 files changed, 7 insertions(+), 0 deletions(-) > >> > >> diff --git a/drivers/of/platform.c b/drivers/of/platform.c > >> index ebbbf42..4b27286 100644 > >> --- a/drivers/of/platform.c > >> +++ b/drivers/of/platform.c > >> @@ -565,6 +565,7 @@ static int of_platform_bus_create(struct device_node > >> *bus, > >> ? ? ? ?struct platform_device *dev; > >> ? ? ? ?const char *bus_id = NULL; > >> ? ? ? ?void *platform_data = NULL; > >> + ? ? ? int pd_size; > > > > Maybe platform_data_size will be a little bit more consistent? Thought shorter name is better and still it should be readable. -M
next prev parent reply other threads:[~2011-08-10 16:02 UTC|newest] Thread overview: 63+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-08-09 14:10 [RFC/PATCH 00/14] dt: omap hwmod-dt binding and omap3 i2c1 dt support G, Manjunath Kondaiah 2011-08-09 14:10 ` [RFC/PATCH 01/14] OMAP: omap_device: replace _find_by_pdev() with to_omap_device() G, Manjunath Kondaiah 2011-08-09 14:10 ` [RFC/PATCH 02/14] OMAP: omap_device: replace debug/warning/error prints with dev_* macros G, Manjunath Kondaiah 2011-08-09 14:10 ` [RFC/PATCH 03/14] OMAP3: beagle: don't touch omap_device internals G, Manjunath Kondaiah 2011-08-09 14:10 ` [RFC/PATCH 04/14] OMAP: McBSP: use existing macros for converting between devices G, Manjunath Kondaiah 2011-08-10 7:07 ` Jarkko Nikula 2011-08-10 7:07 ` Jarkko Nikula 2011-08-10 10:15 ` Cousson, Benoit 2011-08-10 10:15 ` Cousson, Benoit 2011-08-10 16:05 ` G, Manjunath Kondaiah 2011-08-10 16:05 ` G, Manjunath Kondaiah 2011-08-09 14:10 ` [RFC/PATCH 05/14] OMAP: omap_device: remove internal functions from omap_device.h G, Manjunath Kondaiah 2011-08-09 14:10 ` [RFC/PATCH 06/14] OMAP: omap_device: when building return platform_device instead of omap_device G, Manjunath Kondaiah 2011-08-09 14:10 ` [RFC/PATCH 07/14] ARM: platform_device: pdev_archdata: add omap_device pointer G, Manjunath Kondaiah 2011-08-09 14:10 ` [RFC/PATCH 08/14] omap2+: Use Kconfig symbol in Makefile instead of obj-y G, Manjunath Kondaiah 2011-08-09 14:10 ` [RFC/PATCH 09/14] dt: omap: prepare hwmod to support dt G, Manjunath Kondaiah 2011-08-10 11:51 ` Cousson, Benoit 2011-08-10 11:51 ` Cousson, Benoit 2011-08-10 16:28 ` G, Manjunath Kondaiah 2011-08-10 16:28 ` G, Manjunath Kondaiah 2011-08-10 17:11 ` Cousson, Benoit 2011-08-10 17:11 ` Cousson, Benoit 2011-08-10 18:03 ` G, Manjunath Kondaiah 2011-08-10 18:03 ` G, Manjunath Kondaiah [not found] ` <CAC63_iSX0cjauOj=CcTABqgSWAgYRE_G7Qio5y2BrpeRnkhEWQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2011-08-10 18:06 ` Cousson, Benoit 2011-08-10 18:06 ` Cousson, Benoit 2011-08-16 15:02 ` G, Manjunath Kondaiah 2011-08-16 15:02 ` G, Manjunath Kondaiah 2011-08-09 14:10 ` [RFC/PATCH 10/14] dt: Add pd_size to AUXDATA structure G, Manjunath Kondaiah [not found] ` <1312897232-4792-11-git-send-email-manjugk-l0cyMroinI0@public.gmane.org> 2011-08-10 11:57 ` Cousson, Benoit 2011-08-10 11:57 ` Cousson, Benoit 2011-08-10 13:16 ` Grant Likely 2011-08-10 13:16 ` Grant Likely 2011-08-10 16:02 ` G, Manjunath Kondaiah [this message] 2011-08-10 16:02 ` G, Manjunath Kondaiah 2011-08-09 14:10 ` [RFC/PATCH 11/14] dt: omap3: add soc file for handling i2c controllers G, Manjunath Kondaiah 2011-08-10 12:36 ` Cousson, Benoit 2011-08-10 12:36 ` Cousson, Benoit 2011-08-10 16:57 ` G, Manjunath Kondaiah 2011-08-10 16:57 ` G, Manjunath Kondaiah 2011-08-10 17:45 ` Cousson, Benoit 2011-08-10 17:45 ` Cousson, Benoit 2011-08-16 6:32 ` G, Manjunath Kondaiah 2011-08-16 6:32 ` G, Manjunath Kondaiah 2011-08-09 14:10 ` [RFC/PATCH 12/14] dt: omap3: beagle board: set clock freq for i2c devices G, Manjunath Kondaiah 2011-08-10 12:42 ` Cousson, Benoit 2011-08-10 12:42 ` Cousson, Benoit 2011-08-10 16:45 ` G, Manjunath Kondaiah 2011-08-10 16:45 ` G, Manjunath Kondaiah 2011-08-09 14:10 ` [RFC/PATCH 13/14] dt: omap3: add generic board file for dt support G, Manjunath Kondaiah 2011-08-09 14:10 ` [RFC/PATCH 14/14] dt: omap3: enable dt support for i2c1 controller G, Manjunath Kondaiah 2011-08-10 12:57 ` Cousson, Benoit 2011-08-10 12:57 ` Cousson, Benoit 2011-08-16 18:44 ` G, Manjunath Kondaiah 2011-08-16 18:44 ` G, Manjunath Kondaiah 2011-08-10 5:26 ` [RFC/PATCH 00/14] dt: omap hwmod-dt binding and omap3 i2c1 dt support Rajendra Nayak 2011-08-10 5:26 ` Rajendra Nayak 2011-08-10 5:30 ` G, Manjunath Kondaiah 2011-08-10 5:30 ` G, Manjunath Kondaiah 2011-08-10 5:39 ` Rajendra Nayak 2011-08-10 5:39 ` Rajendra Nayak 2011-08-10 6:28 ` G, Manjunath Kondaiah 2011-08-10 6:28 ` G, Manjunath Kondaiah
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20110810160204.GA2091@manju-desktop \ --to=manjugk@ti.com \ --cc=b-cousson@ti.com \ --cc=devicetree-discuss@lists.ozlabs.org \ --cc=grant.likely@secretlab.ca \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-omap@vger.kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.