* [PATCH] SCSI: OSD: Kconfig: Select SHA1 and HMAC for OSD Initiator library
@ 2011-08-11 14:27 Maxin B. John
2011-08-14 23:18 ` Maxin B John
0 siblings, 1 reply; 9+ messages in thread
From: Maxin B. John @ 2011-08-11 14:27 UTC (permalink / raw)
To: rdunlap
Cc: Boaz Harrosh, Benny Halevy, James E.J. Bottomley, osd-dev,
linux-scsi, linux-kernel
SCSI_OSD_INITIATOR should select CRYPTO_SHA1 and CRYPTO_HMAC. Express this
in Kconfig so that the requirements are met automatically.
Signed-off-by: Maxin B. John <maxin.john@gmail.com>
---
diff --git a/drivers/scsi/osd/Kconfig b/drivers/scsi/osd/Kconfig
index 861b5ce..1535fe1 100644
--- a/drivers/scsi/osd/Kconfig
+++ b/drivers/scsi/osd/Kconfig
@@ -11,17 +11,16 @@
# it under the terms of the GNU General Public version 2 License as
# published by the Free Software Foundation
#
-# FIXME: SCSI_OSD_INITIATOR should select CONFIG (HMAC) SHA1 somehow.
-# How is it done properly?
#
config SCSI_OSD_INITIATOR
tristate "OSD-Initiator library"
depends on SCSI
+ select CRYPTO
+ select CRYPTO_SHA1
+ select CRYPTO_HMAC
help
Enable the OSD-Initiator library (libosd.ko).
- NOTE: You must also select CRYPTO_SHA1 + CRYPTO_HMAC and their
- dependencies
config SCSI_OSD_ULD
tristate "OSD Upper Level driver"
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] SCSI: OSD: Kconfig: Select SHA1 and HMAC for OSD Initiator library
2011-08-11 14:27 [PATCH] SCSI: OSD: Kconfig: Select SHA1 and HMAC for OSD Initiator library Maxin B. John
@ 2011-08-14 23:18 ` Maxin B John
0 siblings, 0 replies; 9+ messages in thread
From: Maxin B John @ 2011-08-14 23:18 UTC (permalink / raw)
To: rdunlap
Cc: Boaz Harrosh, Benny Halevy, James E.J. Bottomley, osd-dev,
linux-scsi, linux-kernel
Ping..
On Thu, Aug 11, 2011 at 5:27 PM, Maxin B. John <maxin.john@gmail.com> wrote:
> SCSI_OSD_INITIATOR should select CRYPTO_SHA1 and CRYPTO_HMAC. Express this
> in Kconfig so that the requirements are met automatically.
>
> Signed-off-by: Maxin B. John <maxin.john@gmail.com>
> ---
> diff --git a/drivers/scsi/osd/Kconfig b/drivers/scsi/osd/Kconfig
> index 861b5ce..1535fe1 100644
> --- a/drivers/scsi/osd/Kconfig
> +++ b/drivers/scsi/osd/Kconfig
> @@ -11,17 +11,16 @@
> # it under the terms of the GNU General Public version 2 License as
> # published by the Free Software Foundation
> #
> -# FIXME: SCSI_OSD_INITIATOR should select CONFIG (HMAC) SHA1 somehow.
> -# How is it done properly?
> #
>
> config SCSI_OSD_INITIATOR
> tristate "OSD-Initiator library"
> depends on SCSI
> + select CRYPTO
> + select CRYPTO_SHA1
> + select CRYPTO_HMAC
> help
> Enable the OSD-Initiator library (libosd.ko).
> - NOTE: You must also select CRYPTO_SHA1 + CRYPTO_HMAC and their
> - dependencies
>
> config SCSI_OSD_ULD
> tristate "OSD Upper Level driver"
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] SCSI: OSD: Kconfig: Select SHA1 and HMAC for OSD Initiator library
@ 2011-08-14 23:18 ` Maxin B John
0 siblings, 0 replies; 9+ messages in thread
From: Maxin B John @ 2011-08-14 23:18 UTC (permalink / raw)
To: rdunlap
Cc: Boaz Harrosh, Benny Halevy, James E.J. Bottomley, osd-dev,
linux-scsi, linux-kernel
Ping..
On Thu, Aug 11, 2011 at 5:27 PM, Maxin B. John <maxin.john@gmail.com> wrote:
> SCSI_OSD_INITIATOR should select CRYPTO_SHA1 and CRYPTO_HMAC. Express this
> in Kconfig so that the requirements are met automatically.
>
> Signed-off-by: Maxin B. John <maxin.john@gmail.com>
> ---
> diff --git a/drivers/scsi/osd/Kconfig b/drivers/scsi/osd/Kconfig
> index 861b5ce..1535fe1 100644
> --- a/drivers/scsi/osd/Kconfig
> +++ b/drivers/scsi/osd/Kconfig
> @@ -11,17 +11,16 @@
> # it under the terms of the GNU General Public version 2 License as
> # published by the Free Software Foundation
> #
> -# FIXME: SCSI_OSD_INITIATOR should select CONFIG (HMAC) SHA1 somehow.
> -# How is it done properly?
> #
>
> config SCSI_OSD_INITIATOR
> tristate "OSD-Initiator library"
> depends on SCSI
> + select CRYPTO
> + select CRYPTO_SHA1
> + select CRYPTO_HMAC
> help
> Enable the OSD-Initiator library (libosd.ko).
> - NOTE: You must also select CRYPTO_SHA1 + CRYPTO_HMAC and their
> - dependencies
>
> config SCSI_OSD_ULD
> tristate "OSD Upper Level driver"
>
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] SCSI: OSD: Kconfig: Select SHA1 and HMAC for OSD Initiator library
2011-08-14 23:18 ` Maxin B John
@ 2011-08-15 18:44 ` Boaz Harrosh
-1 siblings, 0 replies; 9+ messages in thread
From: Boaz Harrosh @ 2011-08-15 18:44 UTC (permalink / raw)
To: Maxin B John
Cc: rdunlap, Benny Halevy, James E.J. Bottomley, osd-dev, linux-scsi,
linux-kernel
On 08/14/2011 04:18 PM, Maxin B John wrote:
> Ping..
>
> On Thu, Aug 11, 2011 at 5:27 PM, Maxin B. John <maxin.john@gmail.com> wrote:
>> SCSI_OSD_INITIATOR should select CRYPTO_SHA1 and CRYPTO_HMAC. Express this
>> in Kconfig so that the requirements are met automatically.
>>
>> Signed-off-by: Maxin B. John <maxin.john@gmail.com>
Yes sorry. It was on my todo and I never got to it.
OK So actually current osd_initiator code does not use these libraries.
It should, and I have very old code that started on that (hence the comment),
but it was never submitted to Kernel. The OSD protocol calls for all kind of
security levels that use these, but the current code only supports NO_SEC.
I will keep your patch for when security code goes in. Meanwhile I should
at least remove the stale comment.
Thanks
Boaz
>> ---
>> diff --git a/drivers/scsi/osd/Kconfig b/drivers/scsi/osd/Kconfig
>> index 861b5ce..1535fe1 100644
>> --- a/drivers/scsi/osd/Kconfig
>> +++ b/drivers/scsi/osd/Kconfig
>> @@ -11,17 +11,16 @@
>> # it under the terms of the GNU General Public version 2 License as
>> # published by the Free Software Foundation
>> #
>> -# FIXME: SCSI_OSD_INITIATOR should select CONFIG (HMAC) SHA1 somehow.
>> -# How is it done properly?
>> #
>>
>> config SCSI_OSD_INITIATOR
>> tristate "OSD-Initiator library"
>> depends on SCSI
>> + select CRYPTO
>> + select CRYPTO_SHA1
>> + select CRYPTO_HMAC
>> help
>> Enable the OSD-Initiator library (libosd.ko).
>> - NOTE: You must also select CRYPTO_SHA1 + CRYPTO_HMAC and their
>> - dependencies
>>
>> config SCSI_OSD_ULD
>> tristate "OSD Upper Level driver"
>>
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] SCSI: OSD: Kconfig: Select SHA1 and HMAC for OSD Initiator library
@ 2011-08-15 18:44 ` Boaz Harrosh
0 siblings, 0 replies; 9+ messages in thread
From: Boaz Harrosh @ 2011-08-15 18:44 UTC (permalink / raw)
To: Maxin B John
Cc: rdunlap, Benny Halevy, James E.J. Bottomley, osd-dev, linux-scsi,
linux-kernel
On 08/14/2011 04:18 PM, Maxin B John wrote:
> Ping..
>
> On Thu, Aug 11, 2011 at 5:27 PM, Maxin B. John <maxin.john@gmail.com> wrote:
>> SCSI_OSD_INITIATOR should select CRYPTO_SHA1 and CRYPTO_HMAC. Express this
>> in Kconfig so that the requirements are met automatically.
>>
>> Signed-off-by: Maxin B. John <maxin.john@gmail.com>
Yes sorry. It was on my todo and I never got to it.
OK So actually current osd_initiator code does not use these libraries.
It should, and I have very old code that started on that (hence the comment),
but it was never submitted to Kernel. The OSD protocol calls for all kind of
security levels that use these, but the current code only supports NO_SEC.
I will keep your patch for when security code goes in. Meanwhile I should
at least remove the stale comment.
Thanks
Boaz
>> ---
>> diff --git a/drivers/scsi/osd/Kconfig b/drivers/scsi/osd/Kconfig
>> index 861b5ce..1535fe1 100644
>> --- a/drivers/scsi/osd/Kconfig
>> +++ b/drivers/scsi/osd/Kconfig
>> @@ -11,17 +11,16 @@
>> # it under the terms of the GNU General Public version 2 License as
>> # published by the Free Software Foundation
>> #
>> -# FIXME: SCSI_OSD_INITIATOR should select CONFIG (HMAC) SHA1 somehow.
>> -# How is it done properly?
>> #
>>
>> config SCSI_OSD_INITIATOR
>> tristate "OSD-Initiator library"
>> depends on SCSI
>> + select CRYPTO
>> + select CRYPTO_SHA1
>> + select CRYPTO_HMAC
>> help
>> Enable the OSD-Initiator library (libosd.ko).
>> - NOTE: You must also select CRYPTO_SHA1 + CRYPTO_HMAC and their
>> - dependencies
>>
>> config SCSI_OSD_ULD
>> tristate "OSD Upper Level driver"
>>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH] osd: Kconfig remove wrong FIXME
2011-08-15 18:44 ` Boaz Harrosh
(?)
@ 2011-08-15 19:01 ` Boaz Harrosh
2011-08-25 13:15 ` Maxin B John
-1 siblings, 1 reply; 9+ messages in thread
From: Boaz Harrosh @ 2011-08-15 19:01 UTC (permalink / raw)
To: James E.J. Bottomley, Maxin B John; +Cc: rdunlap, osd-dev, linux-scsi
The OSD protocol calls for all kind of security levels that use
CRYPTO_HMAC and SH1, but the current code only supports NO_SEC,
which does not use any of these.
Remove a wrong FIXME that calls for them. Thanks Maxin for
reporting on this.
CC: "Maxin B. John" <maxin.john@gmail.com>
Signed-off-by: Boaz Harrosh <bharrosh@panasas.com>
---
drivers/scsi/osd/Kconfig | 4 ----
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/drivers/scsi/osd/Kconfig b/drivers/scsi/osd/Kconfig
index 861b5ce..a070351 100644
--- a/drivers/scsi/osd/Kconfig
+++ b/drivers/scsi/osd/Kconfig
@@ -11,10 +11,6 @@
# it under the terms of the GNU General Public version 2 License as
# published by the Free Software Foundation
#
-# FIXME: SCSI_OSD_INITIATOR should select CONFIG (HMAC) SHA1 somehow.
-# How is it done properly?
-#
-
config SCSI_OSD_INITIATOR
tristate "OSD-Initiator library"
depends on SCSI
--
1.7.6
^ permalink raw reply related [flat|nested] 9+ messages in thread
* Re: [PATCH] SCSI: OSD: Kconfig: Select SHA1 and HMAC for OSD Initiator library
2011-08-15 18:44 ` Boaz Harrosh
(?)
(?)
@ 2011-08-25 13:10 ` Maxin B John
-1 siblings, 0 replies; 9+ messages in thread
From: Maxin B John @ 2011-08-25 13:10 UTC (permalink / raw)
To: Boaz Harrosh
Cc: rdunlap, Benny Halevy, James E.J. Bottomley, osd-dev, linux-scsi,
linux-kernel
Hi,
On Mon, Aug 15, 2011 at 9:44 PM, Boaz Harrosh <bharrosh@panasas.com> wrote:
> On 08/14/2011 04:18 PM, Maxin B John wrote:
>> On Thu, Aug 11, 2011 at 5:27 PM, Maxin B. John <maxin.john@gmail.com> wrote:
>>> SCSI_OSD_INITIATOR should select CRYPTO_SHA1 and CRYPTO_HMAC. Express this
>>> in Kconfig so that the requirements are met automatically.
>>>
>>> Signed-off-by: Maxin B. John <maxin.john@gmail.com>
>
> OK So actually current osd_initiator code does not use these libraries.
> It should, and I have very old code that started on that (hence the comment),
> but it was never submitted to Kernel. The OSD protocol calls for all kind of
> security levels that use these, but the current code only supports NO_SEC.
>
> I will keep your patch for when security code goes in. Meanwhile I should
> at least remove the stale comment.
Sorry for the delay in reply. Yes, this makes perfect sense to me.
Cheers,
Maxin
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] osd: Kconfig remove wrong FIXME
2011-08-15 19:01 ` [PATCH] osd: Kconfig remove wrong FIXME Boaz Harrosh
@ 2011-08-25 13:15 ` Maxin B John
2011-08-25 16:25 ` Boaz Harrosh
0 siblings, 1 reply; 9+ messages in thread
From: Maxin B John @ 2011-08-25 13:15 UTC (permalink / raw)
To: Boaz Harrosh; +Cc: James E.J. Bottomley, rdunlap, osd-dev, linux-scsi
Hi,
On Mon, Aug 15, 2011 at 10:01 PM, Boaz Harrosh <bharrosh@panasas.com> wrote:
>
> The OSD protocol calls for all kind of security levels that use
> CRYPTO_HMAC and SH1, but the current code only supports NO_SEC,
> which does not use any of these.
>
> Remove a wrong FIXME that calls for them. Thanks Maxin for
> reporting on this.
>
> CC: "Maxin B. John" <maxin.john@gmail.com>
> Signed-off-by: Boaz Harrosh <bharrosh@panasas.com>
> ---
> drivers/scsi/osd/Kconfig | 4 ----
> 1 files changed, 0 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/scsi/osd/Kconfig b/drivers/scsi/osd/Kconfig
> index 861b5ce..a070351 100644
> --- a/drivers/scsi/osd/Kconfig
> +++ b/drivers/scsi/osd/Kconfig
> @@ -11,10 +11,6 @@
> # it under the terms of the GNU General Public version 2 License as
> # published by the Free Software Foundation
> #
> -# FIXME: SCSI_OSD_INITIATOR should select CONFIG (HMAC) SHA1 somehow.
> -# How is it done properly?
> -#
> -
> config SCSI_OSD_INITIATOR
> tristate "OSD-Initiator library"
> depends on SCSI
> --
> 1.7.6
>
Adding the "Reported-by", if it's not too late:
Reported-by: Maxin B. John <maxin.john@gmail.com>
Cheers,
Maxin
--
To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH] osd: Kconfig remove wrong FIXME
2011-08-25 13:15 ` Maxin B John
@ 2011-08-25 16:25 ` Boaz Harrosh
0 siblings, 0 replies; 9+ messages in thread
From: Boaz Harrosh @ 2011-08-25 16:25 UTC (permalink / raw)
To: Maxin B John; +Cc: James E.J. Bottomley, rdunlap, osd-dev, linux-scsi
On 08/25/2011 06:15 AM, Maxin B John wrote:
> Hi,
>
> On Mon, Aug 15, 2011 at 10:01 PM, Boaz Harrosh <bharrosh@panasas.com> wrote:
>>
>> The OSD protocol calls for all kind of security levels that use
>> CRYPTO_HMAC and SH1, but the current code only supports NO_SEC,
>> which does not use any of these.
>>
>> Remove a wrong FIXME that calls for them. Thanks Maxin for
>> reporting on this.
>>
>> CC: "Maxin B. John" <maxin.john@gmail.com>
>> Signed-off-by: Boaz Harrosh <bharrosh@panasas.com>
>> ---
>> drivers/scsi/osd/Kconfig | 4 ----
>> 1 files changed, 0 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/scsi/osd/Kconfig b/drivers/scsi/osd/Kconfig
>> index 861b5ce..a070351 100644
>> --- a/drivers/scsi/osd/Kconfig
>> +++ b/drivers/scsi/osd/Kconfig
>> @@ -11,10 +11,6 @@
>> # it under the terms of the GNU General Public version 2 License as
>> # published by the Free Software Foundation
>> #
>> -# FIXME: SCSI_OSD_INITIATOR should select CONFIG (HMAC) SHA1 somehow.
>> -# How is it done properly?
>> -#
>> -
>> config SCSI_OSD_INITIATOR
>> tristate "OSD-Initiator library"
>> depends on SCSI
>> --
>> 1.7.6
>>
>
> Adding the "Reported-by", if it's not too late:
>
> Reported-by: Maxin B. John <maxin.john@gmail.com>
>
Sure I will add it. It's not to late
Boaz
> Cheers,
> Maxin
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2011-08-25 16:25 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-08-11 14:27 [PATCH] SCSI: OSD: Kconfig: Select SHA1 and HMAC for OSD Initiator library Maxin B. John
2011-08-14 23:18 ` Maxin B John
2011-08-14 23:18 ` Maxin B John
2011-08-15 18:44 ` Boaz Harrosh
2011-08-15 18:44 ` Boaz Harrosh
2011-08-15 19:01 ` [PATCH] osd: Kconfig remove wrong FIXME Boaz Harrosh
2011-08-25 13:15 ` Maxin B John
2011-08-25 16:25 ` Boaz Harrosh
2011-08-25 13:10 ` [PATCH] SCSI: OSD: Kconfig: Select SHA1 and HMAC for OSD Initiator library Maxin B John
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.