All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] xfs: fix tracing builds inside the source tree
@ 2011-08-14 17:13 Christoph Hellwig
  2011-08-22  6:47 ` Dave Chinner
  0 siblings, 1 reply; 2+ messages in thread
From: Christoph Hellwig @ 2011-08-14 17:13 UTC (permalink / raw)
  To: xfs

The code really requires the current source directory to be in the
header search path.  We already do this if building with an object
tree separate from the source, but it needs to be added manually
if building inside the source.  The cflags addition for it accidentally
got removed when collapsing the xfs directory structure.

Signed-off-by: Christoph Hellwig <hch@lst.de>

Index: xfs/fs/xfs/Makefile
===================================================================
--- xfs.orig/fs/xfs/Makefile	2011-08-13 06:41:29.586063467 -0700
+++ xfs/fs/xfs/Makefile	2011-08-13 06:41:58.245908204 -0700
@@ -16,6 +16,8 @@
 # Inc.,  51 Franklin St, Fifth Floor, Boston, MA  02110-1301  USA
 #
 
+ccflags-y += -I$(src)			# needed for trace events
+
 ccflags-$(CONFIG_XFS_DEBUG) += -g
 
 obj-$(CONFIG_XFS_FS)		+= xfs.o

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] xfs: fix tracing builds inside the source tree
  2011-08-14 17:13 [PATCH] xfs: fix tracing builds inside the source tree Christoph Hellwig
@ 2011-08-22  6:47 ` Dave Chinner
  0 siblings, 0 replies; 2+ messages in thread
From: Dave Chinner @ 2011-08-22  6:47 UTC (permalink / raw)
  To: Christoph Hellwig; +Cc: xfs

On Sun, Aug 14, 2011 at 01:13:00PM -0400, Christoph Hellwig wrote:
> The code really requires the current source directory to be in the
> header search path.  We already do this if building with an object
> tree separate from the source, but it needs to be added manually
> if building inside the source.  The cflags addition for it accidentally
> got removed when collapsing the xfs directory structure.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Not really necessary, but:

Reviewed-by: Dave Chinner <david@fromorbit.com>

-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2011-08-22  6:48 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-08-14 17:13 [PATCH] xfs: fix tracing builds inside the source tree Christoph Hellwig
2011-08-22  6:47 ` Dave Chinner

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.