All of lore.kernel.org
 help / color / mirror / Atom feed
* [Qemu-devel] [PATCH] pcnet: fix wrong opaque (broken by bd8d6f7cadb6ace98c779135217a4ed7b5fccc23)
@ 2011-08-20 14:29 Hervé Poussineau
  2011-08-22  8:48 ` Stefan Hajnoczi
  2011-08-22 16:33 ` Anthony Liguori
  0 siblings, 2 replies; 3+ messages in thread
From: Hervé Poussineau @ 2011-08-20 14:29 UTC (permalink / raw)
  To: qemu-devel; +Cc: Hervé Poussineau


Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
---
 hw/pcnet-pci.c |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/hw/pcnet-pci.c b/hw/pcnet-pci.c
index 13d9380..51e1320 100644
--- a/hw/pcnet-pci.c
+++ b/hw/pcnet-pci.c
@@ -290,10 +290,10 @@ static int pci_pcnet_init(PCIDevice *pci_dev)
     pci_conf[PCI_MAX_LAT] = 0xff;
 
     /* Handler for memory-mapped I/O */
-    memory_region_init_io(&d->state.mmio, &pcnet_mmio_ops, d, "pcnet-mmio",
+    memory_region_init_io(&d->state.mmio, &pcnet_mmio_ops, s, "pcnet-mmio",
                           PCNET_PNPMMIO_SIZE);
 
-    memory_region_init_io(&d->io_bar, &pcnet_io_ops, d, "pcnet-io",
+    memory_region_init_io(&d->io_bar, &pcnet_io_ops, s, "pcnet-io",
                           PCNET_IOPORT_SIZE);
     pci_register_bar(pci_dev, 0, PCI_BASE_ADDRESS_SPACE_IO, &d->io_bar);
 
-- 
1.7.5.4

^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [Qemu-devel] [PATCH] pcnet: fix wrong opaque (broken by bd8d6f7cadb6ace98c779135217a4ed7b5fccc23)
  2011-08-20 14:29 [Qemu-devel] [PATCH] pcnet: fix wrong opaque (broken by bd8d6f7cadb6ace98c779135217a4ed7b5fccc23) Hervé Poussineau
@ 2011-08-22  8:48 ` Stefan Hajnoczi
  2011-08-22 16:33 ` Anthony Liguori
  1 sibling, 0 replies; 3+ messages in thread
From: Stefan Hajnoczi @ 2011-08-22  8:48 UTC (permalink / raw)
  To: Hervé Poussineau; +Cc: qemu-devel

On Sat, Aug 20, 2011 at 04:29:50PM +0200, Hervé Poussineau wrote:
> 
> Signed-off-by: Hervé Poussineau <hpoussin@reactos.org>
> ---
>  hw/pcnet-pci.c |    4 ++--
>  1 files changed, 2 insertions(+), 2 deletions(-)

Reviewed-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [Qemu-devel] [PATCH] pcnet: fix wrong opaque (broken by bd8d6f7cadb6ace98c779135217a4ed7b5fccc23)
  2011-08-20 14:29 [Qemu-devel] [PATCH] pcnet: fix wrong opaque (broken by bd8d6f7cadb6ace98c779135217a4ed7b5fccc23) Hervé Poussineau
  2011-08-22  8:48 ` Stefan Hajnoczi
@ 2011-08-22 16:33 ` Anthony Liguori
  1 sibling, 0 replies; 3+ messages in thread
From: Anthony Liguori @ 2011-08-22 16:33 UTC (permalink / raw)
  To: Hervé Poussineau; +Cc: qemu-devel

On 08/20/2011 09:29 AM, Hervé Poussineau wrote:
>
> Signed-off-by: Hervé Poussineau<hpoussin@reactos.org>

Applied.  Thanks.

Regards,

Anthony Liguori

> ---
>   hw/pcnet-pci.c |    4 ++--
>   1 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/pcnet-pci.c b/hw/pcnet-pci.c
> index 13d9380..51e1320 100644
> --- a/hw/pcnet-pci.c
> +++ b/hw/pcnet-pci.c
> @@ -290,10 +290,10 @@ static int pci_pcnet_init(PCIDevice *pci_dev)
>       pci_conf[PCI_MAX_LAT] = 0xff;
>
>       /* Handler for memory-mapped I/O */
> -    memory_region_init_io(&d->state.mmio,&pcnet_mmio_ops, d, "pcnet-mmio",
> +    memory_region_init_io(&d->state.mmio,&pcnet_mmio_ops, s, "pcnet-mmio",
>                             PCNET_PNPMMIO_SIZE);
>
> -    memory_region_init_io(&d->io_bar,&pcnet_io_ops, d, "pcnet-io",
> +    memory_region_init_io(&d->io_bar,&pcnet_io_ops, s, "pcnet-io",
>                             PCNET_IOPORT_SIZE);
>       pci_register_bar(pci_dev, 0, PCI_BASE_ADDRESS_SPACE_IO,&d->io_bar);
>

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2011-08-22 16:33 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-08-20 14:29 [Qemu-devel] [PATCH] pcnet: fix wrong opaque (broken by bd8d6f7cadb6ace98c779135217a4ed7b5fccc23) Hervé Poussineau
2011-08-22  8:48 ` Stefan Hajnoczi
2011-08-22 16:33 ` Anthony Liguori

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.